From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, jbobek@nvidia.com
Cc: Harry Liebel <Harry.Liebel@arm.com>,
Olivier Martin <olivier.martin@arm.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Jeff Brasen <jbrasen@nvidia.com>,
Ashish Singhal <ashishsingha@nvidia.com>,
Leif Lindholm <leif@nuviainc.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Zhiguang Liu <zhiguang.liu@intel.com>
Subject: Re: [edk2-devel] [PATCH 0/1] MdePkg/BaseLib: AArch64 SetJump/LongJump bugfix
Date: Thu, 1 Oct 2020 15:02:16 +0200 [thread overview]
Message-ID: <5aab64a3-c749-c82f-3022-38791555ef72@redhat.com> (raw)
In-Reply-To: <cover.1601327092.git.jbobek@nvidia.com>
On 09/29/20 03:12, Jan Bobek wrote:
> Hi all,
>
> I have recently discovered a bug in the BaseLib's implementation of
> SetJump and LongJump; the offsets listed in the assembly files are 8
> bytes off, causing the functions to read/write 8 bytes past the end of
> the jump buffer. More details can be found in the commit message.
>
> I must admit I am a bit surprised this has not bee caught before,
> especially since the original implementation dates some 7 years back;
> if there is something obvious that I am missing, please let me
> know. Also, I am cc'ing all the people who signed off or reviewed the
> original commit.
>
> Note that this is my first contribution to EDK-II; I have tried to
> follow the guidelines as closely as possible, but if there is still
> something wrong with formatting etc., let me know and I shall submit a
> v2 with the issues fixed. That being said, I did run PatchCheck.py and
> it reported no errors.
>
> Cheers!
> -Jan Bobek
>
> Jan Bobek (1):
> MdePkg/BaseLib: Fix invalid memory access in AArch64 SetJump/LongJump
>
> MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S | 8 ++++----
> MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
Please run the patches through "BaseTools/Scripts/GetMaintainer.py", for
determining the people who should be CC'd. For this series:
Leif Lindholm <leif@nuviainc.com>
Ard Biesheuvel <ard.biesheuvel@arm.com>
Michael D Kinney <michael.d.kinney@intel.com>
Liming Gao <gaoliming@byosoft.com.cn>
Zhiguang Liu <zhiguang.liu@intel.com>
I'm correcting the CC list now.
Thanks,
Laszlo
prev parent reply other threads:[~2020-10-01 13:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 1:12 [PATCH 0/1] MdePkg/BaseLib: AArch64 SetJump/LongJump bugfix jbobek
2020-09-29 1:12 ` [PATCH 1/1] MdePkg/BaseLib: Fix invalid memory access in AArch64 SetJump/LongJump Jan Bobek
2020-10-01 13:04 ` [edk2-devel] " Laszlo Ersek
2020-10-01 13:17 ` Ard Biesheuvel
2020-10-01 15:39 ` Jan Bobek
2020-10-01 13:02 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5aab64a3-c749-c82f-3022-38791555ef72@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox