From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web10.12028.1601557360806659155 for ; Thu, 01 Oct 2020 06:02:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AO9TVXCr; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601557359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5c6d2NQMJljjdYlqclzNbxQIVBQ3cMwBgi0IExbbr2o=; b=AO9TVXCr4VvHofX5o1Sg+0Ti5iUx5o0FryYJQZ0TS5vHgcaafUXwC4xMqhnhlUMISHetId eJdgcfPRzlu6uE6mR7Z7ZODjZKVhNrgCJGrEApgcxHaF/u5LekAExb8cnC8w9WXFtis83A IPdVH4V5R0DgxLZO+vjqxnvbF5LdBGo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-13-nXS4Bs1mMSK0yj3ERP1WuQ-1; Thu, 01 Oct 2020 09:02:24 -0400 X-MC-Unique: nXS4Bs1mMSK0yj3ERP1WuQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7888A1074665; Thu, 1 Oct 2020 13:02:22 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-110.ams2.redhat.com [10.36.113.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9C61B5D9E4; Thu, 1 Oct 2020 13:02:17 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 0/1] MdePkg/BaseLib: AArch64 SetJump/LongJump bugfix To: devel@edk2.groups.io, jbobek@nvidia.com Cc: Harry Liebel , Olivier Martin , Liming Gao , Jeff Brasen , Ashish Singhal , Leif Lindholm , Ard Biesheuvel , Michael D Kinney , Zhiguang Liu References: From: "Laszlo Ersek" Message-ID: <5aab64a3-c749-c82f-3022-38791555ef72@redhat.com> Date: Thu, 1 Oct 2020 15:02:16 +0200 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/29/20 03:12, Jan Bobek wrote: > Hi all, > > I have recently discovered a bug in the BaseLib's implementation of > SetJump and LongJump; the offsets listed in the assembly files are 8 > bytes off, causing the functions to read/write 8 bytes past the end of > the jump buffer. More details can be found in the commit message. > > I must admit I am a bit surprised this has not bee caught before, > especially since the original implementation dates some 7 years back; > if there is something obvious that I am missing, please let me > know. Also, I am cc'ing all the people who signed off or reviewed the > original commit. > > Note that this is my first contribution to EDK-II; I have tried to > follow the guidelines as closely as possible, but if there is still > something wrong with formatting etc., let me know and I shall submit a > v2 with the issues fixed. That being said, I did run PatchCheck.py and > it reported no errors. > > Cheers! > -Jan Bobek > > Jan Bobek (1): > MdePkg/BaseLib: Fix invalid memory access in AArch64 SetJump/LongJump > > MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S | 8 ++++---- > MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) > Please run the patches through "BaseTools/Scripts/GetMaintainer.py", for determining the people who should be CC'd. For this series: Leif Lindholm Ard Biesheuvel Michael D Kinney Liming Gao Zhiguang Liu I'm correcting the CC list now. Thanks, Laszlo