public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@Intel.com>
To: Shenglei Zhang <shenglei.zhang@intel.com>, edk2-devel@lists.01.org
Cc: Jordan Justen <jordan.l.justen@intel.com>, Andrew Fish <afish@apple.com>
Subject: Re: [PATCH] EmulatorPkg: Remove PcdShellFile in DSC
Date: Thu, 8 Nov 2018 13:38:28 +0800	[thread overview]
Message-ID: <5aad7d0c-6455-2ccd-4cb2-baf61c95c72c@Intel.com> (raw)
In-Reply-To: <20181108022822.17812-2-shenglei.zhang@intel.com>

On 11/8/2018 10:28 AM, Shenglei Zhang wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1298
> The change is based on the change below:
> https://lists.01.org/pipermail/edk2-devel/2018-November/031877.html
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>   EmulatorPkg/EmulatorPkg.dsc | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
> index 7af7a5ada0..4097e1192e 100644
> --- a/EmulatorPkg/EmulatorPkg.dsc
> +++ b/EmulatorPkg/EmulatorPkg.dsc
> @@ -196,7 +196,6 @@
>     # Change PcdBootManagerMenuFile to UiApp
>     gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
>   
> -  gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }
>   
>   #define BOOT_WITH_FULL_CONFIGURATION                  0x00
>   #define BOOT_WITH_MINIMAL_CONFIGURATION               0x01
> 
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

-- 
Thanks,
Ray


  reply	other threads:[~2018-11-08  5:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08  2:28 [PATCH] Nt32Pkg: Remove PcdShellFile in DSC Shenglei Zhang
2018-11-08  2:28 ` [PATCH] EmulatorPkg: " Shenglei Zhang
2018-11-08  5:38   ` Ni, Ruiyu [this message]
2018-11-08  4:33 ` [PATCH] Nt32Pkg: " Wu, Hao A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5aad7d0c-6455-2ccd-4cb2-baf61c95c72c@Intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox