From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 220AC2118D956 for ; Wed, 7 Nov 2018 21:37:07 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Nov 2018 21:37:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,478,1534834800"; d="scan'208";a="84849666" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.11]) ([10.239.9.11]) by fmsmga008.fm.intel.com with ESMTP; 07 Nov 2018 21:37:05 -0800 To: Shenglei Zhang , edk2-devel@lists.01.org Cc: Jordan Justen , Andrew Fish References: <20181108022822.17812-1-shenglei.zhang@intel.com> <20181108022822.17812-2-shenglei.zhang@intel.com> From: "Ni, Ruiyu" Message-ID: <5aad7d0c-6455-2ccd-4cb2-baf61c95c72c@Intel.com> Date: Thu, 8 Nov 2018 13:38:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181108022822.17812-2-shenglei.zhang@intel.com> Subject: Re: [PATCH] EmulatorPkg: Remove PcdShellFile in DSC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2018 05:37:07 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/8/2018 10:28 AM, Shenglei Zhang wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=1298 > The change is based on the change below: > https://lists.01.org/pipermail/edk2-devel/2018-November/031877.html > > Cc: Jordan Justen > Cc: Andrew Fish > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > EmulatorPkg/EmulatorPkg.dsc | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc > index 7af7a5ada0..4097e1192e 100644 > --- a/EmulatorPkg/EmulatorPkg.dsc > +++ b/EmulatorPkg/EmulatorPkg.dsc > @@ -196,7 +196,6 @@ > # Change PcdBootManagerMenuFile to UiApp > gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 } > > - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } > > #define BOOT_WITH_FULL_CONFIGURATION 0x00 > #define BOOT_WITH_MINIMAL_CONFIGURATION 0x01 > Reviewed-by: Ruiyu Ni -- Thanks, Ray