From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 34C9120958BD8 for ; Thu, 7 Sep 2017 15:53:01 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 528C08047E; Thu, 7 Sep 2017 22:55:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 528C08047E Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-54.rdu2.redhat.com [10.10.120.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id D118168D89; Thu, 7 Sep 2017 22:55:50 +0000 (UTC) To: Brijesh Singh , edk2-devel@lists.01.org Cc: Jordan Justen , Tom Lendacky , Ard Biesheuvel References: <1504265045-19008-1-git-send-email-brijesh.singh@amd.com> From: Laszlo Ersek Message-ID: <5acc27c6-df89-de89-d957-884fcbfe7d62@redhat.com> Date: Fri, 8 Sep 2017 00:55:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1504265045-19008-1-git-send-email-brijesh.singh@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 07 Sep 2017 22:55:52 +0000 (UTC) Subject: Re: [PATCH 0/5] OvmfPkg/VirtioNetDxe: map host address to device address X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Sep 2017 22:53:01 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Brijesh, On 09/01/17 13:24, Brijesh Singh wrote: > The patch updates VirtioNetDxe to use IOMMU-like member functions to > map the system physical address to device address for buffers > (including vring, device specific request and response pointed by > vring descriptor, and any furter memory reference by those request and > response). > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Tom Lendacky > Cc: Laszlo Ersek > > Repo: https://github.com/codomania/edk2 > Branch: virtio-net-1 > > Brijesh Singh (5): > OvmfPkg/VirtioNetDxe: map VRING using VirtioRingMap() > OvmfPkg/VirtioNetDxe: alloc RxBuf using AllocateSharedPages() > OvmfPkg/VirtioNetDxe: dynamically alloc transmit header > OvmfPkg/VirtioNetDxe: map virtio-net transmit request buffer > OvmfPkg/VirtioNetDxe: negotiate VIRTIO_F_IOMMU_PLATFORM > > OvmfPkg/VirtioNetDxe/VirtioNet.inf | 1 + > OvmfPkg/VirtioNetDxe/VirtioNet.h | 27 ++- > OvmfPkg/VirtioNetDxe/Events.c | 19 ++ > OvmfPkg/VirtioNetDxe/SnpGetStatus.c | 30 +++- > OvmfPkg/VirtioNetDxe/SnpInitialize.c | 185 ++++++++++++++++---- > OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c | 171 +++++++++++++++++- > OvmfPkg/VirtioNetDxe/SnpShutdown.c | 2 + > OvmfPkg/VirtioNetDxe/SnpTransmit.c | 37 +++- > 8 files changed, 427 insertions(+), 45 deletions(-) > just adding a pointer so that my comment is linked under this thread as well: [edk2] [PATCH 00/10] MdeModulePkg, OvmfPkg: unmap DMA buffers at ExitBootServices https://lists.01.org/pipermail/edk2-devel/2017-September/014304.html On 09/08/17 00:41, Laszlo Ersek wrote: > (The conversion of VirtioNetDxe to device addresses is still in > progress -- Brijesh, when you submit v2 of that, under this approach, > there is no need to change VirtioNetExitBoot() relative to current > upstream, and you can use VirtioOperationBusMasterRead to map outgoing > packets.) Thanks! Laszlo