From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.128.65; helo=mail-wm1-f65.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A12C2211575F2 for ; Tue, 6 Nov 2018 12:42:07 -0800 (PST) Received: by mail-wm1-f65.google.com with SMTP id a8-v6so13587977wmf.1 for ; Tue, 06 Nov 2018 12:42:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WHePyIYgTxKUhQkkULWF5rn/LN7H7LwY5F7QfgPe4DM=; b=npOVUtKwPWLlpLgfFPiIqsPH2Nujtdc8dZeZJekgsrxEChyr8/zzVU6c2WGJVh6PyI E+DxWNKU3D78xfp1ddCwM82UZc4bxqMrK7/SlfGZSwTZ55dpOFhN1P6MWRYE65yprr/7 F+33tw8rTzgo1VI/0ucJXwkfGV/JJ8Eu3mlRkLtqgeMXEQNabL8aIwzoRHQjyIInS2pM i9Qp81yDFO0ztuqjxjbOBCmoNrwxuGmhYxjSQOKx9rF0AqBvs0U/dQ4nzJaEaSTCnBWA ojjvUPOMBWGHadatSoruHVS6hB2ZhCW+BhxBEJOcXtgsMah2DwolnEz3Vi1CqtyGTG+K yqwA== X-Gm-Message-State: AGRZ1gKJnzV8XN6vf5BfL7qfApXItusSLoHYalgxadBgT5PY642Dq+lG TV3/0II5V9DvLVGm9vCaaQ8xEg== X-Google-Smtp-Source: AJdET5fJQZTuqogQP0ETw5jjZra+P8n7jvTvCmuA7JHqDEQcajaYWokkmRZoDoml004EPVlBd/G7LA== X-Received: by 2002:a1c:950f:: with SMTP id x15-v6mr3215207wmd.3.1541536926214; Tue, 06 Nov 2018 12:42:06 -0800 (PST) Received: from [192.168.1.74] (67.23.27.109.rev.sfr.net. [109.27.23.67]) by smtp.gmail.com with ESMTPSA id t198-v6sm5180540wmd.9.2018.11.06.12.41.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 12:42:05 -0800 (PST) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: michael.d.kinney@intel.com, eric.jin@intel.com References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> <20181106175833.26964-17-ard.biesheuvel@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <5add7a2c-379d-e6db-62a8-f88d5da65435@redhat.com> Date: Tue, 6 Nov 2018 21:41:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181106175833.26964-17-ard.biesheuvel@linaro.org> Subject: Re: [PATCH edk2-staging 16/19] IntelUndiPkg/GigUndiDxe: fix incorrect indentation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 20:42:08 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 6/11/18 18:58, Ard Biesheuvel wrote: > Silence a 'misleading indentation' GCC warning by fixing the > incorrect indentation. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c > index e9fc5394ab28..6ce9ac3c5195 100644 > --- a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c > +++ b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c > @@ -1102,13 +1102,13 @@ STATIC s32 e1000_check_for_copper_link_ich8lan(struct e1000_hw *hw) > if (!mac->get_link_status) > return E1000_SUCCESS; > > - /* First we want to see if the MII Status Register reports > - * link. If so, then we want to get the current speed/duplex > - * of the PHY. > - */ > - ret_val = e1000_phy_has_link_generic(hw, 1, 0, &link); > - if (ret_val) > - return ret_val; > + /* First we want to see if the MII Status Register reports > + * link. If so, then we want to get the current speed/duplex > + * of the PHY. > + */ > + ret_val = e1000_phy_has_link_generic(hw, 1, 0, &link); > + if (ret_val) > + return ret_val; > > if (hw->mac.type == e1000_pchlan) { > ret_val = e1000_k1_gig_workaround_hv(hw, link); >