From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.51]) by mx.groups.io with SMTP id smtpd.web10.21492.1655404407931686080 for ; Thu, 16 Jun 2022 11:33:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=1jZ8049F; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.51, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TjZOwpQ4wRs1LFHXtScsJbIIRkSCkWHbc5tYtRMK5SHPSNePUYMbam9yo/ghsJwVIf158NcQFRCduTgvwWQZvv/7Wsjexq+Fxh7qIwkfvOZg2pgbAs72Re/2R7yQsK+6Gg+5+cOq3MmkJR0WumFiY69NxHcHwTaPhbAIrx/CznmHUjEO+z9TEU0NQMZnPfujTvTeAsgAEYAw2pnqqfejEmFtXfjHeromSnGI1PLr0AX4EaxnP7NUcyZdeEn84uLxUcIJEudgfNF83DYsP/SJ7sxXuQQrTKhx0L/FJyshui8KQb/Yc0l3PP0AY5yGmGbttW4dcuEsMsENBCEy1uzc/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H6X8m5uZV21jWZx+aPqSsv/dmQmmc7FT//KrJV8ybGI=; b=OonT6oyDMfJC7DSmVlKL3BpO5wLNxRlQbxVkX0OgpBxfOUwiE3cXlp5ZRdd5437w+MkkZt1ELtQ19wVrOqANiBshqQn5h9MHjgK8FIuUEgas8V99kIwMBctc6peUEua5NLgZlhGVVtEcTdiZNJDGvKrIxiaf/QLtKVIoh+bLCFAmnGq1wtmTtZnI1TuT0L8VNsGjdYg0tvZB6knDW82AE8+xjXVDyD8HZ+2OPaL1/jCMK6hdwusXGCKsIScSm5AHeGfi2LhHzhJcaLv8y7ebyF236lTz6pEt2GT5OMRawpwBEtLS0tM7aNsKlSs+2JKhgfhrpGaSttUXkPfEpdP7Qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H6X8m5uZV21jWZx+aPqSsv/dmQmmc7FT//KrJV8ybGI=; b=1jZ8049FVnj58OJ8P62g2lEdHn68nD6vgz2eqS20AcnSTpXrvIbmdFxvJ1adMkyOd2/yp6QsUXqiJSaqKdADf2wP74ulYDZ+q/AJaa+LOpBEKkjviTpoS0//y8WNVhVh8LSmPa1pYo608CUAPyjbHf+CQNXLK+0tpvxO1w8RTIE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by CY4PR12MB1141.namprd12.prod.outlook.com (2603:10b6:903:44::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.20; Thu, 16 Jun 2022 18:33:25 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::db8:5b23:acf0:6f9a]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::db8:5b23:acf0:6f9a%4]) with mapi id 15.20.5332.023; Thu, 16 Jun 2022 18:33:25 +0000 Message-ID: <5ae33e36-d12d-9808-64d4-cabdfee73a0c@amd.com> Date: Thu, 16 Jun 2022 13:33:23 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [edk2-devel] [PATCH 07/14] OvmfPkg: Add PCD and DEFINEs for Lazy Accept page. To: Dionna Amalie Glaze , "Xu, Min M" Cc: "devel@edk2.groups.io" , Gerd Hoffmann , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" References: <20220607104550.hz6c7etgxtksylwu@sirius.home.kraxel.org> <20220608061805.vvsjiqt55rqnl3fw@sirius.home.kraxel.org> <20220615080508.oqjojsevfxc4pw3f@sirius.home.kraxel.org> From: "Lendacky, Thomas" In-Reply-To: X-ClientProxiedBy: SN4PR0201CA0072.namprd02.prod.outlook.com (2603:10b6:803:20::34) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: Thomas.Lendacky@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 92eaabb8-3898-4515-2181-08da4fc6b321 X-MS-TrafficTypeDiagnostic: CY4PR12MB1141:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9GdRUD9xB4+XReIXGpECmRCHPuvN5Bo5G+lu9zwb8G/cOcu0FA4vioMi23fulGAcGmglFvknqjSTAaL5LcNqSlMqJqGsBKqNJgj/7tZqnPLrH2EJqPqIPJfLSh3kddf2VA+8PqL6UJZ4/umd3Qytbf1KzfFdGGYqqNE6/R41tF1aOytaZGmXjWgaDgY9JL9rcHYwlJj9i4cwlkljFHnTTZ5qSp7YIAlaZUEe2tvzJu/0NKY5SfRfr2J9i8LQ1pryez5EYpwLnS/zNEAn+CjxdnGAPRuy/tppSYL8sbSHAz5CqLnzPimVpvqHydXcCR4nni3gUju7YnTO0PsW1ox082Z1EmoJJ6CKcGOti3LUeBFrsvCC264UAL2mel+jPGspLFSnXXh/QEm9v3VeW3zDaRkiBHg3hMhAL7qKWZ0Gfmf93GQfw1PSDlvkiBviqzdMdnJ7j8U+XQzRMnblqIdgTRN1gJyu9qlwKyMtNwU7+0L+f4Miz6k2WdM3PW/K98+P+1bUckb3aoq8gfvCzvSny4JwjS8Q94XRRAm0rl1SNcH1EatLdfgh0d3HnSeL9VOVIsxi5vqLBpyxq4jTZ9/0nBbvDUlre7CeFEtUOEalbftfdYQ41gPS8ezkzdGfBnLjWsZg7p4g8JQrT+3RgtnGb8YUyRVoAf9IE3VFyqssDnxqA+9a/hjqAzCyJUvUNjlpLcerB8nc7IW3Ow3nigoObrQUCqmB0Us1Fvm4+LPY0/SjZJNIqDL14izm72PIOhi5 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(6506007)(5660300002)(2906002)(508600001)(6486002)(31696002)(53546011)(26005)(186003)(66946007)(38100700002)(6512007)(36756003)(86362001)(8936002)(83380400001)(54906003)(316002)(66476007)(110136005)(8676002)(31686004)(2616005)(66556008)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWwvTk1vNUJZWGZrZWs5cG5CYS9ZWUNqdGpmQVVKemllQlprOEFTVmZac3lw?= =?utf-8?B?aC9xaUY2c3l6RnNiSjdMUDRjUkk1ZmdRTGZJeVdOdmc3ZjhJYW1BZDc2d25r?= =?utf-8?B?VGdzVTFhK0FZaXB5OWx5S2dQWE1aZlhGMHdmRldYWTNtY1dHUEJhdjhHY0ox?= =?utf-8?B?bU5tQ2JzK21qNVhFc3RaOWdXUzZ6MllrZmdTazFOM2V2aXg2aDhXSU5mTWhV?= =?utf-8?B?TVhWK1YxSW0vUnkyTDFrV3l3VFd3bnUzWW1VdTJnMEhYVWVlT0JkaDZxS0lI?= =?utf-8?B?bU9iRngwL215UENRdzYvb3JjK3AvWCtsSzNhV01kQmlWVjdBb3NPSGRQT2xv?= =?utf-8?B?dnhReTlqcW9abC8vdDQ3b21BYk1nR2xUSTdXLzRFbVpOQnpGbmVja0haRlZp?= =?utf-8?B?dm1yaGtvVFFXRE1LRTlySkZqL2YrU0xzMnNZdkp4WmROV1FrOXVKbitLcWtE?= =?utf-8?B?RFVEY2NzRWdOUnN5MXpxWEN6Y090U0lzZ0lxaXZvOVhzWW1sWThSMHJqb2Uz?= =?utf-8?B?enM4N2FzaWZtZFVVNnpqT2tVaDJxL0FWQWx5aFF4WEV4UDlieFpiUnAwTjJG?= =?utf-8?B?Q3k5d1NIWUhjWWxmVDduL0Z5cENUUmJOcEtyOWVObnJlUlRpcFl1V0I2bVYr?= =?utf-8?B?Ylgzc2xoNktRdU9BTVBjaXV3SGxZZ0JwUUVkSjZoM3FzUlB4b0ZKS2htaDlZ?= =?utf-8?B?a095YnU4L0I0bCtVcndUL0QzV1hFNk5PalFvUDFrNDFvdHhTOVh4ZUh2emkz?= =?utf-8?B?akpUQStLTXR0d2FKVDRmQ3BhZXpyVkxHUG5nZi9TQ3RCaUI4SXAzMkFpakQx?= =?utf-8?B?VHNJUDF0MEhDdDhvRURxSzJjY0doYk5CYWhOYWhyNzhJc3RhWlNjd3l1NWVD?= =?utf-8?B?WEc4b29LWXFqNGZ3NFl6M0lZTXB5MTlxN0tWa1pneFdZYTcxNnpDMHBxODh2?= =?utf-8?B?M1JXYkdYYTQxbkE4c042USsxYmhDdlc3b1kvYS8xNW9sTEpxWVN5bU9OVTVK?= =?utf-8?B?TG5pa1ZGV21RejdNdzl5T00rM1JuaktHMXVocm81aUtuNEt3anZ4SGlZbEFW?= =?utf-8?B?YXV0VHYxYzc0R3FRazI0ZGN1MmN1M2VoSkV4ZjVMeWIwRS9PVWpzaHVYQXYy?= =?utf-8?B?N2c1YU9BM1d4V2F6UU9SL21xNS9QNks3LzA4UUx0alBmbFNmTEVkd2R3ekpO?= =?utf-8?B?SGRMQVViTGNRTFp3bXN3RlZwSzBCZUo0MFVtbGxLeUg2S3lTY3d3WVdPN3pR?= =?utf-8?B?SXZ1SEw2M0hPMVlSMkczaWVDZFV1Z3VEUHp3UUhoL2JGR3RXdUZVR21URGNp?= =?utf-8?B?UWcrTENOWDhTa0VOUVZRUWl5SElDTXI0VHZmN2pEemZYMURJVDBNL1JQMVgw?= =?utf-8?B?dXpab1ZldUFlM2I3OFBlbWNvdkZEVEUzcHIvanZkNkt5QUorZENNN3AycHJh?= =?utf-8?B?SzhVMFdZTDFZSDIwVEZkb0NDQ2s3WDJhU1kwekt0NVJMV2FzOE5vSGlEbFdU?= =?utf-8?B?TWdSa1ZoMlE3emxmTy9yeUI3L1FKb2d6eU1YQW9nQ25vRjBjK1NrNXVrMGNu?= =?utf-8?B?dGRkczNHNVpmZUlRTmVkTk95anIwSXhzeWxuK1FoM3AyVVhQRjVPVmFRY1dN?= =?utf-8?B?bGtUeWdUQzV0N1d0dVo3MkgxaDhtMzB0YmJlSmIvWXRibld6eG1rd2htVXJy?= =?utf-8?B?VkJSMmVvTDVqaDZrVDN6REVXMEFYQUNjNG1ZcWVNbk9Sa3lGTFZ3dFlmaTZK?= =?utf-8?B?K3FjTlUreXlzLzIrcjFHM3BFTVpNOWRmUFpDQUR2bFlFMXdBM1pnOEcrczZk?= =?utf-8?B?NFZ2clc0QlJuSjBiUi9CcG94Z3FMT05zbFpMK1Bxd1ZTQ3JvZVJrUExXdS9J?= =?utf-8?B?OEs5c1dqMFJiTkZBL1p0RCs0RkphQU4xS1U2REZER1A4WFozcThQMkhOVXNO?= =?utf-8?B?SlYxckl6aElaRzA4cU13aDVQdlJXemNtemQ0aVkyNHFCTllGRzBjR0VxcWZr?= =?utf-8?B?TkdKc3g1bjVKY0M5cHVsOXB6VnFTZ1RGYVlXUTBJMy94cVJhRUdxVmZGOHpK?= =?utf-8?B?Sk5uZndWWnVyYkRlRm1ZM1h6TE5yU2pua2hWY0dxVmRRdFAzeHNHUXQxQnoy?= =?utf-8?B?STN5UE1VanZ0MmRmOW9hOHFSVWJBQkJWM0Z3RG5ObUFnU3ZUcURNSXB6bkdy?= =?utf-8?B?bzJ2aGFubUdKcHJnSlVUMEJWaUJqTVBlUFNpRHI5NTJ2ZDdrWUEzTGJ4VHAz?= =?utf-8?B?TUhUa0RWRWtoZUNTM2wwem41K2FZN2xQazl2eVdRMVk5ZW9xU2FkdHQxMDF6?= =?utf-8?B?Z3FzcS9EaXQ4YzMxVXhaeFdrZXhrMHk4djNOVFpDaDNCRDZZSm5Idz09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92eaabb8-3898-4515-2181-08da4fc6b321 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2022 18:33:25.6102 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ehYfZuaxAVglzwhiP59iRIIxCrr2qTR3/yeOLwfKaNvHny6gL65BCUnf1nZebh0AuLCkiXeUOP906lEqNqsdsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1141 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/16/22 11:44, Dionna Amalie Glaze wrote: >> A question: is there some performance impact when accepting all memory under 4GB? > > On SEV-SNP, we accept the HOBs 0-0xA000 and 0x10_0000-0xC00_0000, > which takes a couple seconds, which is non-negligible. Are you possibly including the memory pinning time (that happens in the hypervisor before the guest is started) in your measurement? For example, I added from RDTSCP instructions in before and after the calls to MemEncryptSevSnpPreValidateSystemRam() and got: *** DEBUG: SEC PreValidating RAM from 820000 to 1710000 *** DEBUG: TSC1=3057966080, TSC2=3070503712, delta = 12537632 *** DEBUG: PEI PreValidating RAM from 0 to A0000 *** DEBUG: TSC1=3430088800, TSC2=3432589504, delta = 2500704 *** DEBUG: PEI PreValidating RAM from 100000 to 80000000 *** DEBUG: TSC1=3436557536, TSC2=3496324336, delta = 59766800 This is for 2GB (0x80000000) of RAM. If I've done my calculations correctly for a 1600MHz TSC, that comes out to about 45 milliseconds. Thanks, Tom > For VMs that want to boot very fast and still have access to a lot of > memory in the long run (e.g., a UEFI app as an enclave or sandbox), I > admit it's not my favorite solution. > That being said, supporting unaccepted memory in the guest means that > the 4GB solution doesn't preclude an accept-on-demand solution in the > future in the case that there is demand. >