Re: [edk2-devel] [PATCH v2] OvmfPkg: Add QemuFwCfgLibNull

["Rebecca Cran" <rebecca@bsdio.com>]

On 4/30/20 10:46 AM, Laszlo Ersek wrote:
>
> Please pay more attention to review feedback. If you post a new version
> without even attempting to address review comments, that's a waste of
> time for both you and your reviewers.

It's something I really do need to work on. I need to take a step back 
and read up on effective ways of working with an email-based review 
system, because at the moment I'm a bit overwhelmed with sorting through 
the feedback, applying it (or not) etc. It's a new way of working, both 
over email and with multi-patch series.


> (d) Please get your git setup in functional order *consistently*. This
> patch only adds new files (doesn't modify existing files), so there is
> no conflict due to <CR><CR><LF> on context lines or removed lines. But
> both new files have <CR><CR><LF> after the patch is applied with git-am.

I thought the SetupGit.py script should have done that, but reading 
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers 
I see there's more I should configure.


-- 
Rebecca Cran