From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out03.mta.xmission.com (out03.mta.xmission.com [166.70.13.233]) by mx.groups.io with SMTP id smtpd.web12.115.1588279562336437726 for ; Thu, 30 Apr 2020 13:46:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@bsdio.com header.s=xmission header.b=IlgSUy2P; spf=pass (domain: bsdio.com, ip: 166.70.13.233, mailfrom: rebecca@bsdio.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=bsdio.com; s=xmission; h=Subject:Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:References:Cc:To:From:Sender:Reply-To:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=bBHJzosvd82xNNW/A5jZuRpu1t0LT9resGklIBMWwhc=; b=IlgSUy2PzXpGmC42EF4vLVn/NX OWkQaW5RqmFKrnkFXngkflRVX38jF3JPTLZwZz/OCbnmaZ7pxVIX5wYIXDM1ReyrLoJOZFZtHvyXJ xXCKIYEHAZHsbIkJQxMOkq+cZLoBddntiWmIhNhWGqKV7WX7vZ7PqOmmzSt5RJGEICGc=; Received: from in01.mta.xmission.com ([166.70.13.51]) by out03.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jUG4H-0003t9-2X; Thu, 30 Apr 2020 14:46:01 -0600 Received: from mta4.zcs.xmission.com ([166.70.13.68]) by in01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1jUG4G-0001lq-7e; Thu, 30 Apr 2020 14:46:00 -0600 Received: from localhost (localhost [127.0.0.1]) by mta4.zcs.xmission.com (Postfix) with ESMTP id 1BB10500455; Thu, 30 Apr 2020 14:46:00 -0600 (MDT) X-Amavis-Modified: Mail body modified (using disclaimer) - mta4.zcs.xmission.com Received: from mta4.zcs.xmission.com ([127.0.0.1]) by localhost (mta4.zcs.xmission.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Y4hvhtGam8Dg; Thu, 30 Apr 2020 14:46:00 -0600 (MDT) Received: from [10.0.10.120] (c-174-52-16-57.hsd1.ut.comcast.net [174.52.16.57]) by mta4.zcs.xmission.com (Postfix) with ESMTPSA id BABB0500105; Thu, 30 Apr 2020 14:45:59 -0600 (MDT) From: "Rebecca Cran" To: Laszlo Ersek , devel@edk2.groups.io Cc: Jordan Justen , Ard Biesheuvel , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20200430132202.627023-1-rebecca@bsdio.com> <279fcfc7-228f-ec56-14db-91c53c466694@redhat.com> Message-ID: <5af76add-11c9-5525-afa3-d81a1265482e@bsdio.com> Date: Thu, 30 Apr 2020 14:45:59 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <279fcfc7-228f-ec56-14db-91c53c466694@redhat.com> X-XM-SPF: eid=1jUG4G-0001lq-7e;;;mid=<5af76add-11c9-5525-afa3-d81a1265482e@bsdio.com>;;;hst=in01.mta.xmission.com;;;ip=166.70.13.68;;;frm=rebecca@bsdio.com;;;spf=pass X-SA-Exim-Connect-IP: 166.70.13.68 X-SA-Exim-Mail-From: rebecca@bsdio.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa05.xmission.com X-Spam-Level: X-Spam-Status: No, score=0.1 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG,TooManyTo_001 autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5076] * 0.3 TooManyTo_001 Multiple "To" Header Recipients 2x (uncommon) * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa05 1397; IP=ok Body=1 Fuz1=1] [Fuz2=1] X-Spam-DCC: XMission; sa05 1397; IP=ok Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Laszlo Ersek , devel@edk2.groups.io X-Spam-Relay-Country: X-Spam-Timing: total 626 ms - load_scoreonly_sql: 0.06 (0.0%), signal_user_changed: 11 (1.7%), b_tie_ro: 9 (1.5%), parse: 1.19 (0.2%), extract_message_metadata: 13 (2.0%), get_uri_detail_list: 1.18 (0.2%), tests_pri_-1000: 3.9 (0.6%), tests_pri_-950: 1.26 (0.2%), tests_pri_-900: 1.01 (0.2%), tests_pri_-90: 248 (39.6%), check_bayes: 245 (39.2%), b_tokenize: 6 (1.0%), b_tok_get_all: 6 (1.0%), b_comp_prob: 2.2 (0.4%), b_tok_touch_all: 227 (36.3%), b_finish: 1.01 (0.2%), tests_pri_0: 337 (53.8%), check_dkim_signature: 0.65 (0.1%), check_dkim_adsp: 75 (12.0%), poll_dns_idle: 73 (11.7%), tests_pri_10: 2.1 (0.3%), tests_pri_500: 6 (1.0%), rewrite_mail: 0.00 (0.0%) Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg: Add QemuFwCfgLibNull X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 4/30/20 10:46 AM, Laszlo Ersek wrote: > > Please pay more attention to review feedback. If you post a new version > without even attempting to address review comments, that's a waste of > time for both you and your reviewers. It's something I really do need to work on. I need to take a step back and read up on effective ways of working with an email-based review system, because at the moment I'm a bit overwhelmed with sorting through the feedback, applying it (or not) etc. It's a new way of working, both over email and with multi-patch series. > (d) Please get your git setup in functional order *consistently*. This > patch only adds new files (doesn't modify existing files), so there is > no conflict due to on context lines or removed lines. But > both new files have after the patch is applied with git-am. I thought the SetupGit.py script should have done that, but reading https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers I see there's more I should configure. -- Rebecca Cran