From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: devel@edk2.groups.io, prince.agyeman@intel.com
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 0/3] Fix SimicsOpenBoardPkg GCC Build
Date: Tue, 10 Sep 2019 08:47:49 +0200 [thread overview]
Message-ID: <5b348e83-e684-f470-8668-26440209630e@redhat.com> (raw)
In-Reply-To: <cover.1568070575.git.prince.agyeman@intel.com>
Hi Prince,
On 9/10/19 1:15 AM, Agyeman, Prince wrote:
> This patch series fix gcc build issues seen
> in SimicsOpenBoardPkg.
> Patches were tested on GCC 5
>
> Prince Agyeman (3):
> AdvancedFeaturePkg: Fix GCC build
> SimicsOpenBoardPkg: Fix GCC build issues
> SimicsIch10Pkg: Fix GCC build issues
It seems you forgot to describe what each patch does and why.
The EDK2 project has few recommendations:
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format
Personally I find this link very explicit:
https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages
You could paste the relevant part of the GCC error you get,
and explain why you decided to do your change:
"This variable is never read, we can safely remove it because ..."
Sometime the proper fix for a warning is not to remove the unused code,
but check why this code is not used, and fix by using it correctly.
If you can justify it is safe to remove unused code, then it is fine.
Regards,
Phil.
prev parent reply other threads:[~2019-09-10 6:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 23:15 [edk2-platforms] [PATCH 0/3] Fix SimicsOpenBoardPkg GCC Build Agyeman, Prince
2019-09-09 23:15 ` [edk2-platforms] [PATCH 1/3] AdvancedFeaturePkg: Fix GCC build Agyeman, Prince
2019-09-11 2:32 ` Nate DeSimone
2019-09-09 23:15 ` [edk2-platforms] [PATCH 2/3] SimicsOpenBoardPkg: Fix GCC build issues Agyeman, Prince
2019-09-11 2:32 ` Nate DeSimone
2019-09-09 23:15 ` [edk2-platforms] [PATCH 3/3] SimicsIch10Pkg: " Agyeman, Prince
2019-09-11 2:32 ` Nate DeSimone
2019-09-10 6:47 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b348e83-e684-f470-8668-26440209630e@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox