From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: philmd@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 09 Sep 2019 23:47:52 -0700 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 20513C05AA71 for ; Tue, 10 Sep 2019 06:47:52 +0000 (UTC) Received: by mail-wm1-f70.google.com with SMTP id c188so876121wmd.9 for ; Mon, 09 Sep 2019 23:47:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yAyEK0bTScTTMq62iGQW1Q/Z/s7zw2wVMS7bZ9fp2fw=; b=gPt4h88JTTdY//ZsXxj6Jn8zuNQ8xf8uefvSwjBT9mR4CurbH1BRy0L9oHSHitPawi CCh7qwiMcARznXRs/EUGJkRYOnO4UIJx1krCRNi1RVCWbMFdvWnF+EgzNB26AHz2zg2r zceQEFYcHX+/5mwuHqpb1v7Tlcxd6+y9aj/5p6QoXBEQ6Z2niPJ/JBoHHxuH6gD557n4 2B/uSgegpWB1Zf9g0hIRsuU90YYfBEhpr42Z+IX5rRw0snwsm11oS8QJZcsVFRALsWrY 4iV6SJVjUQUPSu1+1y56zXt3Kk7XT79on6GQP3Irga0VTGh6dy4VIm2QbvGXy9m8773r 88QA== X-Gm-Message-State: APjAAAW8Z674Eh8ksWOhfTcEniSJgEYSjxHmsf98+HqPLY+y3irJoV8U WKK2nqUnmh68jvgP6BIdzS+Ef8ydzKKytp24Y4u7i3Ey+wcmf68955lZgR5iP1wfhTT0KvCBT6V KIgoModYrfs72Iw== X-Received: by 2002:adf:dc43:: with SMTP id m3mr24238075wrj.118.1568098070911; Mon, 09 Sep 2019 23:47:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqzCi/nsD9syq87ubaxzGiyeKPVYF6LeCxhHb/4D2eBypdoddrhlVzQPHwjmrHTzOI8hC6UnLw== X-Received: by 2002:adf:dc43:: with SMTP id m3mr24238062wrj.118.1568098070745; Mon, 09 Sep 2019 23:47:50 -0700 (PDT) Received: from [192.168.1.41] (251.red-88-10-102.dynamicip.rima-tde.net. [88.10.102.251]) by smtp.gmail.com with ESMTPSA id s9sm2510417wme.36.2019.09.09.23.47.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Sep 2019 23:47:50 -0700 (PDT) Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 0/3] Fix SimicsOpenBoardPkg GCC Build To: devel@edk2.groups.io, prince.agyeman@intel.com References: From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <5b348e83-e684-f470-8668-26440209630e@redhat.com> Date: Tue, 10 Sep 2019 08:47:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Prince, On 9/10/19 1:15 AM, Agyeman, Prince wrote: > This patch series fix gcc build issues seen > in SimicsOpenBoardPkg. > Patches were tested on GCC 5 > > Prince Agyeman (3): > AdvancedFeaturePkg: Fix GCC build > SimicsOpenBoardPkg: Fix GCC build issues > SimicsIch10Pkg: Fix GCC build issues It seems you forgot to describe what each patch does and why. The EDK2 project has few recommendations: https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format Personally I find this link very explicit: https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages You could paste the relevant part of the GCC error you get, and explain why you decided to do your change: "This variable is never read, we can safely remove it because ..." Sometime the proper fix for a warning is not to remove the unused code, but check why this code is not used, and fix by using it correctly. If you can justify it is safe to remove unused code, then it is fine. Regards, Phil.