From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id B9FA47803CD for ; Tue, 16 Apr 2024 01:51:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=OxeGeVKqgaJgUXHRjE2ty3nCYSYE2e38xevwQrkBEmk=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1713232262; v=1; b=igeJZeQLaGPN+Uix9FB6iYmShwHd3SW6qef32cpMuxEm0SsB3uZ8vQhiBeJd4gIO10KXaoz/ Xp75knooXmQcCy0AN7HUGKR45fUpvFYO8Qfm5kK58HleoYSRHx7qvOkP5xCIA2PWlR42a/XY4pC U/wmvQL04qzJUYbhmvOAr++wAxJCaYHzw9EFzTt1gSX9py49POiK24Ela3Drovsv/WiGSMc81FA lP1BLNtcTwNlqgYFI/7TwZ2DfohSz5MFL6nIBJDr+gw0HoWMlQj+31RGR4YCrdqoH0I1Sm3mTTA rLTFiA0WuNxEDOvumsZmvVJyiUWVbXtZqhex/ANv42bXw== X-Received: by 127.0.0.2 with SMTP id ApeKYY7687511x1Suui5PBuS; Mon, 15 Apr 2024 18:51:02 -0700 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web10.10204.1713232260463372207 for ; Mon, 15 Apr 2024 18:51:01 -0700 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8DxmfCB2R1mvQ8oAA--.25920S3; Tue, 16 Apr 2024 09:50:57 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxKBJ92R1m5FJ8AA--.30104S3; Tue, 16 Apr 2024 09:50:53 +0800 (CST) Message-ID: <5b48d8f8-e438-4017-96b7-67d37b032ada@loongson.cn> Date: Tue, 16 Apr 2024 09:50:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v3 10/13] UefiCpuPkg: Add a new GUID to store the processors resource To: devel@edk2.groups.io, ray.ni@intel.com Cc: "Kumar, Rahul R" , Gerd Hoffmann References: <20240412073254.3486364-1-lichao@loongson.cn> <20240412073441.3488372-1-lichao@loongson.cn> From: "Chao Li" In-Reply-To: X-CM-TRANSID: AQAAf8CxKBJ92R1m5FJ8AA--.30104S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQAICGYc5WsCDwBNs1 X-Coremail-Antispam: 1Uk129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7 ZEXasCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnUUvcSsGvfC2Kfnx nUUI43ZEXa7xR_UUUUUUUUU== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 15 Apr 2024 18:51:01 -0700 Resent-From: lichao@loongson.cn Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 3oOdZqCYDYV6HD5pIHFo34A0x7686176AA= Content-Type: multipart/alternative; boundary="------------90keoAjD7H0UQwx3nC5nTg2Z" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=igeJZeQL; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io --------------90keoAjD7H0UQwx3nC5nTg2Z Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Ray, Thanks, Chao On 2024/4/15 10:10, Ni, Ray wrote: > > + > +typedef struct { > +  UINT32    NumberOfProcessor; > +  UINTN     *ApicId; > > [Ray] How about "UINTN  ApicId[]"? The difference between the two is > your version contains an 8-byte pointer pointing to somewhere else. My > version implies the APIC ID array is just after "NumberOfProcessor". Of curse, using the flexible arrays is better than my version and I will adjust this in V3. > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117816): https://edk2.groups.io/g/devel/message/117816 Mute This Topic: https://groups.io/mt/105478501/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- --------------90keoAjD7H0UQwx3nC5nTg2Z Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi Ray,


Thanks,
Chao
On 2024/4/15 10:10, Ni, Ray wrote:

+
+typedef struct {
+  UINT32    NumberOfProcessor;
+  UINTN     *ApicId;

[Ray] How about "UINTN  ApicId[]"? The difference between the two is your version contains an 8-byte pointer pointing to somewhere else. My version implies the APIC ID array is just after "NumberOfProcessor".
Of curse, using the flexible arrays is better than my version and I will adjust this in V3.
_._,_._,_
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#117816) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------90keoAjD7H0UQwx3nC5nTg2Z--