public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: rebecca@bsdio.com
To: devel@edk2.groups.io, Siyuan Fu <siyuan.fu@intel.com>,
	Jiaxin Wu <jiaxin.wu@intel.com>
Subject: NetworkPkg: sending a second HTTPS request without tearing down instance in-between causes a crash
Date: Mon, 12 Aug 2019 20:14:13 -0600	[thread overview]
Message-ID: <5b7910f4-8894-db46-1376-e1f680126a2e@bsdio.com> (raw)

I've been working to debug a problem I've been seeing booting FreeBSD
via HTTPS. I filed a BZ at
https://bugzilla.tianocore.org/show_bug.cgi?id=1917 .


I've done some more debugging and tracked the issue down to attempting to request a file twice without tearing down the http instance in-between. 

In https://svnweb.freebsd.org/base/head/stand/efi/libefi/efihttp.c?revision=349613&view=markup :

If, in function efihttp_fs_open (line 565) I call efihttp_dev_close followed by efihttp_dev_open if the first call to _efihttp_fs_open fails, then everything works. 
But if I don't then I get the crash due to the corruption of the SetSessionDataPointer.


-- 
Rebecca Cran


                 reply	other threads:[~2019-08-13  2:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b7910f4-8894-db46-1376-e1f680126a2e@bsdio.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox