From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 04 Apr 2019 05:52:57 -0700 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C2B723006023; Thu, 4 Apr 2019 12:52:56 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-104.rdu2.redhat.com [10.10.120.104]) by smtp.corp.redhat.com (Postfix) with ESMTP id 804CB85743; Thu, 4 Apr 2019 12:52:51 +0000 (UTC) Subject: Re: [edk2-devel] [Patch 3/4] ArmVirtPkg: Normalize line endings to CRLF To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Ard Biesheuvel References: <20190403220014.14468-1-michael.d.kinney@intel.com> <20190403220014.14468-4-michael.d.kinney@intel.com> From: "Laszlo Ersek" Message-ID: <5b806211-ee0a-9ed3-44a4-d228925c1976@redhat.com> Date: Thu, 4 Apr 2019 14:52:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190403220014.14468-4-michael.d.kinney@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Thu, 04 Apr 2019 12:52:56 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/04/19 00:00, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=1659 > > Normalize line endings to use CRLF to pass PatchCheck.py > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Michael D Kinney > --- > ArmVirtPkg/Include/Platform/Hidden.h | 56 ++++++++++++++-------------- > 1 file changed, 28 insertions(+), 28 deletions(-) > > diff --git a/ArmVirtPkg/Include/Platform/Hidden.h b/ArmVirtPkg/Include/Platform/Hidden.h > index fbd3467471..997866ff50 100644 > --- a/ArmVirtPkg/Include/Platform/Hidden.h > +++ b/ArmVirtPkg/Include/Platform/Hidden.h > @@ -1,28 +1,28 @@ > -/** @file > - > - Copyright (c) 2018, Linaro Limited. All rights reserved. > - > - This program and the accompanying materials > - are licensed and made available under the terms and conditions of the BSD License > - which accompanies this distribution. The full text of the license may be found at > - http://opensource.org/licenses/bsd-license.php > - > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > - > -**/ > - > -#ifndef __PLATFORM_HIDDEN_H > -#define __PLATFORM_HIDDEN_H > - > -// > -// Setting the GCC -fvisibility=hidden command line option is not quite the same > -// as setting the pragma below: the former only affects definitions, whereas the > -// pragma affects extern declarations as well. So if we want to ensure that no > -// GOT indirected symbol references are emitted, we need to use the pragma, or > -// GOT based cross object references could be emitted, e.g., in libraries, and > -// these cannot be relaxed to ordinary symbol references at link time. > -// > -#pragma GCC visibility push (hidden) > - > -#endif > +/** @file > + > + Copyright (c) 2018, Linaro Limited. All rights reserved. > + > + This program and the accompanying materials > + are licensed and made available under the terms and conditions of the BSD License > + which accompanies this distribution. The full text of the license may be found at > + http://opensource.org/licenses/bsd-license.php > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > + > +**/ > + > +#ifndef __PLATFORM_HIDDEN_H > +#define __PLATFORM_HIDDEN_H > + > +// > +// Setting the GCC -fvisibility=hidden command line option is not quite the same > +// as setting the pragma below: the former only affects definitions, whereas the > +// pragma affects extern declarations as well. So if we want to ensure that no > +// GOT indirected symbol references are emitted, we need to use the pragma, or > +// GOT based cross object references could be emitted, e.g., in libraries, and > +// these cannot be relaxed to ordinary symbol references at link time. > +// > +#pragma GCC visibility push (hidden) > + > +#endif > This will conflict with the license conversion, so I suggest redoing this patch after the conversion is pushed. Other than that, Acked-by: Laszlo Ersek Thanks Laszlo