From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A4142D802AD for ; Mon, 18 Sep 2023 22:36:56 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+EyrUq2yqVBSxRRtjHeLufneEqPTO1NB04wk34ngXD8=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695076615; v=1; b=ka7CCzcYxeC9sN0PU2Dm1TEllUQD+mIkCEznpyAnDKcLx40LWsyOm8WEP7JdOUZPMmfTI6u1 5dC5tuU0AoGTaLlEK6/aUD/uYbwLP1dQqjIBoXWMYs/s1VPt/cC4cPGkBP+/NYf+XbaoQRMOYVU SUEURL7u8jzBNQA90uOOQG94= X-Received: by 127.0.0.2 with SMTP id 5f7MYY7687511xQ6GAeVf6zt; Mon, 18 Sep 2023 15:36:55 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.5264.1695076614717510423 for ; Mon, 18 Sep 2023 15:36:54 -0700 X-Received: from [192.168.4.22] (unknown [47.201.241.95]) by linux.microsoft.com (Postfix) with ESMTPSA id ABAC6212C484; Mon, 18 Sep 2023 15:36:53 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com ABAC6212C484 Message-ID: <5b83a08a-f43a-a63d-6974-3258f1f8704c@linux.microsoft.com> Date: Mon, 18 Sep 2023 18:36:52 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 5/7] DynamicTablesPkg.ci.yaml: Add debug macro exception To: devel@edk2.groups.io, Pierre Gondois , Yeo Reum Yun , nd Cc: sami.mujawar@arm.com References: <20230913170617.429-1-mikuback@linux.microsoft.com> <20230913170617.429-6-mikuback@linux.microsoft.com> <1784B757CEFF413A.31544@groups.io> <03608312-A1C2-467C-BBF4-0385FBD8E999@arm.com> From: "Michael Kubacki" In-Reply-To: <03608312-A1C2-467C-BBF4-0385FBD8E999@arm.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: xmtjF8dgWVdrMJioOGVUXw1lx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ka7CCzcY; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none) Thanks Sami. I still need a Reviewed-by on this patch to complete the=20 series. On 9/14/2023 5:22 AM, Sami Mujawar wrote: > Hi Michael, >=20 > Apologies, I initially misunderstood what this patch was trying to do. > As I understand this is an exception for one of the special cases to be h= andled differently by the plugin. >=20 > Acked-by: Sami Mujawar >=20 > Regards, >=20 > Sami Mujawar >=20 > =EF=BB=BFOn 14/09/2023, 09:42, "devel@edk2.groups.io on behalf of Sami Mujawar via groups.io" on behalf of sami.mujawar=3Darm.com@groups.io <= mailto:arm.com@groups.io>> wrote: >=20 >=20 > Hi Michael, >=20 >=20 > I would prefer to have the debug macro checks enabled in DynamicTablesPkg= to catch any issues. >=20 >=20 > Please do not disable this feature for this package. >=20 >=20 > Regards, >=20 >=20 > Sami Mujawar >=20 >=20 > On 13/09/2023, 18:08, "mikuback@linux.microsoft.com >" >> wrote: >=20 >=20 >=20 >=20 > From: Michael Kubacki >> >=20 >=20 >=20 >=20 > Adds a CI YAML entry to acknowledge a case where custom strings > contain print specifiers for a single debug macro. >=20 >=20 >=20 >=20 > Cc: Sami Mujawar >> > Cc: Alexei Fedorov >> > Cc: Pierre Gondois >> > Signed-off-by: Michael Kubacki >> > --- > DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 >=20 >=20 >=20 > diff --git a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml b/DynamicTablesPkg= /DynamicTablesPkg.ci.yaml > index 5addf8626841..1d41d44bbf33 100644 > --- a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml > +++ b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml > @@ -130,5 +130,13 @@ > # should be ignore > "AdditionalIncludePaths": [] # Additional paths to spell check > # (wildcards supported) > + }, > + > + "DebugMacroCheck": { > + "StringSubstitutions": { > + # DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerOb= jectParser.c > + # Reason: Debug format strings are dynamically set. > + "Parser[Index].Format": "%d" > + } > } > } -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108810): https://edk2.groups.io/g/devel/message/108810 Mute This Topic: https://groups.io/mt/101341656/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-