From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 13 Jun 2019 07:09:22 -0700 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 90EE6C18B2E1; Thu, 13 Jun 2019 14:09:08 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-127.ams2.redhat.com [10.36.117.127]) by smtp.corp.redhat.com (Postfix) with ESMTP id E49255ED4A; Thu, 13 Jun 2019 14:09:06 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 05/10] OvmfPkg/OvmfPkg.dec: Add PCD definitions used by copied CSM modules To: devel@edk2.groups.io, hao.a.wu@intel.com Cc: David Woodhouse , Ray Ni , Jordan Justen , Ard Biesheuvel References: <20190527030350.11996-1-hao.a.wu@intel.com> <20190527030350.11996-6-hao.a.wu@intel.com> From: "Laszlo Ersek" Message-ID: <5b9d7370-1ca6-2c0a-9896-1e50e69c9b51@redhat.com> Date: Thu, 13 Jun 2019 16:09:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190527030350.11996-6-hao.a.wu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 13 Jun 2019 14:09:08 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/27/19 05:03, Wu, Hao A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811 > > This commit will add the PCD definitions consumed by the duplicated > drivers: > > * VideoDxe > * LegacyBiosDxe > > into the OvmfPkg DEC file. > > Please note that, instead of adding these PCDs under section: > [PcdsFixedAtBuild, PcdsDynamic, PcdsDynamicEx, PcdsPatchableInModule] > > as in IntelFrameworkModulePkg.dec file, they are added in section: > [PcdsFixedAtBuild] > > in OvmfPkg.dec instead. > > Cc: David Woodhouse > Cc: Ray Ni > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Hao A Wu > --- > OvmfPkg/OvmfPkg.dec | 58 ++++++++++++++++++++ > 1 file changed, 58 insertions(+) > > diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec > index 2251f4ca99..9640360f62 100644 > --- a/OvmfPkg/OvmfPkg.dec > +++ b/OvmfPkg/OvmfPkg.dec > @@ -160,6 +160,64 @@ [PcdsFixedAtBuild] > # For the corresponding bits, 0 = Edge triggered and 1 = Level triggered. > gUefiOvmfPkgTokenSpaceGuid.Pcd8259LegacyModeEdgeLevel|0x0000|UINT16|0x5 > > + ## Indicates if BiosVideo driver will switch to 80x25 Text VGA Mode when > + # exiting boot service. > + # TRUE - Switch to Text VGA Mode. > + # FALSE - Does not switch to Text VGA Mode. > + gUefiOvmfPkgTokenSpaceGuid.PcdBiosVideoSetTextVgaModeEnable|FALSE|BOOLEAN|0x28 > + > + ## Indicates if BiosVideo driver will check for VESA BIOS Extension service > + # support. > + # TRUE - Check for VESA BIOS Extension service. > + # FALSE - Does not check for VESA BIOS Extension service. > + gUefiOvmfPkgTokenSpaceGuid.PcdBiosVideoCheckVbeEnable|TRUE|BOOLEAN|0x29 > + > + ## Indicates if BiosVideo driver will check for VGA service support. > + # NOTE: If both PcdBiosVideoCheckVbeEnable and PcdBiosVideoCheckVgaEnable > + # are set to FALSE, that means Graphics Output protocol will not be > + # installed, the VGA miniport protocol will be installed instead. > + # TRUE - Check for VGA service.
> + # FALSE - Does not check for VGA service.
> + gUefiOvmfPkgTokenSpaceGuid.PcdBiosVideoCheckVgaEnable|TRUE|BOOLEAN|0x2a > + > + ## Indicates if memory space for legacy region will be set as cacheable. > + # TRUE - Set cachebility for legacy region. > + # FALSE - Does not set cachebility for legacy region. > + gUefiOvmfPkgTokenSpaceGuid.PcdLegacyBiosCacheLegacyRegion|TRUE|BOOLEAN|0x2b > + > + ## Specify memory size with bytes to reserve EBDA below 640K for OPROM. > + # The value should be a multiple of 4KB. > + gUefiOvmfPkgTokenSpaceGuid.PcdEbdaReservedMemorySize|0x8000|UINT32|0x2c > + > + ## Specify memory base address for OPROM to find free memory. > + # Some OPROMs do not use EBDA or PMM to allocate memory for its usage, > + # instead they find the memory filled with zero from 0x20000. > + # The value should be a multiple of 4KB. > + # The range should be below the EBDA reserved range from > + # (CONVENTIONAL_MEMORY_TOP - Reserved EBDA Memory Size) to > + # CONVENTIONAL_MEMORY_TOP. > + gUefiOvmfPkgTokenSpaceGuid.PcdOpromReservedMemoryBase|0x60000|UINT32|0x2d > + > + ## Specify memory size with bytes for OPROM to find free memory. > + # The value should be a multiple of 4KB. And the range should be below the > + # EBDA reserved range from > + # (CONVENTIONAL_MEMORY_TOP - Reserved EBDA Memory Size) to > + # CONVENTIONAL_MEMORY_TOP. > + gUefiOvmfPkgTokenSpaceGuid.PcdOpromReservedMemorySize|0x28000|UINT32|0x2e > + > + ## Specify the end of address below 1MB for the OPROM. > + # The last shadowed OpROM should not exceed this address. > + gUefiOvmfPkgTokenSpaceGuid.PcdEndOpromShadowAddress|0xdffff|UINT32|0x2f > + > + ## Specify the low PMM (Post Memory Manager) size with bytes below 1MB. > + # The value should be a multiple of 4KB. > + # @Prompt Low PMM (Post Memory Manager) Size > + gUefiOvmfPkgTokenSpaceGuid.PcdLowPmmMemorySize|0x10000|UINT32|0x30 > + > + ## Specify the high PMM (Post Memory Manager) size with bytes above 1MB. > + # The value should be a multiple of 4KB. > + gUefiOvmfPkgTokenSpaceGuid.PcdHighPmmMemorySize|0x400000|UINT32|0x31 > + > [PcdsDynamic, PcdsDynamicEx] > gUefiOvmfPkgTokenSpaceGuid.PcdEmuVariableEvent|0|UINT64|2 > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashVariablesEnable|FALSE|BOOLEAN|0x10 > Reviewed-by: Laszlo Ersek