Re: [edk2-devel] [PATCH v3 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

["Tinh Nguyen" <tinhnguyen@os.amperecomputing.com>]

[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]

On 2/15/2023 10:13 PM, Rebecca Cran via groups.io wrote:

+[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
+  ## Support rate limiting
+  gUsbNetworkPkgTokenSpaceGuid.EnableRateLimiting|FALSE|BOOLEAN|0x00010001
+
+  ## The rate limiting Credit value is check in rate limiter event.
+  #  It is to control the RateLimitingCreditCount max value.
+  gUsbNetworkPkgTokenSpaceGuid.RateLimitingCredit|10|UINT32|0x00010002
+
Is that valid to have all those PCD types in a single section?


I found this style in MdeModulePkg, and thanks to this Platform code may specify this PCD as the type they want to use

https://github.com/tianocore/edk2/blob/5c551d6d912967ada3084033acea8acf37256043/MdeModulePkg/MdeModulePkg.dec#L1637

But I have no idea whether that is valid or not.

oop it reminds me of my issue.

Recently you add ArmPlatformPkg/PrePeiCore: Print the firmware version early in boot · tianocore/edk2@56035d1 (github.com)<https://github.com/tianocore/edk2/commit/56035d1c8b255b33b34cd4625c26bc7d38504e30>

this causes a problem when using gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString as a dynamic PCD (PrePei doesn't support pcdlib);

e.g., we need to add information to PcdFirmwareVersionString (that can come from arm-tf or optionRom ...).

Thanks,

Tinh

[-- Attachment #2: Type: text/html, Size: 1947 bytes --]