From: "Ni, Ruiyu" <ruiyu.ni@Intel.com>
To: Laszlo Ersek <lersek@redhat.com>, edk2-devel@lists.01.org
Cc: Star Zeng <star.zeng@intel.com>
Subject: Re: [PATCH 3/3] MdeModulePkg/PciHostBridge: Add RESOURCE_VALID() to simplify code
Date: Tue, 25 Sep 2018 10:25:15 +0800 [thread overview]
Message-ID: <5be31a57-3cee-9c13-29d2-97803b01f384@Intel.com> (raw)
In-Reply-To: <12daedaa-952f-fc73-3ed5-62970f869ba9@redhat.com>
On 9/21/2018 7:12 PM, Laszlo Ersek wrote:
> On 09/21/18 09:25, Ruiyu Ni wrote:
>
> Two superficial comments:
>
> - edk2 prefers long parameter names, so I suggest replacing "R" in the
> macro definition with "Resource"
>
> - taking the parameter as a pointer is frequently considered more flexible.
>
> #define RESOURCE_VALID(Resource) ((Resource)->Base <= (Resource)->Limit)
> ...
> if (RESOURCE_VALID (&Bridge->Mem)) {
> ...
>
> Up to you -- if you like these, feel free to update the patch before
> pushing it (from my side anyway; you do need MdeModulePkg maintainer
> review as well).
Good comments. I will update the patch then commit.
>
> With or without changes:
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
> Thanks
> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
--
Thanks,
Ray
next prev parent reply other threads:[~2018-09-25 2:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 7:25 [PATCH 0/3] Fix a bug that prevents PMEM access Ruiyu Ni
2018-09-21 7:25 ` [PATCH 1/3] MdeModulePkg/PciHostBridge: Enhance boundary check in Io/Mem.Read/Write Ruiyu Ni
2018-09-21 10:53 ` Laszlo Ersek
2018-09-24 13:18 ` Kirkendall, Garrett
2018-09-25 2:14 ` Zeng, Star
2018-09-25 2:43 ` Ni, Ruiyu
2018-09-25 3:02 ` Zeng, Star
2018-09-21 7:25 ` [PATCH 2/3] MdeModulePkg/PciHostBridge: Fix a bug that prevents PMEM access Ruiyu Ni
2018-09-21 11:06 ` Laszlo Ersek
2018-09-25 2:11 ` Ni, Ruiyu
2018-09-24 13:19 ` Kirkendall, Garrett
2018-09-25 2:15 ` Zeng, Star
2018-09-21 7:25 ` [PATCH 3/3] MdeModulePkg/PciHostBridge: Add RESOURCE_VALID() to simplify code Ruiyu Ni
2018-09-21 11:12 ` Laszlo Ersek
2018-09-25 2:25 ` Ni, Ruiyu [this message]
2018-09-25 2:35 ` Zeng, Star
2018-09-25 2:47 ` Ni, Ruiyu
2018-09-25 3:13 ` Zeng, Star
2018-09-25 5:03 ` Ni, Ruiyu
2018-09-24 13:20 ` Kirkendall, Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5be31a57-3cee-9c13-29d2-97803b01f384@Intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox