* [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib
[not found] <cover.1541013629.git.jaben.carsey@intel.com>
@ 2018-10-31 19:21 ` Jaben Carsey
2018-11-01 1:37 ` Zeng, Star
0 siblings, 1 reply; 6+ messages in thread
From: Jaben Carsey @ 2018-10-31 19:21 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Jian J Wang
The comments are incorrect for the base version of this lib.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
---
MdeModulePkg/Library/BaseSortLib/BaseSortLib.c | 22 ++++++++------------
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c
index ab8a60585ee2..8f30c00971eb 100644
--- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c
+++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c
@@ -1,7 +1,7 @@
/** @file
Library used for sorting routines.
- Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved. <BR>
+ Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved. <BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@@ -193,14 +193,12 @@ DevicePathCompare (
}
/**
- Function to compare 2 strings without regard to case of the characters.
+ Not supported in Base version.
- @param[in] Buffer1 Pointer to String to compare.
- @param[in] Buffer2 Pointer to second String to compare.
+ @param[in] Buffer1 Ignored.
+ @param[in] Buffer2 Ignored.
- @retval 0 Buffer1 equal to Buffer2.
- @return < 0 Buffer1 is less than Buffer2.
- @return > 0 Buffer1 is greater than Buffer2.
+ ASSERT and return 0.
**/
INTN
EFIAPI
@@ -215,14 +213,12 @@ StringNoCaseCompare (
/**
- Function to compare 2 strings.
+ Not supported in Base version.
- @param[in] Buffer1 Pointer to String to compare (CHAR16**).
- @param[in] Buffer2 Pointer to second String to compare (CHAR16**).
+ @param[in] Buffer1 Ignored.
+ @param[in] Buffer2 Ignored.
- @retval 0 Buffer1 equal to Buffer2.
- @return < 0 Buffer1 is less than Buffer2.
- @return > 0 Buffer1 is greater than Buffer2.
+ ASSERT and return 0.
**/
INTN
EFIAPI
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib
2018-10-31 19:21 ` [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib Jaben Carsey
@ 2018-11-01 1:37 ` Zeng, Star
0 siblings, 0 replies; 6+ messages in thread
From: Zeng, Star @ 2018-11-01 1:37 UTC (permalink / raw)
To: Carsey, Jaben, edk2-devel@lists.01.org; +Cc: Wang, Jian J, Zeng, Star
Reviewed-by: Star Zeng <star.zeng@intel.com>
-----Original Message-----
From: Carsey, Jaben
Sent: Thursday, November 1, 2018 3:21 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>; Wang, Jian J <jian.j.wang@intel.com>
Subject: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib
The comments are incorrect for the base version of this lib.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
---
MdeModulePkg/Library/BaseSortLib/BaseSortLib.c | 22 ++++++++------------
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c
index ab8a60585ee2..8f30c00971eb 100644
--- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c
+++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c
@@ -1,7 +1,7 @@
/** @file
Library used for sorting routines.
- Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved. <BR>
+ Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
+ <BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at @@ -193,14 +193,12 @@ DevicePathCompare ( }
/**
- Function to compare 2 strings without regard to case of the characters.
+ Not supported in Base version.
- @param[in] Buffer1 Pointer to String to compare.
- @param[in] Buffer2 Pointer to second String to compare.
+ @param[in] Buffer1 Ignored.
+ @param[in] Buffer2 Ignored.
- @retval 0 Buffer1 equal to Buffer2.
- @return < 0 Buffer1 is less than Buffer2.
- @return > 0 Buffer1 is greater than Buffer2.
+ ASSERT and return 0.
**/
INTN
EFIAPI
@@ -215,14 +213,12 @@ StringNoCaseCompare (
/**
- Function to compare 2 strings.
+ Not supported in Base version.
- @param[in] Buffer1 Pointer to String to compare (CHAR16**).
- @param[in] Buffer2 Pointer to second String to compare (CHAR16**).
+ @param[in] Buffer1 Ignored.
+ @param[in] Buffer2 Ignored.
- @retval 0 Buffer1 equal to Buffer2.
- @return < 0 Buffer1 is less than Buffer2.
- @return > 0 Buffer1 is greater than Buffer2.
+ ASSERT and return 0.
**/
INTN
EFIAPI
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib
[not found] <cover.1546984652.git.jaben.carsey@intel.com>
@ 2019-01-08 21:58 ` Jaben Carsey
2019-01-09 0:50 ` Wang, Jian J
2019-01-09 1:18 ` Zeng, Star
0 siblings, 2 replies; 6+ messages in thread
From: Jaben Carsey @ 2019-01-08 21:58 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Jian J Wang
The comments are incorrect for the base version of this lib.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
---
MdeModulePkg/Library/BaseSortLib/BaseSortLib.c | 22 ++++++++------------
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c
index ab8a60585ee2..8f30c00971eb 100644
--- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c
+++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c
@@ -1,7 +1,7 @@
/** @file
Library used for sorting routines.
- Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved. <BR>
+ Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved. <BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@@ -193,14 +193,12 @@ DevicePathCompare (
}
/**
- Function to compare 2 strings without regard to case of the characters.
+ Not supported in Base version.
- @param[in] Buffer1 Pointer to String to compare.
- @param[in] Buffer2 Pointer to second String to compare.
+ @param[in] Buffer1 Ignored.
+ @param[in] Buffer2 Ignored.
- @retval 0 Buffer1 equal to Buffer2.
- @return < 0 Buffer1 is less than Buffer2.
- @return > 0 Buffer1 is greater than Buffer2.
+ ASSERT and return 0.
**/
INTN
EFIAPI
@@ -215,14 +213,12 @@ StringNoCaseCompare (
/**
- Function to compare 2 strings.
+ Not supported in Base version.
- @param[in] Buffer1 Pointer to String to compare (CHAR16**).
- @param[in] Buffer2 Pointer to second String to compare (CHAR16**).
+ @param[in] Buffer1 Ignored.
+ @param[in] Buffer2 Ignored.
- @retval 0 Buffer1 equal to Buffer2.
- @return < 0 Buffer1 is less than Buffer2.
- @return > 0 Buffer1 is greater than Buffer2.
+ ASSERT and return 0.
**/
INTN
EFIAPI
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib
2019-01-08 21:58 ` Jaben Carsey
@ 2019-01-09 0:50 ` Wang, Jian J
2019-01-09 1:18 ` Zeng, Star
1 sibling, 0 replies; 6+ messages in thread
From: Wang, Jian J @ 2019-01-09 0:50 UTC (permalink / raw)
To: Carsey, Jaben, edk2-devel@lists.01.org; +Cc: Zeng, Star
Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
> -----Original Message-----
> From: Carsey, Jaben
> Sent: Wednesday, January 09, 2019 5:58 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Wang, Jian J <jian.j.wang@intel.com>
> Subject: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib
>
> The comments are incorrect for the base version of this lib.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> ---
> MdeModulePkg/Library/BaseSortLib/BaseSortLib.c | 22 ++++++++------------
> 1 file changed, 9 insertions(+), 13 deletions(-)
>
> diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c
> b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c
> index ab8a60585ee2..8f30c00971eb 100644
> --- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c
> +++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c
> @@ -1,7 +1,7 @@
> /** @file
> Library used for sorting routines.
>
> - Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved. <BR>
> + Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved. <BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD
> License
> which accompanies this distribution. The full text of the license may be found
> at
> @@ -193,14 +193,12 @@ DevicePathCompare (
> }
>
> /**
> - Function to compare 2 strings without regard to case of the characters.
> + Not supported in Base version.
>
> - @param[in] Buffer1 Pointer to String to compare.
> - @param[in] Buffer2 Pointer to second String to compare.
> + @param[in] Buffer1 Ignored.
> + @param[in] Buffer2 Ignored.
>
> - @retval 0 Buffer1 equal to Buffer2.
> - @return < 0 Buffer1 is less than Buffer2.
> - @return > 0 Buffer1 is greater than Buffer2.
> + ASSERT and return 0.
> **/
> INTN
> EFIAPI
> @@ -215,14 +213,12 @@ StringNoCaseCompare (
>
>
> /**
> - Function to compare 2 strings.
> + Not supported in Base version.
>
> - @param[in] Buffer1 Pointer to String to compare (CHAR16**).
> - @param[in] Buffer2 Pointer to second String to compare (CHAR16**).
> + @param[in] Buffer1 Ignored.
> + @param[in] Buffer2 Ignored.
>
> - @retval 0 Buffer1 equal to Buffer2.
> - @return < 0 Buffer1 is less than Buffer2.
> - @return > 0 Buffer1 is greater than Buffer2.
> + ASSERT and return 0.
> **/
> INTN
> EFIAPI
> --
> 2.16.2.windows.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib
2019-01-08 21:58 ` Jaben Carsey
2019-01-09 0:50 ` Wang, Jian J
@ 2019-01-09 1:18 ` Zeng, Star
2019-01-09 18:29 ` Carsey, Jaben
1 sibling, 1 reply; 6+ messages in thread
From: Zeng, Star @ 2019-01-09 1:18 UTC (permalink / raw)
To: Carsey, Jaben, edk2-devel@lists.01.org; +Cc: Wang, Jian J, Zeng, Star
How about updating "2018" to "2019"? :)
With that, Reviewed-by: Star Zeng <star.zeng@intel.com>.
Thanks,
Star
-----Original Message-----
From: Carsey, Jaben
Sent: Wednesday, January 9, 2019 5:58 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>; Wang, Jian J <jian.j.wang@intel.com>
Subject: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib
The comments are incorrect for the base version of this lib.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
---
MdeModulePkg/Library/BaseSortLib/BaseSortLib.c | 22 ++++++++------------
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c
index ab8a60585ee2..8f30c00971eb 100644
--- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c
+++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c
@@ -1,7 +1,7 @@
/** @file
Library used for sorting routines.
- Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved. <BR>
+ Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
+ <BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at @@ -193,14 +193,12 @@ DevicePathCompare ( }
/**
- Function to compare 2 strings without regard to case of the characters.
+ Not supported in Base version.
- @param[in] Buffer1 Pointer to String to compare.
- @param[in] Buffer2 Pointer to second String to compare.
+ @param[in] Buffer1 Ignored.
+ @param[in] Buffer2 Ignored.
- @retval 0 Buffer1 equal to Buffer2.
- @return < 0 Buffer1 is less than Buffer2.
- @return > 0 Buffer1 is greater than Buffer2.
+ ASSERT and return 0.
**/
INTN
EFIAPI
@@ -215,14 +213,12 @@ StringNoCaseCompare (
/**
- Function to compare 2 strings.
+ Not supported in Base version.
- @param[in] Buffer1 Pointer to String to compare (CHAR16**).
- @param[in] Buffer2 Pointer to second String to compare (CHAR16**).
+ @param[in] Buffer1 Ignored.
+ @param[in] Buffer2 Ignored.
- @retval 0 Buffer1 equal to Buffer2.
- @return < 0 Buffer1 is less than Buffer2.
- @return > 0 Buffer1 is greater than Buffer2.
+ ASSERT and return 0.
**/
INTN
EFIAPI
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib
2019-01-09 1:18 ` Zeng, Star
@ 2019-01-09 18:29 ` Carsey, Jaben
0 siblings, 0 replies; 6+ messages in thread
From: Carsey, Jaben @ 2019-01-09 18:29 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org
I did the work last year so I didn't do anything but the email this year...
> -----Original Message-----
> From: Zeng, Star
> Sent: Tuesday, January 08, 2019 5:18 PM
> To: Carsey, Jaben <jaben.carsey@intel.com>; edk2-devel@lists.01.org
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: RE: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib
> Importance: High
>
> How about updating "2018" to "2019"? :)
>
>
> With that, Reviewed-by: Star Zeng <star.zeng@intel.com>.
>
> Thanks,
> Star
> -----Original Message-----
> From: Carsey, Jaben
> Sent: Wednesday, January 9, 2019 5:58 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Wang, Jian J <jian.j.wang@intel.com>
> Subject: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib
>
> The comments are incorrect for the base version of this lib.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> ---
> MdeModulePkg/Library/BaseSortLib/BaseSortLib.c | 22 ++++++++------------
> 1 file changed, 9 insertions(+), 13 deletions(-)
>
> diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c
> b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c
> index ab8a60585ee2..8f30c00971eb 100644
> --- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c
> +++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c
> @@ -1,7 +1,7 @@
> /** @file
> Library used for sorting routines.
>
> - Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved. <BR>
> + Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
> + <BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD
> License
> which accompanies this distribution. The full text of the license may be
> found at @@ -193,14 +193,12 @@ DevicePathCompare ( }
>
> /**
> - Function to compare 2 strings without regard to case of the characters.
> + Not supported in Base version.
>
> - @param[in] Buffer1 Pointer to String to compare.
> - @param[in] Buffer2 Pointer to second String to compare.
> + @param[in] Buffer1 Ignored.
> + @param[in] Buffer2 Ignored.
>
> - @retval 0 Buffer1 equal to Buffer2.
> - @return < 0 Buffer1 is less than Buffer2.
> - @return > 0 Buffer1 is greater than Buffer2.
> + ASSERT and return 0.
> **/
> INTN
> EFIAPI
> @@ -215,14 +213,12 @@ StringNoCaseCompare (
>
>
> /**
> - Function to compare 2 strings.
> + Not supported in Base version.
>
> - @param[in] Buffer1 Pointer to String to compare (CHAR16**).
> - @param[in] Buffer2 Pointer to second String to compare (CHAR16**).
> + @param[in] Buffer1 Ignored.
> + @param[in] Buffer2 Ignored.
>
> - @retval 0 Buffer1 equal to Buffer2.
> - @return < 0 Buffer1 is less than Buffer2.
> - @return > 0 Buffer1 is greater than Buffer2.
> + ASSERT and return 0.
> **/
> INTN
> EFIAPI
> --
> 2.16.2.windows.1
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-09 18:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1541013629.git.jaben.carsey@intel.com>
2018-10-31 19:21 ` [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib Jaben Carsey
2018-11-01 1:37 ` Zeng, Star
[not found] <cover.1546984652.git.jaben.carsey@intel.com>
2019-01-08 21:58 ` Jaben Carsey
2019-01-09 0:50 ` Wang, Jian J
2019-01-09 1:18 ` Zeng, Star
2019-01-09 18:29 ` Carsey, Jaben
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox