From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6CB70AC0BBC for ; Thu, 25 Apr 2024 07:41:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Tid8UE5aEyofE4dqIfntPvePrfUUFpdY/UZfRlU0LV0=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1714030869; v=1; b=BXcW0NqOR9Hx6GSDtrzXSZjGR5jPxfEPFZx6+ddMaZsSdxVfj7vG/gQmMWPvfSg+j2yGFUAz puoa0lqwkIeqtaN1w9fyMuPG+Ox5sK1IIw4RtMZduHsvt1XQnrSYAIkv5cvYaX+zY6zbXi07/Zz ygnfWb66zkxAqUklLBTcjgfucPF/D9MOVTAQpfLF3VaJg0ROMSrYL0eAlm0BW4JVVO64cqPmmsC NaR6e3hKkmYisV1zxARfi7kU+NLTc2PPiEts02EXTx20757dRMcV9s5fyG9uW9qHNcRRqS4CZUa 1wBQbv9zvqRkZpYHYiDqneFEBgZ/TRPxE9CYc0oxNEpRQ== X-Received: by 127.0.0.2 with SMTP id pRw9YY7687511xeL8r3zVCWR; Thu, 25 Apr 2024 00:41:09 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.11535.1714030864182147502 for ; Thu, 25 Apr 2024 00:41:04 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-145-tP2Mopb7NaeozCB2WpyZxQ-1; Thu, 25 Apr 2024 03:40:57 -0400 X-MC-Unique: tP2Mopb7NaeozCB2WpyZxQ-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 03F978002EA; Thu, 25 Apr 2024 07:40:57 +0000 (UTC) X-Received: from dobby.home.kraxel.org (unknown [10.39.192.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 53A1C1121313; Thu, 25 Apr 2024 07:40:56 +0000 (UTC) X-Received: by dobby.home.kraxel.org (Postfix, from userid 1000) id 261AAF6B90; Thu, 25 Apr 2024 09:40:53 +0200 (CEST) Date: Thu, 25 Apr 2024 09:40:53 +0200 From: "Gerd Hoffmann" To: Chao Li Cc: devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Leif Lindholm , Sami Mujawar , Sunil V L , Andrei Warkentin Subject: Re: [edk2-devel] [PATCH v2 2/7] OvmfPkg: Add the way of HOBs in QemuFwCfgLibMmio Message-ID: <5boqyu5erbhftofbobyknwg4i4ngbm4igybx554whbtqnn4hh6@3zl5bgcskxkj> References: <20240425041728.1385891-1-lichao@loongson.cn> <20240425041816.1386268-1-lichao@loongson.cn> MIME-Version: 1.0 In-Reply-To: <20240425041816.1386268-1-lichao@loongson.cn> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 25 Apr 2024 00:41:04 -0700 Resent-From: kraxel@redhat.com Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Lhpcr8Ui7zvNPS5sBzxa3Aa0x7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=BXcW0NqO; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, > +EFI_GUID mFwCfgSelectorAddressGuid = FW_CONFIG_SELECTOR_ADDRESS_HOB_GUID; > +EFI_GUID mFwCfgDataAddressGuid = FW_CONFIG_DATA_ADDRESS_HOB_GUID; > +EFI_GUID mFwCfgDmaAddressGuid = FW_CONFIG_DMA_ADDRESS_HOB_GUID; Oh. I assumed that would be obvious (because it's common practice for HOBs), but I was thinking about a single HOB containing a struct with all three values instead of a separate HOB for each value. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118275): https://edk2.groups.io/g/devel/message/118275 Mute This Topic: https://groups.io/mt/105724969/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-