From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web08.4163.1622104222640944211 for ; Thu, 27 May 2021 01:30:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QUzzo7cu; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622104221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DLEshZ7MH90fYawIklobGTwjOHDG6ydI2JHUadJtZ2E=; b=QUzzo7cuxpbGO9LT0zTQSKkMYf2FPMI/Jzf+fetXtCaOHhk65fJ8AL20EMsLmgVn2XTxuk Owxh8jVx9kio8aDLwXa6Ex2sIaa8Seb9nhjTitmIlw4Z89i9i6vugL2Zvg3pvXiwm7OtRz baLw49fpO9q+oBnp0X5A//7d2GC8zQU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-198-6Yzol22VMVuAInwiHMYNvw-1; Thu, 27 May 2021 04:30:19 -0400 X-MC-Unique: 6Yzol22VMVuAInwiHMYNvw-1 Received: by mail-wr1-f71.google.com with SMTP id u20-20020a0560001614b02901115c8f2d89so1456706wrb.3 for ; Thu, 27 May 2021 01:30:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DLEshZ7MH90fYawIklobGTwjOHDG6ydI2JHUadJtZ2E=; b=Fz2izSFZUdMAfZS05zlNVwYwZTm6EHdFXYbjwQNDvZ2VR27n5GvMBIE6AbYk5RNJcd S1ZwmGVRG0hW0mDM9g5P71mYYCtFN1678b2i5/w66C2Dzzu4Eb+W3F4gLDvFlIiNvqW9 Q26wSg2fsJ0pHjviskv0HfGgCGhKv49KKQf7WYSKkw9M22avG5R0O/QR4aRZVQm1RrQf Sd4qB4iI9GKN9yppo6AMHyOTjKpNVMtb/fGxewLOmqlPEu9+JVX3uWbKWPY1YG59ONPf ADzIJiZhqSkz/+eZrvdnjk9E4wuwo4ov5ycQYQFaeGVUZVW6FDG9bDN8w6F4H2Et94U1 dKTA== X-Gm-Message-State: AOAM530Q7CPMDeaA/xGPn+N34JELVTL/tezMLNFo07th/h/qaY2ZGrDf Eo57LMZcEyKYyl8yIHq9/eS+lkjfYJWZMqUkpNjAsCMMDpCKUxee9yFCFXYsxMD/9kzK5+uzr6w cCC98QjX3rDrNnw== X-Received: by 2002:a7b:c5d2:: with SMTP id n18mr7174983wmk.97.1622104218757; Thu, 27 May 2021 01:30:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyj8Ztqf6Z6kqNyuwBajWPIVkhv0Grs37BQZtb+ebKo+91zyeGlOs7SXjvUb/D2t72uUpIe2A== X-Received: by 2002:a7b:c5d2:: with SMTP id n18mr7174962wmk.97.1622104218558; Thu, 27 May 2021 01:30:18 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id q1sm9671227wmq.48.2021.05.27.01.30.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 01:30:18 -0700 (PDT) Subject: Re: [PATCH 27/43] OvmfPkg/IncompatiblePciDeviceSupportDxe: remove PcdPciDisableBusEnumeration To: Laszlo Ersek , devel@edk2.groups.io Cc: Ard Biesheuvel , Jordan Justen References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-28-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <5c240b1a-6288-e484-da69-7f1ce561960c@redhat.com> Date: Thu, 27 May 2021 10:30:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-28-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > At this point, the IncompatiblePciDeviceSupportDxe driver is included in > the following platforms in edk2: > > OvmfPkg/AmdSev/AmdSevX64.dsc > OvmfPkg/OvmfPkgIa32.dsc > OvmfPkg/OvmfPkgIa32X64.dsc > OvmfPkg/OvmfPkgX64.dsc > > All those platforms inherit FALSE for "PcdPciDisableBusEnumeration" from > "MdeModulePkg.dec". > > This makes the PcdGetBool() call in the entry point of the driver > superfluous; remove it. Clean up now unused dependencies in the INF file > as well. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.inf | 2 -- > OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.c | 10 +++------- > 2 files changed, 3 insertions(+), 9 deletions(-) Reviewed-by: Philippe Mathieu-Daude