From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web09.6146.1609929085298996578 for ; Wed, 06 Jan 2021 02:31:25 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LcEIvPhM; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1609929084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Gzd/CqqlvEL5wj8ogjs69V9sSndzfUWqhU3C1r7gMk4=; b=LcEIvPhMc/NWWgae59I2eoj6uBdo+m4w638ycPqbrEIIa3idZiWX8M6kSA6rt5b/4egiNj zw6ff+BOCGNK7OauBTzz7bRKLAQARZrdLFThamRnWtDuLo9/iNZ/E/SYj+4wmfFd0FdbaD DTXv+Of9XLv7KwXML0ykxtM4R64rtE4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-554-GHa1HGYePwaAt8MaA7X31w-1; Wed, 06 Jan 2021 05:31:19 -0500 X-MC-Unique: GHa1HGYePwaAt8MaA7X31w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4B7491005D44; Wed, 6 Jan 2021 10:31:17 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-192.ams2.redhat.com [10.36.112.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7484D190D0; Wed, 6 Jan 2021 10:31:14 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v3 5/5] ArmVirtPkg/ArmVirtQemu: Add support for HotPlug To: devel@edk2.groups.io, cenjiahui@huawei.com Cc: Jordan Justen , Ard Biesheuvel , Rebecca Cran , Peter Grehan , Anthony Perard , Julien Grall , Leif Lindholm , Sami Mujawar , xieyingtai@huawei.com, wu.wubin@huawei.com, Yubo Miao References: <20201222095944.8686-1-cenjiahui@huawei.com> <20201222095944.8686-6-cenjiahui@huawei.com> From: "Laszlo Ersek" Message-ID: <5c7a1e82-fdc8-b61a-a8c9-010d6bbfc69c@redhat.com> Date: Wed, 6 Jan 2021 11:31:13 +0100 MIME-Version: 1.0 In-Reply-To: <20201222095944.8686-6-cenjiahui@huawei.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/22/20 10:59, Jiahui Cen via groups.io wrote: > It is necessary to add padding for hotplugable PCI Devices like > pcie-root-port. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059 > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Signed-off-by: Jiahui Cen > Signed-off-by: Yubo Miao > --- > ArmVirtPkg/ArmVirtQemu.dsc | 1 + > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > index a11ffd9ba553..d77c226d80ee 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -488,6 +488,7 @@ [Components.common] > > NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf > } > + OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf > OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf > OvmfPkg/Virtio10Dxe/Virtio10.inf > > diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > index 1752fee12b79..5b1d10057545 100644 > --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > @@ -162,6 +162,7 @@ [FV.FvMain] > INF ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf > INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > + INF OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf > INF OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf > INF OvmfPkg/Virtio10Dxe/Virtio10.inf > > (1) Please be more diligent / careful. You are modifying an FDF *include* file. Obviously, you want to check what includes the file, no? ArmVirtPkg/ArmVirtQemu.fdf:!include ArmVirtQemuFvMain.fdf.inc ArmVirtPkg/ArmVirtQemuKernel.fdf:!include ArmVirtQemuFvMain.fdf.inc Thus, you need to modify "ArmVirtPkg/ArmVirtQemuKernel.dsc" as well; otherwise the ArmVirtQemuKernel platform build will break. Thanks Laszlo