From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A7E42AC125A for ; Tue, 31 Oct 2023 15:15:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=mo8Ce7bVWMwhaHewp/CzwCv6SmP3DmbGp0ydL3VoyLM=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698765352; v=1; b=IVINebDQQFgXMlayznO25/r2Lh/ATfDFnx9Qbr9t6wmf8hVmlsFXkU9/QZ2fpUaHsq0YmfTe jUhhe8Z/9WWJuAyDVrD50PJNVevNhwrEB89AKAuFK5FFGtTBfW6/1sGYyKmLxURnscsjmOsY2m7 3fI/tyvMQYEZOizBn5+2Cf3k= X-Received: by 127.0.0.2 with SMTP id ItmFYY7687511x4j7M9lTiLx; Tue, 31 Oct 2023 08:15:52 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.1224.1698765351745419788 for ; Tue, 31 Oct 2023 08:15:51 -0700 X-Received: from [192.168.4.22] (unknown [47.201.241.95]) by linux.microsoft.com (Postfix) with ESMTPSA id 4F80920B74C0; Tue, 31 Oct 2023 08:15:50 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4F80920B74C0 Message-ID: <5c8e8329-4301-4f18-bdc2-fc7156c34f11@linux.microsoft.com> Date: Tue, 31 Oct 2023 11:15:48 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 1/1] ArmVirtPkg/PlatformCI/ReadMe.md: Update contents To: devel@edk2.groups.io, lersek@redhat.com Cc: Ard Biesheuvel , Gerd Hoffmann , Julien Grall , Leif Lindholm , Sami Mujawar References: <20231030230902.849-1-mikuback@linux.microsoft.com> <6024024a-bc8a-d378-c0f7-5ed0b8964759@redhat.com> From: "Michael Kubacki" In-Reply-To: <6024024a-bc8a-d378-c0f7-5ed0b8964759@redhat.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4j7t0T7mfOaki012uxWmC2aEx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=IVINebDQ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/31/2023 8:23 AM, Laszlo Ersek wrote: > On 10/31/23 00:09, Michael Kubacki wrote: >> From: Michael Kubacki >> >> Since the code is most regularly tested in CI, distro/versioning >> details are updated to match the latest CI configuration. >> >> CI has moved from Ubuntu 18.04 to Ubuntu 22.04 since the time of the >> file's creation, but the code is actually built in a Fedora container >> so Fedora is mentioned as the primary build/test environment. >> >> Updates the following information: >> >> - Build OS: Fedora 37 Linux >> - Supported Configuration: Additional DSCs added >> - Python: 3.12.x >> - Packaging Tool: dnf instead of apt >> - Container Details: Added >> - Primary Build Example: QemuBuild.py instead of PlatformBuild.py >> >> Cc: Ard Biesheuvel >> Cc: Gerd Hoffmann >> Cc: Julien Grall >> Cc: Leif Lindholm >> Cc: Sami Mujawar >> Signed-off-by: Michael Kubacki >> --- >> >> Notes: >> I don't use ArmVirtPkg that often. I was reviewing the >> file for the latest build instructions and realized it >> was quite out of date, leading to this patch. >> =20 >> The project is using Python 3.11.x right now, but a >> patch is going in the next day or so that has shown >> Python 3.12 will work: >> https://edk2.groups.io/g/devel/message/110323 >> =20 >> So I went ahead and made the Python version in this >> patch mention 3.12.x. >> >> ArmVirtPkg/PlatformCI/ReadMe.md | 53 +++++++++++++------- >> 1 file changed, 34 insertions(+), 19 deletions(-) >> >> diff --git a/ArmVirtPkg/PlatformCI/ReadMe.md b/ArmVirtPkg/PlatformCI/Rea= dMe.md >> index ee8d8cd61e73..c0f2b2a43b3c 100644 >> --- a/ArmVirtPkg/PlatformCI/ReadMe.md >> +++ b/ArmVirtPkg/PlatformCI/ReadMe.md >> @@ -5,28 +5,43 @@ to use the same Pytools based build infrastructure loc= ally. >> =20 >> ## Supported Configuration Details >> =20 >> -This solution for building and running ArmVirtPkg has only been validat= ed with Ubuntu >> -18.04 and the GCC5 toolchain. Two different firmware builds are support= ed and are >> -described below. >> +This solution for building and running ArmVirtPkg has been validated wi= th Fedora >> +37 Linux and the GCC5 toolchain. Two different firmware builds are supp= orted >> +and are described below. >=20 > "Two different firmware builds" is now stale; we're listing 10. >=20 > I'd suggest "The following different firmware builds". >=20 > No need to repost just for that; I'm fine if it gets updated upon merge. >=20 Thanks for catching that and getting those changes merged. > Reviewed-by: Laszlo Ersek >=20 > Thanks > Laszlo >=20 >> =20 >> -| Configuration name | Architecture | DSC File |Addi= tional Flags | >> -| :---------- | :----- | :----- | :--= -- | >> -| AARCH64 | AARCH64 | ArmVirtQemu.dsc | Non= e | >> -| ARM | ARM | ArmVirtQemu.dsc | Non= e | >> +| Configuration name | Architecture | DSC File = | Additional Flags | >> +| :---------- | :----- | :----- = | :---- | >> +| AARCH64 - KVM Cloud HV | AARCH64 | ArmVirtCloudHv.dsc = | None | >> +| ARM - KVM Cloud HV | ARM | ArmVirtCloudHv.dsc = | None | >> +| AARCH64 - kvmtool | AARCH64 | ArmVirtKvmTool.dsc = | None | >> +| ARM - kvmtool | ARM | ArmVirtKvmTool.dsc = | None | >> +| AARCH64 - QEMU | AARCH64 | ArmVirtQemu.dsc = | None | >> +| ARM - QEMU | ARM | ArmVirtQemu.dsc = | None | >> +| AARCH64 - QEMU Kernel | AARCH64 | ArmVirtQemuKernel.dsc = | None | >> +| ARM - QEMU Kernel | ARM | ArmVirtQemuKernel.dsc = | None | >> +| AARCH64 - Xen HV | AARCH64 | ArmVirtXen.dsc = | None | >> +| ARM - Xen HV | ARM | ArmVirtXen.dsc = | None | >> =20 >> ## EDK2 Developer environment >> =20 >> -- [Python 3.8.x - Download & Install](https://www.python.org/downloads/= ) >> +- [Python 3.12.x - Download & Install](https://www.python.org/downloads= /) >> - [GIT - Download & Install](https://git-scm.com/download/) >> - [QEMU - Download, Install, and add to your path](https://www.qemu.or= g/download/) >> - [Edk2 Source](https://github.com/tianocore/edk2) >> -- Additional packages found necessary for Ubuntu 18.04 >> - - apt-get install gcc g++ make uuid-dev >> +- Additional packages found necessary for Fedora Linux 37 >> + - dnf install gcc g++ make libuuid-devel >> =20 >> Note: edksetup, Submodule initialization and manual installation of NA= SM, iASL, or >> the required cross-compiler toolchains are **not** required, this is h= andled by the >> Pytools build system. >> =20 >> +The code is built in CI using a container. The latest Fedora Linux 37 c= ontainer is >> +available in this GitHub container registry feed >> +[fedora-37-test](https://github.com/tianocore/containers/pkgs/container= /containers%2Ffedora-37-test). >> + >> +The exact container version tested in CI is maintained in this file >> +[edk2/.azurepipelines/templates/default.yml](https://github.com/tianoco= re/edk2/blob/HEAD/.azurepipelines/templates/defaults.yml). >> + >> ## Building with Pytools for ArmVirtPkg >> =20 >> If you are unfamiliar with Pytools, it is recommended to first read th= rough >> @@ -57,16 +72,16 @@ the generic set of edk2 [Build Instructions](https:/= /github.com/tianocore/tianoc >> pip install --upgrade -r pip-requirements.txt >> ``` >> =20 >> -4. Initialize & Update Submodules - only when submodules updated >> +4. Initialize & Update Submodules - only when submodules updated (QEMU = build example) >> =20 >> ``` bash >> - stuart_setup -c ArmVirtPkg/PlatformCI/PlatformBuild.py TOOL_CHAIN_T= AG=3D -a >> + stuart_setup -c ArmVirtPkg/PlatformCI/QemuBuild.py TOOL_CHAIN_TAG= =3D -a >> ``` >> =20 >> -5. Initialize & Update Dependencies - only as needed when ext_deps chan= ge >> +5. Initialize & Update Dependencies - only as needed when ext_deps chan= ge (QEMU build example) >> =20 >> ``` bash >> - stuart_update -c ArmVirtPkg/PlatformCI/PlatformBuild.py TOOL_CHAIN_= TAG=3D -a >> + stuart_update -c ArmVirtPkg/PlatformCI/QemuBuild.py TOOL_CHAIN_TAG= =3D -a >> ``` >> =20 >> 6. Compile the basetools if necessary - only when basetools C source f= iles change >> @@ -75,13 +90,13 @@ the generic set of edk2 [Build Instructions](https:/= /github.com/tianocore/tianoc >> python BaseTools/Edk2ToolsBuild.py -t >> ``` >> =20 >> -7. Compile Firmware >> +7. Compile Firmware (QEMU build example) >> =20 >> ``` bash >> - stuart_build -c ArmVirtPkg/PlatformCI/PlatformBuild.py TOOL_CHAIN_T= AG=3D -a >> + stuart_build -c ArmVirtPkg/PlatformCI/QemuBuild.py TOOL_CHAIN_TAG= =3D -a >> ``` >> =20 >> - - use `stuart_build -c ArmVirtPkg/PlatformCI/PlatformBuild.py -h` o= ption to see additional >> + - use `stuart_build -c ArmVirtPkg/PlatformCI/QemuBuild.py -h` optio= n to see additional >> options like `--clean` >> =20 >> 8. Running Emulator >> @@ -90,7 +105,7 @@ the generic set of edk2 [Build Instructions](https://= github.com/tianocore/tianoc >> - or use the `--FlashOnly` feature to just run the emulator. >> =20 >> ``` bash >> - stuart_build -c ArmVirtPkg/PlatformCI/PlatformBuild.py TOOL_CHAIN= _TAG=3D -a --FlashOnly >> + stuart_build -c ArmVirtPkg/PlatformCI/QemuBuild.py TOOL_CHAIN_TAG= =3D -a --FlashOnly >> ``` >> =20 >> ### Notes >> @@ -120,7 +135,7 @@ command-line. _stuart_build_ currently requires valu= es to be assigned, so add an >> For example, to enable the TPM2 support, instead of the traditional "-= D TPM2_ENABLE=3DTRUE", the stuart_build >> command-line would be: >> =20 >> -`stuart_build -c ArmVirtPkg/PlatformCI/PlatformBuild.py BLD_*_TPM2_ENAB= LE=3DTRUE` >> +`stuart_build -c ArmVirtPkg/PlatformCI/QemuBuild.py BLD_*_TPM2_ENABLE= =3DTRUE` >> =20 >> ## References >> =20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110420): https://edk2.groups.io/g/devel/message/110420 Mute This Topic: https://groups.io/mt/102287336/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-