From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E45FC1A1DFF for ; Wed, 26 Oct 2016 15:25:39 -0700 (PDT) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 35F74FA8B9; Wed, 26 Oct 2016 22:25:39 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-27.phx2.redhat.com [10.3.116.27]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9QMPYGx026735; Wed, 26 Oct 2016 18:25:34 -0400 To: "Kinney, Michael D" , edk2-devel-01 References: <20161026190504.9888-1-lersek@redhat.com> <20161026190504.9888-6-lersek@redhat.com> Cc: "Ni, Ruiyu" , Tim He , "Tian, Feng" , "Dong, Eric" , Cecil Sheng , Ard Biesheuvel , "Justen, Jordan L" , "Gao, Liming" , "Bi, Dandan" , "Wu, Jiaxin" , Gary Lin , "Zeng, Star" , Daryl McDaniel , "Carsey, Jaben" , "Fu, Siyuan" , "Fan, Jeff" , "Zhang, Chao B" , "Wei, David" From: Laszlo Ersek Message-ID: <5cd1b4e5-a1ec-47e7-3e99-95bb1a55d6e9@redhat.com> Date: Thu, 27 Oct 2016 00:25:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 26 Oct 2016 22:25:39 +0000 (UTC) Subject: Re: [PATCH 05/47] MdePkg/Include/Base.h: introduce the ARRAY_SIZE() function-like macro X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Oct 2016 22:25:40 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 10/27/16 00:13, Kinney, Michael D wrote: > Hi Laszlo, > > One comment inline below. > > Mike > >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek >> Sent: Wednesday, October 26, 2016 12:04 PM >> To: edk2-devel-01 >> Cc: Ni, Ruiyu ; Tim He ; Tian, Feng >> ; Kinney, Michael D ; Dong, Eric >> ; Cecil Sheng ; Ard Biesheuvel >> ; Justen, Jordan L ; Gao, Liming >> ; Bi, Dandan ; Wu, Jiaxin >> ; Gary Lin ; Zeng, Star ; >> Daryl McDaniel ; Carsey, Jaben ; >> Fu, Siyuan ; Fan, Jeff ; Zhang, Chao B >> ; Wei, David >> Subject: [edk2] [PATCH 05/47] MdePkg/Include/Base.h: introduce the ARRAY_SIZE() >> function-like macro >> >> Several modules use ARRAY_SIZE() already; centralize the definition. (The >> module-specific macro definitions are guarded by #ifndef directives at >> this point.) >> >> Cc: Ard Biesheuvel >> Cc: Cecil Sheng >> Cc: Chao Zhang >> Cc: Dandan Bi >> Cc: Daryl McDaniel >> Cc: David Wei >> Cc: Eric Dong >> Cc: Feng Tian >> Cc: Gary Lin >> Cc: Jaben Carsey >> Cc: Jeff Fan >> Cc: Jiaxin Wu >> Cc: Jordan Justen >> Cc: Liming Gao >> Cc: Michael D Kinney >> Cc: Ruiyu Ni >> Cc: Siyuan Fu >> Cc: Star Zeng >> Cc: Tim He >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Laszlo Ersek >> --- >> MdePkg/Include/Base.h | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h >> index c66614846488..8bdb257e37bd 100644 >> --- a/MdePkg/Include/Base.h >> +++ b/MdePkg/Include/Base.h >> @@ -1211,5 +1211,18 @@ typedef UINTN RETURN_STATUS; >> #define RETURN_ADDRESS(L) ((VOID *) 0) >> #endif >> >> +/** >> + Return the number of elements in an array. >> + >> + @param Array An object of array type. Array is only used as an argument to >> + the sizeof operator, therefore Array is never evaluated. The >> + caller is responsible for ensuring that Array's type is not >> + incomplete; that is, Array must have known constant size. >> + >> + @return The number of elements in Array. The result has type UINTN. >> + >> +**/ >> +#define ARRAY_SIZE(Array) (sizeof (Array) / sizeof (Array)[0]) > > I think adding one extra set of () makes this clearer: > > #define ARRAY_SIZE(Array) (sizeof (Array) / sizeof ((Array)[0])) Sure, will do. Thanks! Laszlo >> + >> #endif >> >> -- >> 2.9.2 >> >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel