From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) by mx.groups.io with SMTP id smtpd.web10.29122.1612745841501066957 for ; Sun, 07 Feb 2021 16:57:21 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=C0hAjzu0; spf=pass (domain: nuviainc.com, ip: 209.85.210.50, mailfrom: rebecca@nuviainc.com) Received: by mail-ot1-f50.google.com with SMTP id 100so5981638otg.3 for ; Sun, 07 Feb 2021 16:57:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5ZCti+jyTn/7RBfL1ouQm52gUNkUG2TOlsH7Z/LwaoQ=; b=C0hAjzu0GcPeFDtbAUJ3jEWMHJX+JNuvYBD8jfhdwPRIoxSGi7ev/58WuSclFtNkeh kpTa3dNASEeQy/wMw5gPsbibYBB8ASKtTdzJuqLzS8CZ/e+NmxqDNt0R2rX9cD8WW4Y5 v5tUfotru/C8dfJPcjWSiShaW7IBu7kS7fFd9zy2eU9TYwlcE6o/Jr001hT5fL0dMQYs mXkSmxyz2nSxMDzFUH5f9QZwpLQNEP4qL6PDvNpWy5gEku+sPadX8x8dMtiKtuKgEwY9 gLbRTahixiM5yhh0QSQxSUFdZdvyX/szjANnkA33cx1H0l0vyJVLhPlv/116WbB/OWJQ xQFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5ZCti+jyTn/7RBfL1ouQm52gUNkUG2TOlsH7Z/LwaoQ=; b=qP3Bz81JepvJQE2tbbLU7aU2sIOLVLY89uNtiinSpOKT/uVp2BytsHEYXMt5zzPA2B iGWB1cSZgglQTlP3MBKM2ykneNYcjha76PJiS8nUeMlYuT7KH5pqMKTOxMJiJ1/tB76d HRWHEMGD7HVMKJ71ySIC+ElQ4KI0oqxI3dViYK821D8b5p18jRrwk73bKmHjShsWXRaV qoYYkuToihn21DCPECBB417CDDB3/uPibQgIykr9YK/O17O/eoM1iHz0bloM4cRszujY MKUhJqg9a/1wy/QdN9POx6jzGVelLJMwy0b04Se2tanWm0D05pvCVTtovg3pGDAekjum qGoQ== X-Gm-Message-State: AOAM530qKxamtgtWyR2orbQ/bZQpIVZDwmEJCQb1BbWo0O7aDmbVzUM4 lU/INWpnvi+gmhDxltmuQOEZqw== X-Google-Smtp-Source: ABdhPJwZY33/Vgzm94lE0WrKiBjKk3bVWDAT1rLEVAenw3h5XpGN0OK9XLLPx+wBM6FHdM9oFgevRg== X-Received: by 2002:a05:6830:15cc:: with SMTP id j12mr11090371otr.145.1612745840884; Sun, 07 Feb 2021 16:57:20 -0800 (PST) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id n27sm3356498oij.36.2021.02.07.16.57.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Feb 2021 16:57:20 -0800 (PST) Subject: Re: [PATCH v8 00/21] ArmPkg,MdePkg: Add Universal/Smbios, and related changes To: devel@edk2.groups.io Cc: leif@nuviainc.com, Ard Biesheuvel , nd@arm.com, Sami Mujawar , Liming Gao , Michael D Kinney , Zhiguang Liu , Samer El-Haj-Mahmoud , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20210208005254.12176-1-rebecca@nuviainc.com> From: "Rebecca Cran" Message-ID: <5cd2cd65-d2d2-f834-d4a9-56f44d7ef7c7@nuviainc.com> Date: Sun, 7 Feb 2021 17:57:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210208005254.12176-1-rebecca@nuviainc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Personal github PR: https://github.com/tianocore/edk2/pull/1411 On 2/7/21 5:52 PM, Rebecca Cran wrote: > Much of the data for the SMBIOS tables is generic, and need not be > duplicated for each platform. This patch series introduces > ArmPkg/Universal/Smbios, which is largely copied from > edk2-platforms/Silicon/HiSilicon/Drivers/Smbios and generates SMBIOS > tables 0,1,2,3,4,7,13,32 and uses a combination of PCDs and calls into a > new OemMiscLib to get information which varies between platforms. > > I plan to submit a patch against SbsaQemu to update it to use this new > functionality. > > Changes from v7 to v8: > > o Changed associativity function to return 1-based value. > o Changed cache level parameter and return values to be 1-based. > o Other changes based on Leif's review feedback. > > More changes are needed to support reporting boot status etc., but with the > series getting rather large I think it might be good to get this committed > and make a follow-up series with the additional changes. > > Testing: > > o Ran Ecc tool > > o Ran smbiosview in the UEFI Shell > > > Rebecca Cran (21): > ArmPkg: Add ARM SMC Architecture functions to ArmStdSmc.h > MdePkg: Update IndustryStandard/SmBios.h with processor status data > ArmPkg: Add register encoding definition for MMFR2 > ArmPkg: Add helper to read the Memory Model Features Register 2 > ArmPkg: Add helper function to read the Memory Model Feature Register > 4 > ArmPkg: Fix the return type of the ReadCCSIDR function > ArmPkg: Update ArmLibPrivate.h with cache register definitions > ArmPkg: Add definition of the maximum cache level in ARMv8-A > ArmPkg: Add helper to read CCIDX status > ArmPkg: Add helper to read the CCSIDR2 register > ArmPkg: Add Library/OemMiscLib.h > ArmPkg: Add Universal/Smbios/OemMiscLibNull > ArmPkg: Add Universal/Smbios/ProcessorSubClassDxe > ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type00 > ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type01 > ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type02 > ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type03 > ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type13 > ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type32 > ArmPkg: Add SMBIOS PCDs to ArmPkg.dec > ArmPkg: Add Universal/Smbios/SmbiosMiscDxe > > ArmPkg/ArmPkg.dec | 17 + > ArmPkg/ArmPkg.dsc | 5 + > ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf | 31 + > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf | 66 ++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf | 89 +++ > ArmPkg/Include/Chipset/AArch64.h | 4 + > ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 16 + > ArmPkg/Include/Library/ArmLib.h | 15 + > ArmPkg/Include/Library/OemMiscLib.h | 167 +++++ > ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h | 11 + > ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h | 8 +- > ArmPkg/Library/ArmLib/ArmLibPrivate.h | 117 ++- > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessor.h | 102 +++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMisc.h | 134 ++++ > MdePkg/Include/IndustryStandard/SmBios.h | 13 + > ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c | 19 +- > ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c | 19 +- > ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 144 ++++ > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 752 ++++++++++++++++++++ > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorAArch64.c | 93 +++ > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c | 99 +++ > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c | 249 +++++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDataTable.c | 62 ++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 223 ++++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorData.c | 93 +++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 296 ++++++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerData.c | 36 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c | 196 +++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerData.c | 46 ++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 230 ++++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c | 52 ++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c | 224 ++++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesData.c | 33 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c | 166 +++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationData.c | 32 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c | 73 ++ > ArmPkg/Library/ArmLib/AArch64/AArch64Support.S | 3 + > ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S | 2 +- > ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S | 16 +- > ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.asm | 16 +- > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni | 24 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxeStrings.uni | 22 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni | 18 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni | 20 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni | 20 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni | 18 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguages.uni | 43 ++ > 47 files changed, 4126 insertions(+), 8 deletions(-) > create mode 100644 ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf > create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > create mode 100644 ArmPkg/Include/Library/OemMiscLib.h > create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessor.h > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMisc.h > create mode 100644 ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c > create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorAArch64.c > create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c > create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDataTable.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorData.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerData.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerData.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesData.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationData.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c > create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxeStrings.uni > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguages.uni >