Re: [PATCH V1 0/3] Customize lazy-accepted memory size for TDVF

["Lendacky, Thomas" <thomas.lendacky@amd.com>]

On 12/25/22 19:33, Min Xu wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4181
> 
> Current lazy-accept accepts the memory under address of 4G. To improve
> boot performance further more, we introduce the feature of customizing
> the physical end address of lazy-accept in build time.
> 
> The end address is indicated by PcdAcceptMemoryEndAddress. It means it
> accepts the memory under PcdAcceptMemoryEndAddress. The default value
> and the max value is 4G. This is to be consistent with the current rule
> (accept memory under 4G).
> 
> In IntelTdxX64 PcdAcceptMemoryEndAddress can be customized on-demand in
> build-time by adding -D ACCEPT_MEMORY_END_ADDRESS=512 in build command.

Wasn't there an agreement against modifying the build environment like 
this for memory acceptance? I realize this is not an accept / no-accept 
build environment change, but still...

Thanks,
Tom

> 
> Code: https://github.com/mxu9/edk2/tree/CustomizeLazyAcceptSize.v1
> 
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Signed-off-by: Min Xu <min.m.xu@intel.com>
> 
> Min M Xu (3):
>    OvmfPkg: Customize lazy-accept's end address
>    OvmfPkg/PeilessStartupLib: Update ConstructFwHobList for lazy-accept
>    OvmfPkg/PlatformPei: Adjust LowerMemorySize in PublishPeiMemory
> 
>   OvmfPkg/IntelTdx/IntelTdxX64.dsc              |  8 ++++
>   OvmfPkg/Library/PeilessStartupLib/Hob.c       | 25 +++++++++----
>   .../PeilessStartupLib/PeilessStartupLib.inf   |  1 +
>   OvmfPkg/Library/PlatformInitLib/IntelTdx.c    | 37 ++++++++++++++-----
>   .../PlatformInitLib/PlatformInitLib.inf       |  1 +
>   OvmfPkg/OvmfPkg.dec                           |  2 +
>   OvmfPkg/PlatformPei/MemDetect.c               | 13 +++++++
>   OvmfPkg/PlatformPei/PlatformPei.inf           |  1 +
>   8 files changed, 72 insertions(+), 16 deletions(-)
>