From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Thu, 26 Sep 2019 05:14:42 -0700
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id D15EEA44AC7;
	Thu, 26 Sep 2019 12:14:41 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-49.rdu2.redhat.com [10.10.120.49])
	by smtp.corp.redhat.com (Postfix) with ESMTP id EA5C060933;
	Thu, 26 Sep 2019 12:14:40 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH 20/35] NetworkPkg/Ip4Dxe: fix NetLibDestroyServiceChild() call
From: "Laszlo Ersek" <lersek@redhat.com>
To: Jiaxin Wu <jiaxin.wu@intel.com>, Siyuan Fu <siyuan.fu@intel.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>
Reply-To: devel@edk2.groups.io, lersek@redhat.com
References: <20190917194935.24322-1-lersek@redhat.com>
 <20190917194935.24322-21-lersek@redhat.com>
Message-ID: <5ceb8c69-1996-43c3-3833-a5c714e1fc78@redhat.com>
Date: Thu, 26 Sep 2019 14:14:40 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190917194935.24322-21-lersek@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]); Thu, 26 Sep 2019 12:14:41 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Jiaxin, Siyuan,

can you please review this patch?

Thanks
Laszlo


On 09/17/19 21:49, Laszlo Ersek wrote:
> Both NetLibDestroyServiceChild() and EFI_SERVICE_BINDING_DESTROY_CHILD
> take an EFI_HANDLE for the "ChildHandle" parameter, not an (EFI_HANDLE*).
> 
> This patch fixes a real bug.
> 
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     possibly only build-tested
> 
>  NetworkPkg/Ip4Dxe/Ip4If.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/NetworkPkg/Ip4Dxe/Ip4If.c b/NetworkPkg/Ip4Dxe/Ip4If.c
> index 44b8d9fc8faf..53a333037f94 100644
> --- a/NetworkPkg/Ip4Dxe/Ip4If.c
> +++ b/NetworkPkg/Ip4Dxe/Ip4If.c
> @@ -592,7 +592,7 @@ Ip4SetAddress (
>        Interface->Controller,
>        Interface->Image,
>        &gEfiArpServiceBindingProtocolGuid,
> -      &Interface->ArpHandle
> +      Interface->ArpHandle
>        );
>  
>      Interface->ArpHandle = NULL;
> @@ -657,7 +657,7 @@ ON_ERROR:
>      Interface->Controller,
>      Interface->Image,
>      &gEfiArpServiceBindingProtocolGuid,
> -    &Interface->ArpHandle
> +    Interface->ArpHandle
>      );
>  
>    return Status;
>