Re: [Patch 5/6] NetworkPkg/IScsiDxe: Add the clarification compared to IScsiDxe in MdeModulePkg.

[Laszlo Ersek <lersek@redhat.com>]

On 09/25/18 05:44, Jiaxin Wu wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205
> 
> This patch is to add the driver usage/difference clarification
> compared to IScsiDxe in MdeModulePkg.
> 
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
>  NetworkPkg/IScsiDxe/IScsiDxe.inf | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/NetworkPkg/IScsiDxe/IScsiDxe.inf b/NetworkPkg/IScsiDxe/IScsiDxe.inf
> index 61a0693a07..007418fd9c 100644
> --- a/NetworkPkg/IScsiDxe/IScsiDxe.inf
> +++ b/NetworkPkg/IScsiDxe/IScsiDxe.inf
> @@ -1,10 +1,20 @@
>  ## @file
>  #  Client-side iSCSI service.
>  #
>  #  The iSCSI driver provides iSCSI service in the preboot environment and supports
> -#  booting over iSCSI.
> +#  booting over iSCSI. This driver supports both IPv4 and IPv6 network stack.
> +#
> +#  Notes: 
> +#  1) This driver can't co-work with the IScsiDxe driver in MdeModulePkg. 
> +#  2) This driver includes more bugs fix and supports more features (e.g. IPv6, Dns 
> +#     support for target URL configuration, iSCSI keyword support) than the IscsiDxe 
> +#     driver in MdeModulePkg. So, we recommand to use this driver even both of them 
> +#     can be used.

Same comments as for patch #4.

> +#  3) This driver depends on the OpenSSL building. To use this driver, please follow 

I suggest "on the OpenSSL building" --> "on OpenSSL".

> +#     the instructions found in the file "Patch-HOWTO.txt" located in 
> +#     CryptoPkg\Library\OpensslLib to enable the OpenSSL building first.

The "Patch-HOWTO.txt" file no longer exists; it's now called
"OpenSSL-HOWTO.txt".

With those fixed:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo

>  #
>  # Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<BR>
>  # This program and the accompanying materials
>  # are licensed and made available under the terms and conditions of the BSD License
>  # which accompanies this distribution.  The full text of the license may be found at
>