From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0973E2114845C for ; Tue, 25 Sep 2018 03:29:15 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 82A35308A954; Tue, 25 Sep 2018 10:29:14 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-71.rdu2.redhat.com [10.10.120.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6477C3001930; Tue, 25 Sep 2018 10:29:13 +0000 (UTC) To: Jiaxin Wu , edk2-devel@lists.01.org Cc: Ye Ting , Fu Siyuan References: <20180925034445.14896-1-Jiaxin.wu@intel.com> <20180925034445.14896-6-Jiaxin.wu@intel.com> From: Laszlo Ersek Message-ID: <5d00339d-2910-5ebe-3210-8fc928f2ade1@redhat.com> Date: Tue, 25 Sep 2018 12:29:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180925034445.14896-6-Jiaxin.wu@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Tue, 25 Sep 2018 10:29:14 +0000 (UTC) Subject: Re: [Patch 5/6] NetworkPkg/IScsiDxe: Add the clarification compared to IScsiDxe in MdeModulePkg. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 10:29:15 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/25/18 05:44, Jiaxin Wu wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205 > > This patch is to add the driver usage/difference clarification > compared to IScsiDxe in MdeModulePkg. > > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wu Jiaxin > --- > NetworkPkg/IScsiDxe/IScsiDxe.inf | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/NetworkPkg/IScsiDxe/IScsiDxe.inf b/NetworkPkg/IScsiDxe/IScsiDxe.inf > index 61a0693a07..007418fd9c 100644 > --- a/NetworkPkg/IScsiDxe/IScsiDxe.inf > +++ b/NetworkPkg/IScsiDxe/IScsiDxe.inf > @@ -1,10 +1,20 @@ > ## @file > # Client-side iSCSI service. > # > # The iSCSI driver provides iSCSI service in the preboot environment and supports > -# booting over iSCSI. > +# booting over iSCSI. This driver supports both IPv4 and IPv6 network stack. > +# > +# Notes: > +# 1) This driver can't co-work with the IScsiDxe driver in MdeModulePkg. > +# 2) This driver includes more bugs fix and supports more features (e.g. IPv6, Dns > +# support for target URL configuration, iSCSI keyword support) than the IscsiDxe > +# driver in MdeModulePkg. So, we recommand to use this driver even both of them > +# can be used. Same comments as for patch #4. > +# 3) This driver depends on the OpenSSL building. To use this driver, please follow I suggest "on the OpenSSL building" --> "on OpenSSL". > +# the instructions found in the file "Patch-HOWTO.txt" located in > +# CryptoPkg\Library\OpensslLib to enable the OpenSSL building first. The "Patch-HOWTO.txt" file no longer exists; it's now called "OpenSSL-HOWTO.txt". With those fixed: Reviewed-by: Laszlo Ersek Thanks! Laszlo > # > # Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.
> # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > # which accompanies this distribution. The full text of the license may be found at >