From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, jian.j.wang@intel.com,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"Lu, XiaoyuX" <xiaoyux.lu@intel.com>
Cc: "Ye, Ting" <ting.ye@intel.com>, Richard Levitte <levitte@openssl.org>
Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/OpensslLib: Exclude err_all.c in process_files.py
Date: Wed, 26 Jun 2019 14:46:24 +0200 [thread overview]
Message-ID: <5d1b408e-6f6b-7d39-fc37-891fc92b844b@redhat.com> (raw)
In-Reply-To: <D827630B58408649ACB04F44C51000362592C4F6@SHSMSX107.ccr.corp.intel.com>
Jian,
On 06/25/19 10:58, Wang, Jian J wrote:
> I take this as agreement. I pushed this patch at (fixed file ext)
>
> 51f7a3e6c5192d3f9a0fa63b0b5617c151180ad7
Please pay more attention to the process.
First, you pushed the patch, but the BZ (1881) is still open. You or
XiaoyuX should have closed the BZ with a reference to the commit. I'm
doing that now.
Second, in commit 51f7a3e6c519, you failed to pick up my R-b from the list:
http://mid.mail-archive.com/22434e9b-745c-671c-2b71-43f5ecb49848@redhat.com
My suggestion is, just before you push a patch, go through the entire
mailing list thread for one last time, to make sure no feedback is lost.
(Obviously, if your MUA doesn't offer a threaded view, this is quite
difficult. Even in that case though, you could filter the list folder
for the particular subject, at the least.)
> Above one is in our plan. I added BZ#1936 for this one.
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=1936
That's appreciated.
Laszlo
next prev parent reply other threads:[~2019-06-26 12:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 7:19 [PATCH v1 1/1] CryptoPkg/OpensslLib: Exclude err_all.c in process_files.py Xiaoyu Lu
2019-06-19 22:59 ` Laszlo Ersek
2019-06-20 0:34 ` [edk2-devel] " Wang, Jian J
2019-06-20 7:54 ` David Woodhouse
2019-06-20 14:46 ` Laszlo Ersek
2019-06-20 22:33 ` David Woodhouse
2019-06-21 8:37 ` Wang, Jian J
2019-06-24 19:54 ` Laszlo Ersek
2019-06-25 8:58 ` Wang, Jian J
2019-06-26 12:46 ` Laszlo Ersek [this message]
2019-06-26 13:16 ` Wang, Jian J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d1b408e-6f6b-7d39-fc37-891fc92b844b@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox