From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Wed, 26 Jun 2019 05:46:38 -0700
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 2F3CE307D85E;
	Wed, 26 Jun 2019 12:46:27 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-47.ams2.redhat.com [10.36.117.47])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 674DD100033F;
	Wed, 26 Jun 2019 12:46:25 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/OpensslLib: Exclude err_all.c in process_files.py
To: devel@edk2.groups.io, jian.j.wang@intel.com,
 "dwmw2@infradead.org" <dwmw2@infradead.org>,
 "Lu, XiaoyuX" <xiaoyux.lu@intel.com>
Cc: "Ye, Ting" <ting.ye@intel.com>, Richard Levitte <levitte@openssl.org>
References: <1560928761-1867-1-git-send-email-xiaoyux.lu@intel.com>
 <e23c996cf8908eb2643b7278751151202c8bb57e.camel@infradead.org>
 <c6c028b2-2624-ab77-b6fe-ed080cd2cade@redhat.com>
 <821c1ef9bf8ae42b60627876b696a86cde1f6f84.camel@infradead.org>
 <D827630B58408649ACB04F44C51000362592AAFE@SHSMSX107.ccr.corp.intel.com>
 <59b1f136-e1dd-257c-e45a-001358605b60@redhat.com>
 <D827630B58408649ACB04F44C51000362592C4F6@SHSMSX107.ccr.corp.intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <5d1b408e-6f6b-7d39-fc37-891fc92b844b@redhat.com>
Date: Wed, 26 Jun 2019 14:46:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <D827630B58408649ACB04F44C51000362592C4F6@SHSMSX107.ccr.corp.intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Wed, 26 Jun 2019 12:46:33 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Jian,

On 06/25/19 10:58, Wang, Jian J wrote:

> I take this as agreement. I pushed this patch at (fixed file ext)
> 
> 51f7a3e6c5192d3f9a0fa63b0b5617c151180ad7

Please pay more attention to the process.

First, you pushed the patch, but the BZ (1881) is still open. You or
XiaoyuX should have closed the BZ with a reference to the commit. I'm
doing that now.

Second, in commit 51f7a3e6c519, you failed to pick up my R-b from the list:

http://mid.mail-archive.com/22434e9b-745c-671c-2b71-43f5ecb49848@redhat.com

My suggestion is, just before you push a patch, go through the entire
mailing list thread for one last time, to make sure no feedback is lost.

(Obviously, if your MUA doesn't offer a threaded view, this is quite
difficult. Even in that case though, you could filter the list folder
for the particular subject, at the least.)

> Above one is in our plan. I added BZ#1936 for this one.
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=1936

That's appreciated.

Laszlo