From: "Oliver Smith-Denny" <osde@linux.microsoft.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"pedro.falcato@gmail.com" <pedro.falcato@gmail.com>
Cc: "rebecca@bsdio.com" <rebecca@bsdio.com>
Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`
Date: Mon, 21 Oct 2024 13:37:57 -0700 [thread overview]
Message-ID: <5d45782d-26a8-45da-bbec-98715f1bb436@linux.microsoft.com> (raw)
In-Reply-To: <CO1PR11MB4929E48A471FEB464E5AD75DD2432@CO1PR11MB4929.namprd11.prod.outlook.com>
On 10/21/2024 1:35 PM, Kinney, Michael D wrote:
> Would it help if code was modified to completely remove the use of
> static in local variables and enforce that going forward and limit
> use of static to functions and global variables?
>
We'd have to test further, but I believe that would allow Pedro's
scheme of simply `#define static <nothing>` to work. I ran a
quick godbolt test and it seems MSVC is also okay with that.
Oliver
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120642): https://edk2.groups.io/g/devel/message/120642
Mute This Topic: https://groups.io/mt/108941574/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-10-21 20:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 1:20 [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC` Rebecca Cran
2024-10-11 3:41 ` Sean
2024-10-11 16:47 ` Rebecca Cran
2024-10-14 15:22 ` Oliver Smith-Denny
2024-10-14 16:47 ` Rebecca Cran
2024-10-14 17:09 ` Oliver Smith-Denny
2024-10-15 21:12 ` Michael D Kinney
2024-10-21 14:49 ` Rebecca Cran
2024-10-21 15:46 ` Michael D Kinney
2024-10-21 19:42 ` Pedro Falcato
2024-10-21 20:05 ` Oliver Smith-Denny
2024-10-21 20:21 ` Pedro Falcato
2024-10-21 20:26 ` Oliver Smith-Denny
2024-10-21 20:35 ` Michael D Kinney
2024-10-21 20:37 ` Oliver Smith-Denny [this message]
2024-10-21 21:04 ` Michael D Kinney
2024-10-21 21:11 ` Pedro Falcato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d45782d-26a8-45da-bbec-98715f1bb436@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox