From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8F081AC1B72 for ; Mon, 21 Oct 2024 20:38:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YJOWVff3xTJowxLpLAnBJhC9/lu30x7YiTmmA1qyg6w=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240830; t=1729543080; v=1; x=1729802279; b=haFrgf/JKjUpyPq0T3OY30KZPeFLtwFHozxVt5fL9lY7+IHH0U+jv9mo9scJ4GuO82I6N4cY qP/Kz91NoS4ah38/kPpn39akq+iiV87PEtfaTitB7tJR5VEoRCP2Q3MtFavNC8e771B3PV/wdWe LKb6Kb7vIyYj/DKjTgaZYqYSlGkuv5+L3YpI6RXVQFsDQFeh+PcsBifzDl7CIEcl3s7jw77TBNp NuIXDbOND45YMR8ljS5NZHUGgZExJtxRjF/mqhbJ4wbr45NHSPTL1vXL4ECWMo+cbdnFbeNIXxA 1wFAsR0SSogoAWEUChreK5A4Ydgt6pojYN/pGW7qFtNjA== X-Received: by 127.0.0.2 with SMTP id Tv8JYY7687511xQwO1WeIwIP; Mon, 21 Oct 2024 13:37:59 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.2794.1729543078588924669 for ; Mon, 21 Oct 2024 13:37:58 -0700 X-Received: from [10.137.194.171] (unknown [131.107.159.43]) by linux.microsoft.com (Postfix) with ESMTPSA id D9097210DA22; Mon, 21 Oct 2024 13:37:57 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D9097210DA22 Message-ID: <5d45782d-26a8-45da-bbec-98715f1bb436@linux.microsoft.com> Date: Mon, 21 Oct 2024 13:37:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC` To: "Kinney, Michael D" , "devel@edk2.groups.io" , "pedro.falcato@gmail.com" Cc: "rebecca@bsdio.com" References: <20241011012040.274642-1-rebecca@bsdio.com> <591659ac-1d4a-43bd-b953-1032e5a7b8b0@linux.microsoft.com> <5a0d2a4f-a423-4ef3-a07b-18e69e7d1241@linux.microsoft.com> From: "Oliver Smith-Denny" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 21 Oct 2024 13:37:58 -0700 Resent-From: osde@linux.microsoft.com Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: yqI4T54pyxobtYIWL28mSXKax7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b="haFrgf/J"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/21/2024 1:35 PM, Kinney, Michael D wrote: > Would it help if code was modified to completely remove the use of > static in local variables and enforce that going forward and limit > use of static to functions and global variables? >=20 We'd have to test further, but I believe that would allow Pedro's scheme of simply `#define static ` to work. I ran a quick godbolt test and it seems MSVC is also okay with that. Oliver -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120642): https://edk2.groups.io/g/devel/message/120642 Mute This Topic: https://groups.io/mt/108941574/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-