From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web12.800.1602002800087480866 for <devel@edk2.groups.io>; Tue, 06 Oct 2020 09:46:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hkse9G5Y; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602002799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HWdp/5w1SZvBl/DvAiyTS+lcAgE6mdU3byu0EPepnxg=; b=hkse9G5YkJimXtA0KDBp+bDZe0Wu/RClVf/1mnV0ws/4TTAK6pcnsAO3eZGfHY4T4zPZuh tdxbcXrOF9eZY+59nBS6Yj3Cq6n7H4omiPvzNOFrnKg3QT1mtNxF4ddLZKkmevbTp/kreT org2WLL7Y7xP/zZHmxsqpyHmA/ryeFo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-97-pId6FrjNNr-Gj_8Q7RDAgQ-1; Tue, 06 Oct 2020 12:46:37 -0400 X-MC-Unique: pId6FrjNNr-Gj_8Q7RDAgQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7E02018C35A2; Tue, 6 Oct 2020 16:46:35 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-197.ams2.redhat.com [10.36.113.197]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0950819D7D; Tue, 6 Oct 2020 16:46:33 +0000 (UTC) Subject: Re: [EXTERNAL] RE: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg. To: Leif Lindholm <leif@nuviainc.com>, "Chang, Abner (HPS SW/FW Technologist)" <abner.chang@hpe.com> Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Wang, Nickle (HPS SW)" <nickle.wang@hpe.com>, Andrew Fish <afish@apple.com>, Michael D Kinney <michael.d.kinney@intel.com> References: <20201006104804.14724-1-abner.chang@hpe.com> <20201006104804.14724-2-abner.chang@hpe.com> <20201006143659.GP5623@vanye> <CS1PR8401MB1144F539387414DB96DAC081FF0D0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM> <CALDovBsTwiubuNTjSxv4NmS0xvWQX0biGRPBeN7LYwCx49JBTQ@mail.gmail.com> From: "Laszlo Ersek" <lersek@redhat.com> Message-ID: <5d4947d4-47bc-8055-d74e-4caa3ad8f9d8@redhat.com> Date: Tue, 6 Oct 2020 18:46:33 +0200 MIME-Version: 1.0 In-Reply-To: <CALDovBsTwiubuNTjSxv4NmS0xvWQX0biGRPBeN7LYwCx49JBTQ@mail.gmail.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/06/20 18:29, Leif Lindholm wrote: > Hi Abner, > > On Tue, Oct 6, 2020 at 5:20 PM Chang, Abner (HPS SW/FW Technologist) < > abner.chang@hpe.com> wrote: >>>> diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc new >>>> file mode 100644 index 0000000000..d5c65f68c3 >>>> --- /dev/null >>>> +++ b/RedfishPkg/RedfishPkg.dsc >>>> @@ -0,0 +1,40 @@ >>>> +## @file >>>> +# Redfish Package >>>> +# >>>> +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> # >>>> +(C) Copyright 2020 Hewlett-Packard Enterprise Development LP. >>>> +# >>>> +# SPDX-License-Identifier: BSD-2-Clause-Patent >>>> +# >>>> +## >>>> + >>>> +[Defines] >>>> + PLATFORM_NAME = RedfishPkg >>>> + PLATFORM_GUID = > c4352870-5232-11e7-9522-005056c00008 >>>> + PLATFORM_VERSION = 1.0 >>>> + DSC_SPECIFICATION = 0x0001001c >>>> + OUTPUT_DIRECTORY = Build/RedfishPkg >>>> + SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64|RISCV64 >>>> + BUILD_TARGETS = DEBUG|RELEASE >>> >>> v3 included NOOPT here. That was the version Laszlo gave his R-b for. >>> >>> v4 cover letter does mention NOOPT being removed, but I can see no >>> conversation in which this is discussed. What have I missed? >> >> No Leif, you did miss nothing. There was some Q/A conversations between > Bret and me about the build target of CI. > > This should really be referenced in the cover letter. > >> We would like to keep NO-TARGET for the non-build CI test but remove > NOOPT for now because we do not have >> the host-based unit test at the moment. We would like to add NOOPT back > once we have the corresponding unit test on RedfishPkg. > > Right, but dropping it from the .dsc BUILD_TARGETS is not required for that. > And it's not clear to me that Laszlo noticed this change. I missed it. The v4 blurb said, "Note for v4: NOOPT is removed from RedfishPkg.dsc [...]", and then I wrote in my v4 patch#1 response, "According to the v4 blurb, this patch has not undergone any changes since v3". So I clearly missed the actual meaning of the blurb. Sorry about that. I guess I'm more used to patch-granularity changelogs. Also I believe I didn't expect this series to reach v5, so I didn't do my usual thing where I apply every version of a patch set separately on a local topic branch, and then do incremental reviews with git-range-diff. So it's my fault. A better (patch-granularity) changelog might have mitigated my mistake, perhaps. (BTW I've not been CC'd on any version of the blurb.) Thanks Laszlo