From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3BE4FAC0F78 for ; Fri, 29 Sep 2023 15:06:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=xn5IMwrJmtFN4G5cE7xtX8RV9Dz6xs8wrso8iJC5Niw=; c=relaxed/simple; d=groups.io; h=Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696000008; v=1; b=Z7LneX8n40/1vBDPIFOxyka2b4n561R32gQn1u3ZZFKxNzdV+1OuVu0b05tgwTbMZN4kYIlN CYy6t/grazDMLS2qbu9x80I57FNWXpYiWQtV8gzQDoB7ekG1TCeBA7I32AZBHqF/8YiMbMYwf6x Q2BgUmkDE8fsI0b1xD63YLak= X-Received: by 127.0.0.2 with SMTP id ZUgyYY7687511x0U0jCW3wdo; Fri, 29 Sep 2023 08:06:48 -0700 X-Received: from EUR02-AM0-obe.outbound.protection.outlook.com (EUR02-AM0-obe.outbound.protection.outlook.com [40.107.247.65]) by mx.groups.io with SMTP id smtpd.web10.19991.1696000007577944554 for ; Fri, 29 Sep 2023 08:06:48 -0700 X-Received: from DU2PR04CA0201.eurprd04.prod.outlook.com (2603:10a6:10:28d::26) by AS8PR08MB8184.eurprd08.prod.outlook.com (2603:10a6:20b:561::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.21; Fri, 29 Sep 2023 15:06:43 +0000 X-Received: from DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28d:cafe::49) by DU2PR04CA0201.outlook.office365.com (2603:10a6:10:28d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.24 via Frontend Transport; Fri, 29 Sep 2023 15:06:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT011.mail.protection.outlook.com (100.127.142.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.17 via Frontend Transport; Fri, 29 Sep 2023 15:06:43 +0000 X-Received: ("Tessian outbound ab4fc72d2cd4:v211"); Fri, 29 Sep 2023 15:06:43 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b3620987774dc5e4 X-CR-MTA-TID: 64aa7808 X-Received: from eb04c1e43979.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 03634F6F-987F-43C6-8B9B-D3F6DBE1AAA0.1; Fri, 29 Sep 2023 15:06:35 +0000 X-Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id eb04c1e43979.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 29 Sep 2023 15:06:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CH8/ykeRF+UJTdWsR52RM06vAgZ9RjOMlDotOfesHh4quOhNu+eu4+BbUaY0ibdZD85lrwmo994R8rVTouX2CkeRDBedzlEfSrmWWJk6Q+cNvYQ00fo4cMi/JfNuRdbis50ThuB/qUrPA9eqnmlPOC+V+P1YtsAkZXBpz7jfHGaf4WRgj/x/K933/t1UQJSafKswBcavZewrE6LMSrBdPi6jJOotWJc8bII/lPtCgSKPtGZy8HrxyGLSpvDovMrOc9bv2mGQG2qULL2cf5YzUx7jJ6dXQeQd/mIZciVGrkX82ugTkkLL/uzUlZAe1TYRXKP9vuXR5FNr9AFIvDygZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WDWQU3tMDV4mCiWgf7NKQI+R3zdVuIlg34JjEdFJhkk=; b=I0dswkHjfizs6bXgV8mMZL0Cq0zBIEo5Wo4r2tOi/OhBEkr7MvcxXLW1sodLHSVgpq48qMMp36076PzH2hJpiEPWw1CL+HVBlLseEdIUqYQUsKsbSs6iuap30DAI+JFYdm4so7bfgEyTaMhEYv0G/B35k1rqu4g1RlV+mqAqfI94jTRHB4dR5xEIG2x13YTJ+zhs2CCIBXkJqVIO+1Qwk2f5MDpWMDNIrdKKL6BQVn6n2HueweAp6jt80WOU1hBV6RJX50wMk/Vm43ghqCS6DbwBTG7o9photM8OZW9VtESsYR6b0cGPvQhgl9Yi34WSJWJcA3R3SOnuwo+JotM7Ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DB3PR08MB8795.eurprd08.prod.outlook.com (2603:10a6:10:432::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.26; Fri, 29 Sep 2023 15:06:31 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::ac37:4594:ab86:59ce]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::ac37:4594:ab86:59ce%4]) with mapi id 15.20.6838.024; Fri, 29 Sep 2023 15:06:30 +0000 Message-ID: <5d4ec8ee-5ec5-8a79-ea72-1910d2c5ed5a@arm.com> Date: Fri, 29 Sep 2023 16:06:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [edk2-devel] [PATCH v2 1/5] MdePkg/BaseLib: fix comments in ARM* SetJump/LongJump implementations To: Leif Lindholm , devel@edk2.groups.io Cc: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Ard Biesheuvel , "nd@arm.com" References: <20230926171523.368706-1-quic_llindhol@quicinc.com> <20230926171523.368706-2-quic_llindhol@quicinc.com> From: "Sami Mujawar" In-Reply-To: <20230926171523.368706-2-quic_llindhol@quicinc.com> X-ClientProxiedBy: LO4P123CA0169.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18a::12) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DB3PR08MB8795:EE_|DBAEUR03FT011:EE_|AS8PR08MB8184:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ef95176-9b72-4a55-0564-08dbc0fdb105 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0v2I4lHMG/+wAyOLVuMXEtGj0uRx5hHtCANpBz0urYkauLgvESOzurRWN1MhLodOymLAmQen8NqZ3pr2zb5tD2h5mqjss5Nq2Etju4t6qxYOAYWChmzpgH6h7czbIMAscbyzhobhpA6k3s9HWSRUlmX3w3c/fWocMY0LFZG/jCBSPU4vtO+6lnDu+jKy8LgdePM0THWidOVivATlPYAZ4/hVR8IRKCE3bWeHnEQn5DZpqIK7GskP1dSz3be+PKDJB6OTnquYYN6WhX5ew4Wf4XieQmDCbAjMGr2g07cZuxbcWZqqn1GgYwkcnm6UkFRUyyUitkj0fIXLIwujcJA6c9eal4SthD/BhY0P3qCgCswF08q7eQRIb0o7xdX4I/d+DjZv/ntDvC/gBmkLHinquNP91vg+l3dXx4FAJjtYCDFRvAFLZYELHbf49qF6gD/xZpbdL+vRxWE/M2VOYii+X95IROdaiw/oANEJMiRnSa5Q1XqCn9Lqx4M8CoURTC/6yvfcb/OdEz49G2tuK1OaWFnvJn3fyTqjyl801ajZjdTs2eNQcnKU0Lu0KmdOxooMp3OC29eVOqeexLewU53Cep9F0KOVVWv2fnZvR08945h+2EO5tvKssRtCgLdAe2yD+DBSGi0C+j1VzOSB6/kw4g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(376002)(396003)(346002)(39850400004)(136003)(230922051799003)(1800799009)(451199024)(64100799003)(186009)(6486002)(19627235002)(4326008)(8936002)(8676002)(478600001)(38100700002)(66476007)(66556008)(6512007)(2616005)(41300700001)(316002)(6506007)(53546011)(66946007)(26005)(36756003)(2906002)(5660300002)(44832011)(54906003)(83380400001)(31686004)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB8795 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5f8c5329-378f-477b-08a3-08dbc0fda982 X-Microsoft-Antispam-Message-Info: 8Nz7ELV6CCcRNOncDW1YzNiq7ayBtKvJgV3VGvhGH6sBvNt8bhicHZgwXUtFmW7aql5dXrxy9fYup4c2lLFa/faHCBM0UEedSppJRy+7W8xxFuCM1X7qraGAbMo1Vz/SS8PW+ZWE2sZ0cjTs8Pi1S533l3yaVt3PQmr6jgUB/yNy8SoIvGftDLg8zjf2zeVHEAWvMcnMfgkGa2pVyjmWz2bJeR+A6EuUoqAyIgMcC89sheGpNRcXWrihoiehHoRtCehBa2y4dUIqu3gVGAtt4vuBjgPsAw0e0akY47CQcQAk7rlubAifHE9NmBWR0QNbZrPCllMx0/Ghbzdqk1lCI83W3UweMatS2b8axXpSqp9UjcGoyvZonJrUlyZdTse//+8K2y75cj6YETx2zfqnPwz4XaNtBtwkN+hjkzHEwO8Qkj4FdP8YkZFI01TTdI6+sigu9RmHcvbJafwsSmvD7qRKUyicJZ//fPJcu9EQ4XCC98Y1j6ZS4t9+PaLeH5SVb1gVXoSGPeb/flE8FCscb4YLtv//c1JnQyYdcDqlSEGx1j9eRdBv8qtBenqeZ8I1FBXYi0qOJQxU+CnuRVPPKBeI73nzmyzCzKSKSVjukQBZmLGYY6xqihVRITchKnmlscVnBxIV9HZHzIBWUyDLZ/HyDSSNyPO+Qy0KfMB7/MGutVSaN6bHz14cQMDoq+kdgVTAXq8kKjKJjvsXFxBj7NgSKG2SLWUVcYgSlZlChIpUpzE81N3sFSRGmwEKy3dfM6RlTxI6qAGnae39AgjlWQ== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2023 15:06:43.2056 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4ef95176-9b72-4a55-0564-08dbc0fdb105 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8184 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 1yRtA87EGwkQ3d8SteYX0rA4x7686176AA= Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Z7LneX8n; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Leif, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 26/09/2023 06:15 pm, Leif Lindholm wrote: > Drop redundant comment about IPF (clearly copied across from now deleted > code). > > Also change > "Instead is resumes execution" -> > "Instead it resumes execution" > > Signed-off-by: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > --- > MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S | 3 +-- > MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 3 +-- > MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S | 3 +-- > MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 3 +-- > 4 files changed, 4 insertions(+), 8 deletions(-) > > diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S b/MdePkg/Li= brary/BaseLib/AArch64/SetJumpLongJump.S > index 0d902d94d31c..78db9b3d1e78 100644 > --- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S > +++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S > @@ -33,7 +33,6 @@ GCC_ASM_EXPORT(InternalLongJump) > # value to be returned by SetJump(). > # > # If JumpBuffer is NULL, then ASSERT(). > -# For IPF CPUs, if JumpBuffer is not aligned on a 16-byte boundary, the= n ASSERT(). > # > # @param JumpBuffer A pointer to CPU context buffer. > # > @@ -62,7 +61,7 @@ ASM_PFX(SetJump): > # > # Restores the CPU context from the buffer specified by JumpBuffer. > # This function never returns to the caller. > -# Instead is resumes execution based on the state of JumpBuffer. > +# Instead it resumes execution based on the state of JumpBuffer. > # > # @param JumpBuffer A pointer to CPU context buffer. > # @param Value The value to return when the SetJump() context= is restored. > diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm b/MdePkg/= Library/BaseLib/AArch64/SetJumpLongJump.asm > index df70f298998e..d8b267addc1a 100644 > --- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm > +++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm > @@ -32,7 +32,6 @@ > ; value to be returned by SetJump(). > ; > ; If JumpBuffer is NULL, then ASSERT(). > -; For IPF CPUs, if JumpBuffer is not aligned on a 16-byte boundary, the= n ASSERT(). > ; > ; @param JumpBuffer A pointer to CPU context buffer. > ; > @@ -60,7 +59,7 @@ SetJump > ; > ; Restores the CPU context from the buffer specified by JumpBuffer. > ; This function never returns to the caller. > -; Instead is resumes execution based on the state of JumpBuffer. > +; Instead it resumes execution based on the state of JumpBuffer. > ; > ; @param JumpBuffer A pointer to CPU context buffer. > ; @param Value The value to return when the SetJump() context= is restored. > diff --git a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S b/MdePkg/Librar= y/BaseLib/Arm/SetJumpLongJump.S > index 82d94faf61e9..e4c1946a28ff 100644 > --- a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S > +++ b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S > @@ -19,7 +19,6 @@ GCC_ASM_EXPORT(InternalLongJump) > # value to be returned by SetJump(). > # > # If JumpBuffer is NULL, then ASSERT(). > -# For IPF CPUs, if JumpBuffer is not aligned on a 16-byte boundary, the= n ASSERT(). > # > # @param JumpBuffer A pointer to CPU context buffer. > # > @@ -42,7 +41,7 @@ ASM_PFX(SetJump): > # > # Restores the CPU context from the buffer specified by JumpBuffer. > # This function never returns to the caller. > -# Instead is resumes execution based on the state of JumpBuffer. > +# Instead it resumes execution based on the state of JumpBuffer. > # > # @param JumpBuffer A pointer to CPU context buffer. > # @param Value The value to return when the SetJump() context= is restored. > diff --git a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm b/MdePkg/Libr= ary/BaseLib/Arm/SetJumpLongJump.asm > index 936f722be60f..e1eff758f7ab 100644 > --- a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm > +++ b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm > @@ -19,7 +19,6 @@ > ; value to be returned by SetJump(). > ; > ; If JumpBuffer is NULL, then ASSERT(). > -; For IPF CPUs, if JumpBuffer is not aligned on a 16-byte boundary, the= n ASSERT(). > ; > ; @param JumpBuffer A pointer to CPU context buffer. > ; > @@ -42,7 +41,7 @@ SetJump > ; > ; Restores the CPU context from the buffer specified by JumpBuffer. > ; This function never returns to the caller. > -; Instead is resumes execution based on the state of JumpBuffer. > +; Instead it resumes execution based on the state of JumpBuffer. > ; > ; @param JumpBuffer A pointer to CPU context buffer. > ; @param Value The value to return when the SetJump() context= is restored. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109200): https://edk2.groups.io/g/devel/message/109200 Mute This Topic: https://groups.io/mt/101600801/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-