From: "Jake Garver" <jake@nvidia.com>
To: <devel@edk2.groups.io>, <jbrasen@nvidia.com>,
<ashishsingha@nvidia.com>, <pedro.falcato@gmail.com>
Cc: Jake Garver <jake@nvidia.com>
Subject: [PATCH] Features/Ext4Pkg: Modularize Ext4 DSC/FDF files
Date: Tue, 25 Jan 2022 09:12:34 -0500 [thread overview]
Message-ID: <5d55ef7504d9c460d7fcdda26f890df8feeb8972.1643119699.git.jake@nvidia.com> (raw)
This change modularizes the Ext4 DSC/FDF files following the model used
in edk2/NetworkPkg.
A platform DSC can include Ext4 using "!include Features/Ext4.dsc.inc".
Ext.dsc.inc includes all the required information to enable Ext4
features. Similarly, "!include Features/Ext4.fdf.inc" would be used in
the platform FDF.
The Ext4 feature is enabled by default, but could be disabled at build
time using:
BLD_*_EXT4_ENABLE=FALSE
Signed-off-by: Jake Garver <jake@nvidia.com>
---
Features/Ext4Pkg/Ext4.dsc.inc | 16 ++++++++++++++++
Features/Ext4Pkg/Ext4.fdf.inc | 11 +++++++++++
Features/Ext4Pkg/Ext4Components.dsc.inc | 14 ++++++++++++++
Features/Ext4Pkg/Ext4Defines.dsc.inc | 14 ++++++++++++++
Features/Ext4Pkg/Ext4Libs.dsc.inc | 11 +++++++++++
5 files changed, 66 insertions(+)
create mode 100644 Features/Ext4Pkg/Ext4.dsc.inc
create mode 100644 Features/Ext4Pkg/Ext4.fdf.inc
create mode 100644 Features/Ext4Pkg/Ext4Components.dsc.inc
create mode 100644 Features/Ext4Pkg/Ext4Defines.dsc.inc
create mode 100644 Features/Ext4Pkg/Ext4Libs.dsc.inc
diff --git a/Features/Ext4Pkg/Ext4.dsc.inc b/Features/Ext4Pkg/Ext4.dsc.inc
new file mode 100644
index 0000000000..b560b9acbb
--- /dev/null
+++ b/Features/Ext4Pkg/Ext4.dsc.inc
@@ -0,0 +1,16 @@
+## @file
+# Ext4 DSC include file for Platform DSC
+#
+# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+[Defines]
+!include Features/Ext4Pkg/Ext4Defines.dsc.inc
+
+[LibraryClasses]
+!include Features/Ext4Pkg/Ext4Libs.dsc.inc
+
+[Components.common]
+!include Features/Ext4Pkg/Ext4Components.dsc.inc
diff --git a/Features/Ext4Pkg/Ext4.fdf.inc b/Features/Ext4Pkg/Ext4.fdf.inc
new file mode 100644
index 0000000000..fb36070860
--- /dev/null
+++ b/Features/Ext4Pkg/Ext4.fdf.inc
@@ -0,0 +1,11 @@
+## @file
+# Ext4 FDF include file for All Architectures.
+#
+# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+!if $(EXT4_ENABLE) == TRUE
+ INF Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf
+!endif
diff --git a/Features/Ext4Pkg/Ext4Components.dsc.inc b/Features/Ext4Pkg/Ext4Components.dsc.inc
new file mode 100644
index 0000000000..34401272a0
--- /dev/null
+++ b/Features/Ext4Pkg/Ext4Components.dsc.inc
@@ -0,0 +1,14 @@
+## @file
+# Ext4 DSC include file for [Components] section of all Architectures.
+#
+# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+!if $(EXT4_ENABLE) == TRUE
+ Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf {
+ <PcdsFixedAtBuild>
+ gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80000007
+ }
+!endif
diff --git a/Features/Ext4Pkg/Ext4Defines.dsc.inc b/Features/Ext4Pkg/Ext4Defines.dsc.inc
new file mode 100644
index 0000000000..b02eac59cf
--- /dev/null
+++ b/Features/Ext4Pkg/Ext4Defines.dsc.inc
@@ -0,0 +1,14 @@
+## @file
+# Ext4 DSC include file for [Defines] section of all Architectures.
+#
+# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+!ifndef EXT4_ENABLE
+ #
+ # This flag is to enable or disable the ext4 feature.
+ #
+ DEFINE EXT4_ENABLE = TRUE
+!endif
diff --git a/Features/Ext4Pkg/Ext4Libs.dsc.inc b/Features/Ext4Pkg/Ext4Libs.dsc.inc
new file mode 100644
index 0000000000..078183e0cc
--- /dev/null
+++ b/Features/Ext4Pkg/Ext4Libs.dsc.inc
@@ -0,0 +1,11 @@
+## @file
+# Ext4 DSC include file for [LibraryClasses] section of all Architectures.
+#
+# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+!if $(EXT4_ENABLE) == TRUE
+ BaseUcs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
+!endif
--
2.17.1
next reply other threads:[~2022-01-25 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 14:12 Jake Garver [this message]
2022-01-28 9:12 ` [PATCH] Features/Ext4Pkg: Modularize Ext4 DSC/FDF files Pedro Falcato
2022-02-02 17:31 ` Pedro Falcato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d55ef7504d9c460d7fcdda26f890df8feeb8972.1643119699.git.jake@nvidia.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox