From: "Dov Murik" <dovmurik@linux.ibm.com>
To: Ard Biesheuvel <ardb@kernel.org>, Tom Lendacky <thomas.lendacky@amd.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
Tobin Feldman-Fitzthum <tobin@linux.ibm.com>,
Tobin Feldman-Fitzthum <tobin@ibm.com>,
Jim Cadden <jcadden@ibm.com>,
James Bottomley <jejb@linux.ibm.com>,
Hubertus Franke <frankeh@us.ibm.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jordan Justen <jordan.l.justen@intel.com>,
Ashish Kalra <ashish.kalra@amd.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Erdem Aktas <erdemaktas@google.com>,
Jiewen Yao <jiewen.yao@intel.com>, Min Xu <min.m.xu@intel.com>,
Leif Lindholm <leif@nuviainc.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Dov Murik <dovmurik@linux.ibm.com>
Subject: Re: [PATCH v3 00/11] Measured SEV boot with kernel/initrd/cmdline
Date: Wed, 21 Jul 2021 10:55:10 +0300 [thread overview]
Message-ID: <5d5ae802-95db-4e0e-f81d-fd0552b67b53@linux.ibm.com> (raw)
In-Reply-To: <CAMj1kXEER74w0NcVXjAkSnxcTpXp4tuTOTGvwvbT0W+75ps_Ow@mail.gmail.com>
On 20/07/2021 20:27, Ard Biesheuvel wrote:
> On Tue, 20 Jul 2021 at 19:22, Tom Lendacky <thomas.lendacky@amd.com> wrote:
>>
>> On 7/20/21 3:03 AM, Dov Murik wrote:
>>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3457
>>
>> I believe the convention is that this line be in the individual patch
>> commit messages just like this (i.e. with the BZ: tag and the first line),
>> not as a Ref: tag at the end of the commit message.
>>
>> I'll let Ard decide on that, though.
>>
>
> Using Ref: in the signoff section of the patch is perfectly fine with me.
>
> I'll go over this series on Thursday and merge it if everything looks ok.
Please hold off - I think I found a bug in patch 10 (parsing of the SEV
hashes GUIDed structure).
I'll update with my findings soon.
>
> Thanks all for the review.
Thank you Tom and Brijesh for the review -- you helped improve our
contribution.
-Dov
prev parent reply other threads:[~2021-07-21 7:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 8:03 [PATCH v3 00/11] Measured SEV boot with kernel/initrd/cmdline Dov Murik
2021-07-20 8:03 ` [PATCH v3 01/11] OvmfPkg/AmdSev/SecretDxe: fix header comment to generic naming Dov Murik
2021-07-20 8:03 ` [PATCH v3 02/11] OvmfPkg/AmdSev: use GenericQemuLoadImageLib in AmdSev builds Dov Murik
2021-07-20 8:03 ` [PATCH v3 03/11] OvmfPkg: PlatformBootManagerLibGrub: Allow executing kernel via fw_cfg Dov Murik
2021-07-20 8:03 ` [PATCH v3 04/11] OvmfPkg: add library class BlobVerifierLib with null implementation Dov Murik
2021-07-20 16:18 ` Lendacky, Thomas
2021-07-20 8:03 ` [PATCH v3 05/11] OvmfPkg: add BlobVerifierLibNull to DSC Dov Murik
2021-07-20 16:20 ` Lendacky, Thomas
2021-07-20 8:03 ` [PATCH v3 06/11] ArmVirtPkg: " Dov Murik
2021-07-20 8:03 ` [PATCH v3 07/11] OvmfPkg/QemuKernelLoaderFsDxe: call VerifyBlob after fetch from fw_cfg Dov Murik
2021-07-20 16:24 ` Lendacky, Thomas
2021-07-20 8:03 ` [PATCH v3 08/11] OvmfPkg/AmdSev/SecretPei: build hob for full page Dov Murik
2021-07-20 16:24 ` Lendacky, Thomas
2021-07-20 16:44 ` Brijesh Singh
2021-07-20 8:03 ` [PATCH v3 09/11] OvmfPkg/AmdSev: reserve MEMFD space for for firmware config hashes Dov Murik
2021-07-20 16:45 ` Brijesh Singh
2021-07-20 8:04 ` [PATCH v3 10/11] OvmfPkg: add BlobVerifierLibSevHashes Dov Murik
2021-07-20 17:18 ` Lendacky, Thomas
2021-07-20 18:24 ` Brijesh Singh
2021-07-21 9:29 ` Dov Murik
2021-07-20 8:04 ` [PATCH v3 11/11] OvmfPkg/AmdSev: Enforce hash verification of kernel blobs Dov Murik
2021-07-20 17:19 ` Lendacky, Thomas
2021-07-20 17:22 ` [PATCH v3 00/11] Measured SEV boot with kernel/initrd/cmdline Lendacky, Thomas
2021-07-20 17:27 ` Ard Biesheuvel
2021-07-21 7:55 ` Dov Murik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d5ae802-95db-4e0e-f81d-fd0552b67b53@linux.ibm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox