From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mx.groups.io with SMTP id smtpd.web12.1372.1626854124704934675 for ; Wed, 21 Jul 2021 00:55:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=JXjlzQfu; spf=pass (domain: linux.ibm.com, ip: 148.163.156.1, mailfrom: dovmurik@linux.ibm.com) Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16L7Wpm4143643; Wed, 21 Jul 2021 03:55:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=yennJq6l0RvjWNpK3VAClZneGvTMlFnjNJvsGS5h5tI=; b=JXjlzQfuIJ/GB98kp7kgvfIgDA3GG1kKF6QV9X/KaXalvte+/PkckdYm17OuDBon4A9v FkeYA64o1SHFBfg3yZtO6SDeLh3LQe1Ww3IiUjkYDbzutaPTRAbl1W6CehA1sR/g8rWc YdrVVx0QYeusGzZFqNEBfv9wX5ga6SBALTkALWs6BwL4esIR5BBpgztq0cW9aN0FpyMH QSCDxVAtV6QzcmoDcX9beYNFfVFv3a9OxKb3aYqTM6qHZOZsnoCRhOojp/8vAv88ElSq cJibciWJ4W5QN/8X8P9AonNmHT4Nu1l73GTWur1iafp92nX5EPzEt2CSZLD8hrb3KWvn Ig== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 39xf4sgnq2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Jul 2021 03:55:19 -0400 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 16L7Y0V5146657; Wed, 21 Jul 2021 03:55:18 -0400 Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com with ESMTP id 39xf4sgnph-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Jul 2021 03:55:18 -0400 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 16L7lUIA005929; Wed, 21 Jul 2021 07:55:17 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma03wdc.us.ibm.com with ESMTP id 39vqdv36eh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Jul 2021 07:55:17 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 16L7tFdo17891598 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Jul 2021 07:55:15 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C02E5AC089; Wed, 21 Jul 2021 07:55:15 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4611DAC060; Wed, 21 Jul 2021 07:55:12 +0000 (GMT) Received: from [9.160.123.143] (unknown [9.160.123.143]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 21 Jul 2021 07:55:12 +0000 (GMT) Subject: Re: [PATCH v3 00/11] Measured SEV boot with kernel/initrd/cmdline To: Ard Biesheuvel , Tom Lendacky Cc: edk2-devel-groups-io , Tobin Feldman-Fitzthum , Tobin Feldman-Fitzthum , Jim Cadden , James Bottomley , Hubertus Franke , Ard Biesheuvel , Jordan Justen , Ashish Kalra , Brijesh Singh , Erdem Aktas , Jiewen Yao , Min Xu , Leif Lindholm , Sami Mujawar , Dov Murik References: <20210720080401.3662854-1-dovmurik@linux.ibm.com> From: "Dov Murik" Message-ID: <5d5ae802-95db-4e0e-f81d-fd0552b67b53@linux.ibm.com> Date: Wed, 21 Jul 2021 10:55:10 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: aH3UwHBxrliu5tqpCCxg7OFdO1-XSoo2 X-Proofpoint-GUID: YnAXdYGlHqcuZWswezrp_BQctmy8kgJ7 X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-07-21_04:2021-07-21,2021-07-21 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 impostorscore=0 mlxscore=0 mlxlogscore=999 lowpriorityscore=0 phishscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107210040 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 20/07/2021 20:27, Ard Biesheuvel wrote: > On Tue, 20 Jul 2021 at 19:22, Tom Lendacky wrote: >> >> On 7/20/21 3:03 AM, Dov Murik wrote: >>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3457 >> >> I believe the convention is that this line be in the individual patch >> commit messages just like this (i.e. with the BZ: tag and the first line), >> not as a Ref: tag at the end of the commit message. >> >> I'll let Ard decide on that, though. >> > > Using Ref: in the signoff section of the patch is perfectly fine with me. > > I'll go over this series on Thursday and merge it if everything looks ok. Please hold off - I think I found a bug in patch 10 (parsing of the SEV hashes GUIDed structure). I'll update with my findings soon. > > Thanks all for the review. Thank you Tom and Brijesh for the review -- you helped improve our contribution. -Dov