Re: [edk2-devel] [edk2-platforms][PATCH 0/3] Silicon/Broadcom/Bcm283x: RNG improvements

["Pete Batard" <pete@akeo.ie>]

Hi Ard,


On 2019.12.02 16:03, Ard Biesheuvel wrote:
> On Mon, 2 Dec 2019 at 11:55, Pete Batard <pete@akeo.ie> wrote:
>>
>> This patch series is targetted at adding support for the Bcm2838
>> Random Generator Driver, so that it can be used on the Raspberry
>> Pi 4.
>>
>> Pete Batard (3):
>>    Silicon/Broadcom/Bcm283x: Rename Bcm2835 RNG driver
>>    Silicon/Broadcom/Bcm283x: Move Bcm2835 RNG defines to their own header
>>    Silicon/Broadcom/Bcm283x: Add Bcm2838 RNG driver
>>
> 
> Thanks for respinning this. For the series,
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> 
> I have pushed all three patches,

Thanks.

> but going forward, can we keep
> patches for new hardware together with patches that add the platform?

Yeah, I thought about only sending 3/3 until after we had the basics of 
the RPi4 platform in, but didn't see it as that big a deal to just send 
this whole thing as a set, since it does make sense to have all the 
Broadcom RNG related change grouped.

In case this is your concern, it's always been my plan to only start 
sending PCIe/xHCI related patches until after we have some of the basic 
platform in, so you won't be seeing any new Pi4-only changes at this 
stage, without them also being part of a set that allows testing.

Regards,

/Pete

> There is currently no way to build test the new driver introduced in
> #3.
> 
> Pushed as 8e75ee0c9653..d6b7f67e62da
> 
> 
> 
>>   Platform/RaspberryPi/RPi3/RPi3.dsc                                                      |   2 +-
>>   Platform/RaspberryPi/RPi3/RPi3.fdf                                                      |   2 +-
>>   Silicon/Broadcom/Bcm283x/Drivers/{RngDxe/RngDxe.c => Bcm2835RngDxe/Bcm2835RngDxe.c}     |  18 +-
>>   Silicon/Broadcom/Bcm283x/Drivers/{RngDxe/RngDxe.inf => Bcm2835RngDxe/Bcm2835RngDxe.inf} |   6 +-
>>   Silicon/Broadcom/Bcm283x/Drivers/Bcm2838RngDxe/Bcm2838RngDxe.c                          | 285 ++++++++++++++++++++
>>   Silicon/Broadcom/Bcm283x/Drivers/Bcm2838RngDxe/Bcm2838RngDxe.inf                        |  46 ++++
>>   Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2835Rng.h                          |  22 ++
>>   Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h                             |   9 -
>>   Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2838Rng.h                          |  30 +++
>>   9 files changed, 397 insertions(+), 23 deletions(-)
>>   rename Silicon/Broadcom/Bcm283x/Drivers/{RngDxe/RngDxe.c => Bcm2835RngDxe/Bcm2835RngDxe.c} (93%)
>>   rename Silicon/Broadcom/Bcm283x/Drivers/{RngDxe/RngDxe.inf => Bcm2835RngDxe/Bcm2835RngDxe.inf} (82%)
>>   create mode 100644 Silicon/Broadcom/Bcm283x/Drivers/Bcm2838RngDxe/Bcm2838RngDxe.c
>>   create mode 100644 Silicon/Broadcom/Bcm283x/Drivers/Bcm2838RngDxe/Bcm2838RngDxe.inf
>>   create mode 100644 Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2835Rng.h
>>   create mode 100644 Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2838Rng.h
>>
>> --
>> 2.21.0.windows.1
>>
> 
> 
>