Re: [PATCH edk2-platforms v4 2/2] Platform/HiKey: create 4 boot options

[Laszlo Ersek <lersek@redhat.com>]

On 04/23/18 08:22, Haojian Zhuang wrote:
> Create 4 predefined boot options for HiKey. They're
> "Boot from SD", "Grub", "Android Boot" and "Android Fastboot".
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
> ---
>  Platform/Hisilicon/HiKey/HiKey.dec             |   8 +-
>  Platform/Hisilicon/HiKey/HiKey.dsc             |   7 +
>  Platform/Hisilicon/HiKey/HiKeyDxe/HiKeyDxe.c   | 181 +++++++++++++++++++++++++
>  Platform/Hisilicon/HiKey/HiKeyDxe/HiKeyDxe.inf |  11 ++
>  4 files changed, 204 insertions(+), 3 deletions(-)

>From a quick skim, this looks very similar to patch #1.

I'm not familiar with the edk2-platforms tree. Ard and Leif might be
able to suggest a way to centralize this code between HiKey and HiKey960.

Thanks,
Laszlo