From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 99E5D220E8E1E
 for <edk2-devel@lists.01.org>; Mon, 23 Apr 2018 14:29:37 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com
 [10.11.54.5])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id D5847406C7BD;
 Mon, 23 Apr 2018 21:29:36 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-123.rdu2.redhat.com
 [10.10.120.123])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 2C15B7C4C;
 Mon, 23 Apr 2018 21:29:36 +0000 (UTC)
To: Haojian Zhuang <haojian.zhuang@linaro.org>, edk2-devel@lists.01.org
Cc: Leif Lindholm <leif.lindholm@linaro.org>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>
References: <1524464559-14549-1-git-send-email-haojian.zhuang@linaro.org>
 <1524464559-14549-3-git-send-email-haojian.zhuang@linaro.org>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <5d685c89-f7b5-c035-7191-46286f568974@redhat.com>
Date: Mon, 23 Apr 2018 23:29:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <1524464559-14549-3-git-send-email-haojian.zhuang@linaro.org>
X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.5]); Mon, 23 Apr 2018 21:29:36 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]);
 Mon, 23 Apr 2018 21:29:36 +0000 (UTC) for IP:'10.11.54.5'
 DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:''
Subject: Re: [PATCH edk2-platforms v4 2/2] Platform/HiKey: create 4 boot options
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Apr 2018 21:29:37 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 04/23/18 08:22, Haojian Zhuang wrote:
> Create 4 predefined boot options for HiKey. They're
> "Boot from SD", "Grub", "Android Boot" and "Android Fastboot".
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
> ---
>  Platform/Hisilicon/HiKey/HiKey.dec             |   8 +-
>  Platform/Hisilicon/HiKey/HiKey.dsc             |   7 +
>  Platform/Hisilicon/HiKey/HiKeyDxe/HiKeyDxe.c   | 181 +++++++++++++++++++++++++
>  Platform/Hisilicon/HiKey/HiKeyDxe/HiKeyDxe.inf |  11 ++
>  4 files changed, 204 insertions(+), 3 deletions(-)

>>From a quick skim, this looks very similar to patch #1.

I'm not familiar with the edk2-platforms tree. Ard and Leif might be
able to suggest a way to centralize this code between HiKey and HiKey960.

Thanks,
Laszlo