From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web09.3513.1662519944358567258
 for <devel@edk2.groups.io>;
 Tue, 06 Sep 2022 20:05:44 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=mUrmsk4A;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.195.228.134])
	by linux.microsoft.com (Postfix) with ESMTPSA id 788B1204A585;
	Tue,  6 Sep 2022 20:05:43 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 788B1204A585
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1662519943;
	bh=7kj/u5ZJCES80lrvIpyLZj7wfSAWv0U8HUyMsnNMlUY=;
	h=Date:Subject:From:To:Reply-To:References:In-Reply-To:From;
	b=mUrmsk4Am4iCA+NhmtSHo/5TqE6p6lx8aZ1lthv5iQFktgRAfIy0fv/K8+7zP62Wz
	 4Q+LAPwxtE4mH4vuDIrSbTCW/EsJtxIQBMPEV9KWaDgvbNQeSX8kVf3djuDykB8Uto
	 S96k7+e+yq1mkkZPOxqXdfhpHziVePdtAn1dBnxI=
Message-ID: <5d696986-9bcc-e320-b1e4-a1ae129131af@linux.microsoft.com>
Date: Tue, 6 Sep 2022 23:05:42 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [edk2-devel] [PATCH v3 2/8] FatPkg/FatPei: Remove extraneous debug message argument
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: Ray Ni <ray.ni@intel.com>, devel@edk2.groups.io
Reply-To: devel@edk2.groups.io, mikuback@linux.microsoft.com
References: <20220902222206.1509-1-mikuback@linux.microsoft.com>
 <17112B50E738A0A8.6506@groups.io>
In-Reply-To: <17112B50E738A0A8.6506@groups.io>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hello Ray,

Can you please review this patch?

FatPkg is the only package missing a review on the series.

Thanks,
Michael

On 9/2/2022 6:22 PM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> This debug macro should take one argument based on the number of
> print specifiers defined. However, two arguments are given.
> 
> It looks like the code may have been refactored such that the
> second argument was moved to a new print and this argument was
> not removed. In any case, it should not be there now.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   FatPkg/FatPei/Gpt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/FatPkg/FatPei/Gpt.c b/FatPkg/FatPei/Gpt.c
> index 0a1a25ceeff1..9e17ce88086f 100644
> --- a/FatPkg/FatPei/Gpt.c
> +++ b/FatPkg/FatPei/Gpt.c
> @@ -361,7 +361,7 @@ PartitionCheckGptEntryArray (
>   
>       PrivateData->BlockDeviceCount++;
>   
> -    DEBUG ((DEBUG_INFO, "Find GPT Partition [0x%lx", PartitionEntryBuffer[Index].StartingLBA, BlockDevPtr->LastBlock));
> +    DEBUG ((DEBUG_INFO, "Find GPT Partition [0x%lx", PartitionEntryBuffer[Index].StartingLBA));
>       DEBUG ((DEBUG_INFO, ", 0x%lx]\n", BlockDevPtr->LastBlock));
>       DEBUG ((DEBUG_INFO, "         BlockSize %x\n", BlockDevPtr->BlockSize));
>     }