From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out01.mta.xmission.com (out01.mta.xmission.com [166.70.13.231]) by mx.groups.io with SMTP id smtpd.web11.7546.1588081100639009145 for ; Tue, 28 Apr 2020 06:38:20 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: bsdio.com, ip: 166.70.13.231, mailfrom: rebecca@bsdio.com) Received: from in02.mta.xmission.com ([166.70.13.52]) by out01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTQRG-0001PO-U6; Tue, 28 Apr 2020 07:38:18 -0600 Received: from mta4.zcs.xmission.com ([166.70.13.68]) by in02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1jTQRG-0002CV-7W; Tue, 28 Apr 2020 07:38:18 -0600 Received: from localhost (localhost [127.0.0.1]) by mta4.zcs.xmission.com (Postfix) with ESMTP id 0060650063F; Tue, 28 Apr 2020 07:38:17 -0600 (MDT) X-Amavis-Modified: Mail body modified (using disclaimer) - mta4.zcs.xmission.com Received: from mta4.zcs.xmission.com ([127.0.0.1]) by localhost (mta4.zcs.xmission.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id TRMNNpFP70rn; Tue, 28 Apr 2020 07:38:17 -0600 (MDT) Received: from [10.0.10.120] (c-174-52-16-57.hsd1.ut.comcast.net [174.52.16.57]) by mta4.zcs.xmission.com (Postfix) with ESMTPSA id A27DA500484; Tue, 28 Apr 2020 07:38:17 -0600 (MDT) To: Laszlo Ersek , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , devel@edk2.groups.io Cc: Jordan Justen , Ard Biesheuvel References: <20200424221707.183492-1-rebecca@bsdio.com> <6969918a-0948-559e-7679-ba94e8f3bfd8@redhat.com> From: "Rebecca Cran" Message-ID: <5d7808b4-4b86-bc48-001b-ecd7eb746390@bsdio.com> Date: Tue, 28 Apr 2020 07:38:16 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: X-XM-SPF: eid=1jTQRG-0002CV-7W;;;mid=<5d7808b4-4b86-bc48-001b-ecd7eb746390@bsdio.com>;;;hst=in02.mta.xmission.com;;;ip=166.70.13.68;;;frm=rebecca@bsdio.com;;;spf=pass X-SA-Exim-Connect-IP: 166.70.13.68 X-SA-Exim-Mail-From: rebecca@bsdio.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa04.xmission.com X-Spam-Level: ** X-Spam-Status: No, score=2.3 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG,T_TooManySym_01,TooManyTo_001, TooManyTo_002,XMSubLong,XMSubMetaSx_00 autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5257] * 0.3 TooManyTo_001 Multiple "To" Header Recipients 2x (uncommon) * 0.5 TooManyTo_002 Multiple "To" Header Recipients 3x (uncommon) * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa04 1397; IP=ok Body=1 Fuz1=1] [Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject * 1.0 XMSubMetaSx_00 1+ Sexy Words X-Spam-DCC: XMission; sa04 1397; IP=ok Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: =?ISO-8859-1?Q?**;Laszlo Ersek , Philippe Mathieu-Daud=c3=a9 , devel@edk2.groups.io?= X-Spam-Relay-Country: X-Spam-Timing: total 413 ms - load_scoreonly_sql: 0.08 (0.0%), signal_user_changed: 12 (2.9%), b_tie_ro: 10 (2.5%), parse: 1.30 (0.3%), extract_message_metadata: 4.5 (1.1%), get_uri_detail_list: 0.53 (0.1%), tests_pri_-1000: 3.2 (0.8%), tests_pri_-950: 1.36 (0.3%), tests_pri_-900: 1.15 (0.3%), tests_pri_-90: 152 (36.8%), check_bayes: 150 (36.2%), b_tokenize: 6 (1.4%), b_tok_get_all: 87 (21.1%), b_comp_prob: 3.7 (0.9%), b_tok_touch_all: 49 (11.9%), b_finish: 1.39 (0.3%), tests_pri_0: 218 (52.8%), check_dkim_signature: 0.96 (0.2%), check_dkim_adsp: 47 (11.5%), poll_dns_idle: 35 (8.6%), tests_pri_10: 4.0 (1.0%), tests_pri_500: 12 (3.0%), rewrite_mail: 0.00 (0.0%) Subject: Re: [edk2-devel] [PATCH] OvmfPkg: replace old EFI_D_ debug levels with new DEBUG_ ones X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 4/28/20 6:44 AM, Laszlo Ersek wrote: > > Rebecca: thanks for the contribution. Personally I'd have preferred a > finer-grained approach here, but Phil removed the review burden on me. > > Regarding the git history, edk2 unfortunately alreay carries a bunch of > similarly large (even huge) coding style update patches, so I I can't > hold that perspective against the patch. Thanks. I did think I'd get some push-back against such a large patch and considered splitting it up but given it is such a simple, mechanical change I decided to submit it as is. -- Rebecca Cran