From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=ryszard.knop@linux.intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 348B8211BFCA3 for ; Wed, 30 Jan 2019 09:26:35 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 09:26:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,541,1539673200"; d="scan'208";a="122617173" Received: from linux.intel.com ([10.54.29.200]) by orsmga003.jf.intel.com with ESMTP; 30 Jan 2019 09:26:34 -0800 Received: from torii (torii.igk.intel.com [10.102.24.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id AB2D0580297; Wed, 30 Jan 2019 09:26:32 -0800 (PST) Message-ID: <5d96a29db8d2bc102e1765be3c52bc3cbab3e958.camel@linux.intel.com> From: Ryszard Knop To: Ard Biesheuvel , edk2-devel@lists.01.org, "Carsey, Jaben" Cc: kamil.kacperski@intel.com, eric.jin@intel.com, pawel.orlowski@intel.com, michael.d.kinney@intel.com, harry.l.hsiung@intel.com Date: Wed, 30 Jan 2019 18:26:30 +0100 In-Reply-To: <20181115023353.20159-11-ard.biesheuvel@linaro.org> References: <20181115023353.20159-1-ard.biesheuvel@linaro.org> <20181115023353.20159-11-ard.biesheuvel@linaro.org> Organization: Intel Corporation User-Agent: Evolution 3.30.4 Mime-Version: 1.0 Subject: Re: [PATCH edk2-staging 10/20] IntelUndiPkg/XGigUndiDxe: drop StdLibC library class reference X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 17:26:35 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit That's actually not quite correct - we need this package to build on IA32. It's named rather unfortunately, since it's not the EDK2 StdLibC, but rather a package in this repository - see IntelUndiPkg/LibC. It contains the bare minimum of functionality required to fix missing 64- bit math/shifts on IA32 and missing memcpy/memset intrinsics. We can't prevent MSVC from yielding memcpy/memset either, so this was the nasty solution for build issues. You have included CompilerIntrinsicsLib for the same reason, too :) I'm not aware of any X64/IA32 equivalent of your CompilerIntrinsicsLib, but I'd be happy to be proven wrong here. I'm off for the rest of the week - I'll continue with reviews and merging early next week. Thanks, Richard. On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote: > StdLibc should not be used in drivers (it has dependencies on Shell > protocols), but in fact, we don't appear to rely on it in the first > place, so just drop the reference. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > index beee8aa8134e..b5747565fbea 100644 > --- a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > +++ b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > @@ -132,7 +132,6 @@ GCC:*_*_*_CC_FLAGS = -DEFI32 > PrintLib > UefiLib > HiiLib > - StdLibC > > [LibraryClasses.X64] >