From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Tue, 07 May 2019 05:53:35 -0700
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 6F6C7307D92F;
	Tue,  7 May 2019 12:53:34 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-152.rdu2.redhat.com [10.10.120.152])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 23DE11001DF5;
	Tue,  7 May 2019 12:53:32 +0000 (UTC)
Subject: Re: [edk2-devel] [edk2-platforms] [patch 1/7] Platform/AMD: Update UefiDecompressLib instance
To: devel@edk2.groups.io, leif.lindholm@linaro.org,
 Dandan Bi <dandan.bi@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
 Michael D Kinney <michael.d.kinney@intel.com>
References: <20190505080537.22000-1-dandan.bi@intel.com>
 <20190505080537.22000-2-dandan.bi@intel.com>
 <20190507113105.22gvbhueojdfrynn@bivouac.eciton.net>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <5dd5d245-1ad2-ca92-0308-056de6d356b5@redhat.com>
Date: Tue, 7 May 2019 14:53:25 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190507113105.22gvbhueojdfrynn@bivouac.eciton.net>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Tue, 07 May 2019 12:53:34 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 05/07/19 13:31, Leif Lindholm wrote:
> Hi Dandan,
> 
> Sorry to be a pain, but could you follow the steps in
> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-09
> and then regenerate these patches and send out again?
> 
> That way, it is obvious from the diff which sections are being
> modified.

(
also needed:

  git config diff.ini.xfuncname '^\[[A-Za-z0-9_., ]+]'

from

https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-05

thanks
Laszlo
)