From: "Maciej Rabeda" <maciej.rabeda@linux.intel.com>
To: Sivaraman Nainar <sivaramann@amiindia.co.in>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: reg: [edk2-devel] [PATCH] Adding the MAC in the HTTP Boot Title
Date: Wed, 9 Dec 2020 17:01:50 +0100 [thread overview]
Message-ID: <5df1d04d-beb4-c394-d93c-270471044462@linux.intel.com> (raw)
In-Reply-To: <B4DE137BDB63634BAC03BD9DE765F19702E3D8C47B@VENUS1.in.megatrends.com>
[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]
Please provide a patch in the way described in the process.
Formal:
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
Informal:
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers
Thanks,
Maciej
On 09-Dec-20 07:36, Sivaraman Nainar wrote:
>
> Hello all:
>
> Here with added the patch for displaying the MAC Address along with
> the HTTP Boot Option Title. Please review and comment.
>
> ---
> NetworkPkg/HttpBootDxe/HttpBootConfig.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootConfig.c
> b/NetworkPkg/HttpBootDxe/HttpBootConfig.c
> index 646c907b12..677d913a09 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootConfig.c
> +++ b/NetworkPkg/HttpBootDxe/HttpBootConfig.c
> @@ -629,6 +629,18 @@ HttpBootConfigFormInit (
> NULL
> );
>
> + OldMenuString = HiiGetString (
> + CallbackInfo->RegisteredHandle,
> + STRING_TOKEN (STR_HTTP_BOOT_CONFIG_FORM_TITLE),
> + NULL
> + );
> + UnicodeSPrint (MenuString, 128, L"MAC:%s-%s",
> MacString,OldMenuString);
> + HiiSetString (
> + CallbackInfo->RegisteredHandle,
> + STRING_TOKEN (STR_HTTP_BOOT_CONFIG_FORM_TITLE),
> + MenuString,
> + NULL
> + );
> FreePool (MacString);
> FreePool (OldMenuString);
>
[-- Attachment #2: Type: text/html, Size: 5312 bytes --]
prev parent reply other threads:[~2020-12-09 16:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 6:36 reg: [edk2-devel] [PATCH] Adding the MAC in the HTTP Boot Title Sivaraman Nainar
2020-12-09 16:01 ` Maciej Rabeda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5df1d04d-beb4-c394-d93c-270471044462@linux.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox