From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web08.8999.1607529718953618194 for ; Wed, 09 Dec 2020 08:01:59 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: linux.intel.com, ip: 134.134.136.100, mailfrom: maciej.rabeda@linux.intel.com) IronPort-SDR: 6PHoL4UwXJrvlq2RSMuB1fca95N6nied45IpsJMCSspzLbiXIokhTU4tscdLXywjzAEsZkQnYb cdVSqOnbHOiA== X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="238202429" X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208,217";a="238202429" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2020 08:01:57 -0800 IronPort-SDR: +OflojX2qx0vXHH+VY0PqGufKWBkc0TWIQWIV7KLVQC1uS/qywoyhADZHQT81WRtbmi2sj4Aml 3jIJtEmI2Udw== X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208,217";a="364191404" Received: from mrabeda-mobl.ger.corp.intel.com (HELO [10.252.54.79]) ([10.252.54.79]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2020 08:01:56 -0800 Subject: Re: reg: [edk2-devel] [PATCH] Adding the MAC in the HTTP Boot Title To: Sivaraman Nainar , "devel@edk2.groups.io" References: From: "Maciej Rabeda" Message-ID: <5df1d04d-beb4-c394-d93c-270471044462@linux.intel.com> Date: Wed, 9 Dec 2020 17:01:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------1CEF0EB63F0FB3A9F083737B" Content-Language: pl --------------1CEF0EB63F0FB3A9F083737B Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Please provide a patch in the way described in the process. Formal: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process Informal: https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers Thanks, Maciej On 09-Dec-20 07:36, Sivaraman Nainar wrote: > > Hello all: > > Here with added the patch for displaying the MAC Address along with > the HTTP Boot Option Title. Please review and comment. > > --- > NetworkPkg/HttpBootDxe/HttpBootConfig.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/NetworkPkg/HttpBootDxe/HttpBootConfig.c > b/NetworkPkg/HttpBootDxe/HttpBootConfig.c > index 646c907b12..677d913a09 100644 > --- a/NetworkPkg/HttpBootDxe/HttpBootConfig.c > +++ b/NetworkPkg/HttpBootDxe/HttpBootConfig.c > @@ -629,6 +629,18 @@ HttpBootConfigFormInit ( > NULL > ); > > + OldMenuString = HiiGetString ( > + CallbackInfo->RegisteredHandle, > + STRING_TOKEN (STR_HTTP_BOOT_CONFIG_FORM_TITLE), > + NULL > + ); > + UnicodeSPrint (MenuString, 128, L"MAC:%s-%s", > MacString,OldMenuString); > + HiiSetString ( > + CallbackInfo->RegisteredHandle, > + STRING_TOKEN (STR_HTTP_BOOT_CONFIG_FORM_TITLE), > + MenuString, > + NULL > + ); > FreePool (MacString); > FreePool (OldMenuString); > --------------1CEF0EB63F0FB3A9F083737B Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: 8bit Please provide a patch in the way described in the process.
Formal: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
Informal: https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers

Thanks,
Maciej

On 09-Dec-20 07:36, Sivaraman Nainar wrote:

Hello all:

Here with added the patch for displaying the MAC Address along with the HTTP Boot Option Title. Please review and comment.

---
NetworkPkg/HttpBootDxe/HttpBootConfig.c | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/NetworkPkg/HttpBootDxe/HttpBootConfig.c b/NetworkPkg/HttpBootDxe/HttpBootConfig.c
index 646c907b12..677d913a09 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootConfig.c
+++ b/NetworkPkg/HttpBootDxe/HttpBootConfig.c
@@ -629,6 +629,18 @@ HttpBootConfigFormInit (
NULL
);

+ OldMenuString = HiiGetString (
+ CallbackInfo->RegisteredHandle,
+ STRING_TOKEN (STR_HTTP_BOOT_CONFIG_FORM_TITLE),
+ NULL
+ );
+ UnicodeSPrint (MenuString, 128, L"MAC:%s-%s", MacString,OldMenuString);
+ HiiSetString (
+ CallbackInfo->RegisteredHandle,
+ STRING_TOKEN (STR_HTTP_BOOT_CONFIG_FORM_TITLE),
+ MenuString,
+ NULL
+ );
FreePool (MacString);
FreePool (OldMenuString);

--------------1CEF0EB63F0FB3A9F083737B--