Re: [edk2-devel] [Patch 2/4] BaseTools/Scripts/PatchCheck: Return CommitMessageCheck errors

["Michael Kubacki" <mikuback@linux.microsoft.com>]

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 2/18/2024 3:59 PM, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4693
> 
> Commit signatures are checked and error messages are logged but
> errors are not captured and returned from find_signatures() in the
> CommitMessageCheck class. This causes signature errors to be
> silently ignored by CI.
> 
> Update logic in CommitMessageCheck class to return errors
> detected in commit message signatures.
> 
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>   BaseTools/Scripts/PatchCheck.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py
> index e600e0be440f..158a2b30a5ce 100755
> --- a/BaseTools/Scripts/PatchCheck.py
> +++ b/BaseTools/Scripts/PatchCheck.py
> @@ -202,7 +202,7 @@ class CommitMessageCheck:
>               if s[2] != ' ':
>                   self.error("There should be a space after '" + sig + ":'")
>   
> -            EmailAddressCheck(s[3], sig)
> +            self.ok &= EmailAddressCheck(s[3], sig).ok
>   
>           return sigs
>   


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115901): https://edk2.groups.io/g/devel/message/115901
Mute This Topic: https://groups.io/mt/104434583/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-