From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9BB56AC0A0F for ; Sat, 24 Feb 2024 01:26:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Ai9J2O0jl6+XPTz2b4c8od69r55j0SU9mvpYzIqSOpI=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708737973; v=1; b=i67CX5QS5Ep1s45vH8x9mn4+Q709RoTaZjMnboy7aElh4w2zbTkWj6S1CDgmCIUehohokjdm o8CvmV4Y2re1DNBxqLad1n3yckxBAG20gb8JrivMDdTQSywcHsQLNw7TzI7xJHfcl3zGPQO7/AA nNNpwKTRrkHnC8G7TYsW6FlU= X-Received: by 127.0.0.2 with SMTP id wFRbYY7687511xQ9oawQv5Zx; Fri, 23 Feb 2024 17:26:13 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.11314.1708737972570068458 for ; Fri, 23 Feb 2024 17:26:12 -0800 X-Received: from [10.0.0.154] (unknown [20.39.63.0]) by linux.microsoft.com (Postfix) with ESMTPSA id 87A9E20B74C0; Fri, 23 Feb 2024 17:26:11 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 87A9E20B74C0 Message-ID: <5df845c3-2def-4a78-9472-6a3edfbb13c0@linux.microsoft.com> Date: Fri, 23 Feb 2024 20:26:10 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [Patch 2/4] BaseTools/Scripts/PatchCheck: Return CommitMessageCheck errors To: Michael D Kinney , devel@edk2.groups.io Cc: Rebecca Cran , Liming Gao , Bob Feng , Yuwei Chen References: <20240218205951.497-1-michael.d.kinney@intel.com> <20240218205951.497-3-michael.d.kinney@intel.com> From: "Michael Kubacki" In-Reply-To: <20240218205951.497-3-michael.d.kinney@intel.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: mlo9d6aYMt2oFfMeTNI3Pzpwx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=i67CX5QS; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Michael Kubacki On 2/18/2024 3:59 PM, Michael D Kinney wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4693 >=20 > Commit signatures are checked and error messages are logged but > errors are not captured and returned from find_signatures() in the > CommitMessageCheck class. This causes signature errors to be > silently ignored by CI. >=20 > Update logic in CommitMessageCheck class to return errors > detected in commit message signatures. >=20 > Cc: Rebecca Cran > Cc: Liming Gao > Cc: Bob Feng > Cc: Yuwei Chen > Cc: Michael Kubacki > Signed-off-by: Michael D Kinney > --- > BaseTools/Scripts/PatchCheck.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchChe= ck.py > index e600e0be440f..158a2b30a5ce 100755 > --- a/BaseTools/Scripts/PatchCheck.py > +++ b/BaseTools/Scripts/PatchCheck.py > @@ -202,7 +202,7 @@ class CommitMessageCheck: > if s[2] !=3D ' ': > self.error("There should be a space after '" + sig + ":= '") > =20 > - EmailAddressCheck(s[3], sig) > + self.ok &=3D EmailAddressCheck(s[3], sig).ok > =20 > return sigs > =20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115901): https://edk2.groups.io/g/devel/message/115901 Mute This Topic: https://groups.io/mt/104434583/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-