From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (EUR02-DB5-obe.outbound.protection.outlook.com [40.107.249.80]) by mx.groups.io with SMTP id smtpd.web10.10927.1673000868730108230 for ; Fri, 06 Jan 2023 02:27:49 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Wp1fj0jV; spf=pass (domain: arm.com, ip: 40.107.249.80, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B7JC8ys3F3Ednt6UbC4eAS8EzR3K2gZmdDIybpEp2OA=; b=Wp1fj0jVPDfDE+7wPzMtDM/ZPvZ2LObgcIDVgOK2gkaKI28FvYtSE1V1E3Z94kJ+Gam5Drqlm0QUntJ6prtcQxxNHRg6kPfln8uDMwLvaNBKDujfh3lrVhpQQJ7WLO0MWRsbbGpTRM4jP9kBGkTAWejNZSzl89hwSRVtltKA0Ps= Received: from DB7PR05CA0052.eurprd05.prod.outlook.com (2603:10a6:10:2e::29) by PA4PR08MB6093.eurprd08.prod.outlook.com (2603:10a6:102:e8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.9; Fri, 6 Jan 2023 10:27:44 +0000 Received: from DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2e:cafe::58) by DB7PR05CA0052.outlook.office365.com (2603:10a6:10:2e::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.15 via Frontend Transport; Fri, 6 Jan 2023 10:27:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT045.mail.protection.outlook.com (100.127.142.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.17 via Frontend Transport; Fri, 6 Jan 2023 10:27:44 +0000 Received: ("Tessian outbound 6e565e48ed4a:v132"); Fri, 06 Jan 2023 10:27:44 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ea5b9450d38ce524 X-CR-MTA-TID: 64aa7808 Received: from 2168d04da765.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3D9817A0-7B43-472A-82DE-49F0A114C689.1; Fri, 06 Jan 2023 10:27:37 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2168d04da765.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 06 Jan 2023 10:27:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GNJ0yCbGtOrAAeJ+I7aTdrgGlNZY/YrjKmDVXkTvf+xZpFAA89JKO3hosmAwPv8j4fzLzmzk5Kw3tYZLBLGFOn3h7vXQF+frtnE4DQ+Wl+oKJCo9iMHpASgmnHIBTRUrcJHaAafyQOTVmFvyFNiSfQ7rkQCst3eg0R97wQ1L2LddBBkCIpO3zAxVF2p7sT6oR5LqBzighO7sj5hcGOgDI/pNh/9T2woSugQ0KteJKfZuAgQtfmlNGz3yGAzSdYELEQbCo83wW7qyeYjB25BOoKpbxHMMHeYHt9gCwWT7oqwf+nVwgEYUj23tBLw+DG0g2ag9IsXXzVktUqlE7Ou2qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B7JC8ys3F3Ednt6UbC4eAS8EzR3K2gZmdDIybpEp2OA=; b=HqQFB2ub4PGDObNFuoqSJLqLT+c7yNKkNJntemxZX8NGd+pliWOhuOpLWXD8nguzOSMIzW73bvj3hmigch7X5vgXeoRZpQFyAwq0LCAy5tZm5S9T9OuB1mxevldUdMpNobkp/Pji4NgGMJ8irN6VYlJmJJ0usNtomivo/S/qU5eb/PHZNnvhC3ZML9Y3IVVURH/zi5LB7lPHK/N8iASIYKjC9ac0FejVKuprdllCaUou84TL2aKS8C6yixTAQTFm5HPoVO1PI1MUyVcj0NbYVr6BQCncqUg6b8d0yzAidOnxZR0QtB5absI5oDBBUi5qzkWzVlOKQJjitr1ftmFhSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B7JC8ys3F3Ednt6UbC4eAS8EzR3K2gZmdDIybpEp2OA=; b=Wp1fj0jVPDfDE+7wPzMtDM/ZPvZ2LObgcIDVgOK2gkaKI28FvYtSE1V1E3Z94kJ+Gam5Drqlm0QUntJ6prtcQxxNHRg6kPfln8uDMwLvaNBKDujfh3lrVhpQQJ7WLO0MWRsbbGpTRM4jP9kBGkTAWejNZSzl89hwSRVtltKA0Ps= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by PAWPR08MB8791.eurprd08.prod.outlook.com (2603:10a6:102:334::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.9; Fri, 6 Jan 2023 10:27:34 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::5899:7a52:822b:56e0]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::5899:7a52:822b:56e0%9]) with mapi id 15.20.5986.009; Fri, 6 Jan 2023 10:27:34 +0000 Message-ID: <5e08de94-37ec-2d74-a1d4-3468540d462c@arm.com> Date: Fri, 6 Jan 2023 10:27:32 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string To: devel@edk2.groups.io, Ard Biesheuvel , moritzf@google.com CC: "nd@arm.com" References: <20230105230725.2401243-1-moritzf@google.com> <1737AFAF4745C39B.7095@groups.io> From: "Sami Mujawar" In-Reply-To: <1737AFAF4745C39B.7095@groups.io> X-ClientProxiedBy: LO2P265CA0323.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::23) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|PAWPR08MB8791:EE_|DBAEUR03FT045:EE_|PA4PR08MB6093:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f08cef7-9ad4-4f67-b2e0-08daefd0a5e1 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vg5gebyUyGsVqo21jExE4UvTehosS7aeur/o/YDLq+FRjGBNtKKR7Zm3J3dEHA9RttwvJiNIno0Al3ahzWGzRCkxwEhJ1jssgi5uiSaTshVaH19n2/mvZkL6M/jSUCS7jZVevajCKL8x/Ltqhzl4C37mEiuKr0oAPzE8N45MN6IuLORyTtlToEFFPGwODV86jVnNjznWQ6MonrWp29udDCLfgaj+kQAYbLx89GqkT6q0yZQ0D5bVyara+4R9QgF6FQXCdregTDFuS7MR9SXVPbCs/F5912ckYuUddH194KQdZH2narpn8DMFgOa/Xes10We4gdhRyPKgSDF23Qk7XsW6/cjxDp9HY2mmdujBJKF7ER+LB9oWTgmdUNaZaFvYGJQieBBCSPooNjoTD1qSJgrKOntGaI6XDpHNoPXVQog6ZX4oBEJ9cGnU1aCME5L5GT7ru58eYhSyNpD+njktBdjK+ssGhHjPg+Zvkri0yOtRsy1IDmngu7YBWaz5sor5v+RrhTiKaArUa2DFBMfqPxsIAWNfTx0s9k9tivaBO+XlGHWQFvRbYT5Cgd9Wa2WqEGoCJj2r/uGMUcOEhqYiuaSbnvAbwdUWcjEpNbs7hj3Govh+IfmYKFpRG/ZxSFt4IB28nbH6w5nFgpSFJFYbW1E7oRZl334IHs+PNCutasPfJGLohotTCL87aTFUe84Rf/Gg8mKDd3xpCQE1IXXHGFYJJa00C3s/+IK3Y1vdaOv9f5ohVoUCoCeDhxy3qZSv0OLHw7o+SoX6IaYnZBDpYM1tKx5WsZg04rDZ0ZbgYhs= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(4636009)(346002)(366004)(396003)(39860400002)(136003)(376002)(451199015)(31686004)(66899015)(4326008)(316002)(41300700001)(966005)(5660300002)(8936002)(66556008)(8676002)(66946007)(66476007)(2906002)(44832011)(26005)(38100700002)(6512007)(86362001)(31696002)(478600001)(36756003)(53546011)(186003)(6486002)(2616005)(6506007)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB8791 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 753163eb-267b-456c-767f-08daefd09fb2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c/7ALHPd3hTgyLp+1Fel0JWHqi5p2sbDQ4UWoZQqo0re+debkhXx40hCh3WOwRZUWdMoeoXbxSiAFMZJi9lo0rS511vNbQFkK9lfTDJG2Kfs+IEhSIYKqvzcmwad+xvS6yh5gl2WxY53pzSNNyYeo/QBnboA8PSKoTHvveUo6Rl6ifVYoIBJuCAaehd9owFVuegjfebevuzgCYR6085PgEymR87QRBW6IR+Kppn3ebqKAjZ5pweBqxFjMHadYyKZhmF/+8I5wXrKigfRojcpN6duFwuCNyjWh7+QkCSWNBQ312bgx7dz0WSs/pWljGlPWgoogi1WDalfN0Ks6T+iWHmtv/vqAeJeMxyY3klI/aGgQ0T8sVR1Dj5KMjWZE5Zl0yRJA4DCw3L/KqO7ctI10vbz5Kcq/re3V04JdererZiXG8me73122svpZwltHycbfH2RIts8/Pmf4gBeUPw6gW7T07NXWalCuhUOdan9fAa3BD8rk0v/7Mf8/3tJDBfH+7II2PreBpl7J8jNK+1cZBYQYDRcLjyfIU/Orqc4yCGX1mHze0YKnV7VP8MnYSCdlooB9htn8MUxVGM155oSU+s8RK89i02ieKwA4VTKoaDRshb/rF+BAEpFxroNdBWxF67nQKRbIr2JTq1BXj7RZ5giRChDKC1UuDUNesHbIO2hjGt/Sbc8euvtGIyLHOVa8T4B7wBctgvcBkXFkbf9v39zmq9T1Vrgj2GdjqJOJK7mW6AUZ2EnTJnK3UjvJCQiMfUf7APuAvezjTs6JwioCOtiWLxOmYRgqzJqh5MbBZE= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(6029001)(4636009)(346002)(136003)(396003)(39860400002)(376002)(451199015)(46966006)(36840700001)(40470700004)(66899015)(31686004)(36756003)(44832011)(6486002)(82740400003)(40460700003)(81166007)(356005)(2906002)(8676002)(70206006)(5660300002)(70586007)(8936002)(83380400001)(86362001)(41300700001)(31696002)(4326008)(36860700001)(478600001)(82310400005)(2616005)(336012)(966005)(316002)(53546011)(6512007)(40480700001)(186003)(6506007)(26005)(47076005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 10:27:44.1458 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7f08cef7-9ad4-4f67-b2e0-08daefd0a5e1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6093 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Moritz, Apologies for typing your name incorrectly in my previous email. Regards, Sami Mujawar On 06/01/2023 09:55 am, Sami Mujawar via groups.io wrote: > Hi Ard, Mortiz, > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > On 06/01/2023 09:15 am, Ard Biesheuvel wrote: >> (cc Sami) >> >> On Fri, 6 Jan 2023 at 10:14, Ard Biesheuvel wrote: >>> On Fri, 6 Jan 2023 at 00:07, Moritz Fischer via groups.io >>> wrote: >>>> Linux' cpu DT bindings call out arm,armv8 while the code previously >>>> used arm,arm-v8. >>>> >>>> Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC=20 >>>> parser") >>>> Signed-off-by: Moritz Fischer >>>> --- >>>> DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 2 +- >>>> =C2=A0 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git=20 >>>> a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c=20 >>>> b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c >>>> index 2c72bd0c58..dc6e7a4d15 100644 >>>> --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c >>>> +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c >>>> @@ -22,7 +22,7 @@ >>>> =C2=A0 */ >>>> =C2=A0 STATIC CONST COMPATIBILITY_STR=C2=A0 CpuCompatibleStr[] =3D { >>>> =C2=A0=C2=A0=C2=A0 { "arm,arm-v7"=C2=A0=C2=A0=C2=A0=C2=A0 }, >>>> -=C2=A0 { "arm,arm-v8"=C2=A0=C2=A0=C2=A0=C2=A0 }, >>>> +=C2=A0 { "arm,armv8"=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }, >>> Thanks for the patch >>> >>> Should we keep both instead of removing the old one? > > [SAMI] I think we would need to keep both as the CPU nodes generated=20 > by Kvmtool have compatible string as "arm,arm-v8", see=20 > https://github.com/kvmtool/kvmtool/blob/master/arm/aarch64/arm-cpu.c#L31. > > Mortiz: Is it possible to share some information about your use case,=20 > please? > > [/SAMI] > >>> >>>> =C2=A0=C2=A0=C2=A0 { "arm,cortex-a15" }, >>>> =C2=A0=C2=A0=C2=A0 { "arm,cortex-a7"=C2=A0 }, >>>> =C2=A0=C2=A0=C2=A0 { "arm,cortex-a57" } >>>> --=20 >>>> 2.39.0.314.g84b9a713c41-goog >>>> >>>> >>>> >>>> >>>> >>>> > > >=20 > >